llvm-project/lld/test/ELF/as-needed-in-regular.s
Fangrui Song 51fe635f81 [ELF] Move IsNeeded logic from SymbolTable::addShared to MarkLive, and check IsUsedInRegularObj
Summary:
In glibc, libc.so is a linker script with an as-needed dependency on ld-linux-x86-64.so.2

    GROUP ( /lib/x86_64-linux-gnu/libc.so.6 /usr/lib/x86_64-linux-gnu/libc_nonshared.a  AS_NEEDED ( /lib/x86_64-linux-gnu/ld-linux-x86-64.so.2 ) )

ld-linux-x86-64.so.2 (as-needed) defines some symbols which resolve undefined references in libc.so.6, it will therefore be added as a DT_NEEDED entry, which isn't necessary.

The test case as-needed-not-in-regular.s emulates the libc.so scenario, where ld.bfd and gold don't add DT_NEEDED for a.so

The relevant code in gold/resolve.cc:

  // If we have a non-WEAK reference from a regular object to a
  // dynamic object, mark the dynamic object as needed.
  if (to->is_from_dynobj() && to->in_reg() && !to->is_undef_binding_weak())
    to->object()->set_is_needed();

in_reg() appears to do something similar to IsUsedInRegularObj.

This patch makes lld do the similar thing, but moves the check from
addShared to a later stage MarkLive where all symbols are scanned.

Reviewers: ruiu, pcc, espindola

Reviewed By: ruiu

Subscribers: emaste, arichardson, llvm-commits

Differential Revision: https://reviews.llvm.org/D55902

llvm-svn: 349849
2018-12-20 22:46:01 +00:00

25 lines
755 B
ArmAsm

# REQUIRES: x86
# RUN: echo '.globl a; .type a, @function; .type a, @function; a: ret' | \
# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux - -o %ta.o
# RUN: ld.lld %ta.o --shared --soname=a.so -o %ta.so
# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t.o
# RUN: ld.lld %t.o --as-needed %ta.so -o %t
# RUN: llvm-readelf -d %t | FileCheck %s
# RUN: ld.lld %t.o --as-needed %ta.so --gc-sections -o %t
# RUN: llvm-readelf -d %t | FileCheck %s
# The order of %ta.so and %t.o does not matter.
# RUN: ld.lld --as-needed %ta.so %t.o -o %t
# RUN: llvm-readelf -d %t | FileCheck %s
# RUN: ld.lld --as-needed %ta.so %t.o --gc-sections -o %t
# RUN: llvm-readelf -d %t | FileCheck %s
# CHECK: a.so
.global _start
_start:
jmp a@PLT