mirror of
https://github.com/llvm/llvm-project.git
synced 2025-05-09 15:06:06 +00:00
45b4014711
'#pragma pack (pop)' and suspicious uses of '#pragma pack' in included files The second recommit (r309106) was reverted because the "non-default #pragma pack value chages the alignment of struct or union members in the included file" warning proved to be too aggressive for external projects like Chromium (https://bugs.chromium.org/p/chromium/issues/detail?id=749197). This recommit makes the problematic warning a non-default one, and gives it the -Wpragma-pack-suspicious-include warning option. The first recommit (r308441) caused a "non-default #pragma pack value might change the alignment of struct or union members in the included file" warning in LLVM itself. This recommit tweaks the added warning to avoid warnings for #includes that don't have any records that are affected by the non-default alignment. This tweak avoids the previously emitted warning in LLVM. Original message: This commit adds a new -Wpragma-pack warning. It warns in the following cases: - When a translation unit is missing terminating #pragma pack (pop) directives. - When entering an included file if the current alignment value as determined by '#pragma pack' directives is different from the default alignment value. - When leaving an included file that changed the state of the current alignment value. rdar://10184173 Differential Revision: https://reviews.llvm.org/D35484 llvm-svn: 309386
51 lines
1.7 KiB
C
51 lines
1.7 KiB
C
// RUN: %clang_cc1 -fsyntax-only -Wno-pragma-pack -verify %s
|
|
|
|
// Note that this puts the expected lines before the directives to work around
|
|
// limitations in the -verify mode.
|
|
|
|
/* expected-warning {{missing '(' after '#pragma pack'}}*/ #pragma pack 10
|
|
#pragma pack()
|
|
#pragma pack(8)
|
|
|
|
/*expected-warning {{unknown action for '#pragma pack'}}*/ #pragma pack(hello)
|
|
#pragma pack(push)
|
|
#pragma pack(pop)
|
|
|
|
/* expected-warning {{expected integer or identifier in '#pragma pack'}}*/ #pragma pack(push,)
|
|
/* expected-warning {{expected integer or identifier in '#pragma pack'}}*/ #pragma pack(push,)
|
|
/* expected-warning {{expected integer or identifier in '#pragma pack'}}*/ #pragma pack(pop,)
|
|
|
|
#pragma pack(push,i)
|
|
/* expected-warning {{expected integer or identifier in '#pragma pack'}}*/ #pragma pack(push,i,
|
|
/* expected-warning {{expected integer or identifier in '#pragma pack'}}*/ #pragma pack(push,i,)
|
|
/* expected-warning {{expected integer or identifier in '#pragma pack'}}*/ #pragma pack(push,i,help)
|
|
|
|
#pragma pack(push,8)
|
|
/* expected-warning {{missing ')' after '#pragma pack'}}*/ #pragma pack(push,8,
|
|
/* expected-warning {{missing ')' after '#pragma pack'}}*/ #pragma pack(push,8,)
|
|
/* expected-warning {{missing ')' after '#pragma pack'}}*/ #pragma pack(push,i,8
|
|
#pragma pack(push,i,8)
|
|
|
|
/* expected-warning {{missing ')' after '#pragma pack'}}*/ #pragma pack(push
|
|
|
|
_Pragma("pack(push)")
|
|
/* expected-warning {{expected integer or identifier in '#pragma pack'}}*/ _Pragma("pack(push,)")
|
|
|
|
// PR13580
|
|
struct S
|
|
{
|
|
char a[3];
|
|
#pragma pack(1)
|
|
struct T
|
|
{
|
|
char b;
|
|
int c;
|
|
} d;
|
|
#pragma pack()
|
|
int e;
|
|
};
|
|
|
|
_Pragma("pack(push, 1)") struct PR28094 {
|
|
int a;
|
|
} _Pragma("pack(pop)");
|