mirror of
https://github.com/llvm/llvm-project.git
synced 2025-04-26 02:36:06 +00:00
ffe7950ebc
I'm trying to remove unused options from the `Analyses.def` file, then merge the rest of the useful options into the `AnalyzerOptions.def`. Then make sure one can set these by an `-analyzer-config XXX=YYY` style flag. Then surface the `-analyzer-config` to the `clang` frontend; After all of this, we can pursue the tablegen approach described https://discourse.llvm.org/t/rfc-tablegen-clang-static-analyzer-engine-options-for-better-documentation/61488 In this patch, I'm proposing flag deprecations. We should support deprecated analyzer flags for exactly one release. In this case I'm planning to drop this flag in `clang-16`. In the clang frontend, now we won't pass this option to the cc1 frontend, rather emit a warning diagnostic reminding the users about this deprecated flag, which will be turned into error in clang-16. Unfortunately, I had to remove all the tests referring to this flag, causing a mass change. I've also added a test for checking this warning. I've seen that `scan-build` also uses this flag, but I think we should remove that part only after we turn this into a hard error. Reviewed By: martong Differential Revision: https://reviews.llvm.org/D126215
48 lines
2.6 KiB
C
48 lines
2.6 KiB
C
// RUN: %clang_analyze_cc1 -analyzer-checker=core,osx.coreFoundation.CFNumber,osx.cocoa.RetainCount -verify -triple x86_64-apple-darwin9 %s
|
|
|
|
typedef signed long CFIndex;
|
|
typedef const struct __CFAllocator * CFAllocatorRef;
|
|
enum { kCFNumberSInt8Type = 1, kCFNumberSInt16Type = 2,
|
|
kCFNumberSInt32Type = 3, kCFNumberSInt64Type = 4,
|
|
kCFNumberFloat32Type = 5, kCFNumberFloat64Type = 6,
|
|
kCFNumberCharType = 7, kCFNumberShortType = 8,
|
|
kCFNumberIntType = 9, kCFNumberLongType = 10,
|
|
kCFNumberLongLongType = 11, kCFNumberFloatType = 12,
|
|
kCFNumberDoubleType = 13, kCFNumberCFIndexType = 14,
|
|
kCFNumberNSIntegerType = 15, kCFNumberCGFloatType = 16,
|
|
kCFNumberMaxType = 16 };
|
|
typedef CFIndex CFNumberType;
|
|
typedef const struct __CFNumber * CFNumberRef;
|
|
typedef unsigned char Boolean;
|
|
extern CFNumberRef CFNumberCreate(CFAllocatorRef allocator, CFNumberType theType, const void *valuePtr);
|
|
Boolean CFNumberGetValue(CFNumberRef number, CFNumberType theType, void *valuePtr);
|
|
|
|
__attribute__((cf_returns_retained)) CFNumberRef f1(unsigned char x) {
|
|
return CFNumberCreate(0, kCFNumberSInt16Type, &x); // expected-warning{{An 8-bit integer is used to initialize a CFNumber object that represents a 16-bit integer; 8 bits of the CFNumber value will be garbage}}
|
|
}
|
|
|
|
__attribute__((cf_returns_retained)) CFNumberRef f2(unsigned short x) {
|
|
return CFNumberCreate(0, kCFNumberSInt8Type, &x); // expected-warning{{A 16-bit integer is used to initialize a CFNumber object that represents an 8-bit integer; 8 bits of the integer value will be lost}}
|
|
}
|
|
|
|
// test that the attribute overrides the naming convention.
|
|
__attribute__((cf_returns_not_retained)) CFNumberRef CreateNum(unsigned char x) {
|
|
return CFNumberCreate(0, kCFNumberSInt8Type, &x); // expected-warning{{leak}}
|
|
}
|
|
|
|
__attribute__((cf_returns_retained)) CFNumberRef f3(unsigned i) {
|
|
return CFNumberCreate(0, kCFNumberLongType, &i); // expected-warning{{A 32-bit integer is used to initialize a CFNumber object that represents a 64-bit integer}}
|
|
}
|
|
|
|
unsigned char getValueTest1(CFNumberRef x) {
|
|
unsigned char scalar = 0;
|
|
CFNumberGetValue(x, kCFNumberSInt16Type, &scalar); // expected-warning{{A CFNumber object that represents a 16-bit integer is used to initialize an 8-bit integer; 8 bits of the CFNumber value will overwrite adjacent storage}}
|
|
return scalar;
|
|
}
|
|
|
|
unsigned char getValueTest2(CFNumberRef x) {
|
|
unsigned short scalar = 0;
|
|
CFNumberGetValue(x, kCFNumberSInt8Type, &scalar); // expected-warning{{A CFNumber object that represents an 8-bit integer is used to initialize a 16-bit integer; 8 bits of the integer value will be garbage}}
|
|
return scalar;
|
|
}
|