mirror of
https://github.com/llvm/llvm-project.git
synced 2025-04-25 10:56:06 +00:00
8138d85f63
A clang user pointed out that messages for the static analyzer undefined assignment checker use the term ‘garbage’, which might have a negative connotation to some users. This change updates the messages to use the term ‘uninitialized’. This is the usual reason why a value is undefined in the static analyzer and describes the logical error that a programmer should take action to fix. Out-of-bounds reads can also produce undefined values in the static analyzer. The right long-term design is to have to the array bounds checker cover out-of-bounds reads, so we do not cover that case in the updated messages. The recent improvements to the array bounds checker make it a candidate to add to the core set of checkers. rdar://133418644
259 lines
9.7 KiB
C++
259 lines
9.7 KiB
C++
// RUN: %clang_cc1 -std=c++14 -triple i386-apple-darwin10 -analyze -analyzer-config eagerly-assume=false -analyzer-checker=core.uninitialized.Assign,core.builtin,debug.ExprInspection,core.uninitialized.UndefReturn -verify %s
|
||
|
||
template <typename T>
|
||
void clang_analyzer_dump(T x);
|
||
void clang_analyzer_eval(int);
|
||
|
||
struct S {
|
||
int a = 3;
|
||
};
|
||
S const sarr[2] = {};
|
||
void definit() {
|
||
int i = 1;
|
||
// FIXME: Should recognize that it is 3.
|
||
clang_analyzer_eval(sarr[i].a); // expected-warning{{UNKNOWN}}
|
||
}
|
||
|
||
int const glob_arr1[3] = {};
|
||
void glob_array_index1() {
|
||
clang_analyzer_eval(glob_arr1[0] == 0); // expected-warning{{TRUE}}
|
||
clang_analyzer_eval(glob_arr1[1] == 0); // expected-warning{{TRUE}}
|
||
clang_analyzer_eval(glob_arr1[2] == 0); // expected-warning{{TRUE}}
|
||
}
|
||
|
||
void glob_invalid_index1() {
|
||
const int *ptr = glob_arr1;
|
||
int idx = -42;
|
||
auto x = ptr[idx]; // expected-warning{{uninitialized}}
|
||
}
|
||
|
||
void glob_symbolic_index1(int idx) {
|
||
clang_analyzer_dump(glob_arr1[idx]); // expected-warning{{Unknown}}
|
||
}
|
||
|
||
int const glob_arr2[4] = {1, 2};
|
||
void glob_ptr_index1() {
|
||
int const *ptr = glob_arr2;
|
||
clang_analyzer_eval(ptr[0] == 1); // expected-warning{{TRUE}}
|
||
clang_analyzer_eval(ptr[1] == 2); // expected-warning{{TRUE}}
|
||
clang_analyzer_eval(ptr[2] == 0); // expected-warning{{TRUE}}
|
||
clang_analyzer_eval(ptr[3] == 0); // expected-warning{{TRUE}}
|
||
clang_analyzer_eval(ptr[4] == 0); // expected-warning{{UNDEFINED}}
|
||
}
|
||
|
||
void glob_invalid_index2() {
|
||
const int *ptr = glob_arr2;
|
||
int idx = 42;
|
||
auto x = ptr[idx]; // expected-warning{{uninitialized}}
|
||
}
|
||
|
||
const float glob_arr3[] = {
|
||
0.0000, 0.0235, 0.0470, 0.0706, 0.0941, 0.1176};
|
||
float no_warn_garbage_value() {
|
||
return glob_arr3[0]; // no-warning (not meaningful)
|
||
}
|
||
|
||
int const glob_arr4[4][2] = {};
|
||
void glob_array_index2() {
|
||
clang_analyzer_eval(glob_arr4[0][0] == 0); // expected-warning{{TRUE}}
|
||
clang_analyzer_eval(glob_arr4[1][0] == 0); // expected-warning{{TRUE}}
|
||
clang_analyzer_eval(glob_arr4[1][1] == 0); // expected-warning{{TRUE}}
|
||
}
|
||
|
||
void glob_invalid_index3() {
|
||
int idx = -42;
|
||
auto x = glob_arr4[1][idx]; // expected-warning{{uninitialized}}
|
||
}
|
||
|
||
void glob_invalid_index4() {
|
||
const int *ptr = glob_arr4[1];
|
||
int idx = -42;
|
||
auto x = ptr[idx]; // expected-warning{{uninitialized}}
|
||
}
|
||
|
||
int const glob_arr5[4][2] = {{1}, 3, 4, 5};
|
||
void glob_array_index3() {
|
||
clang_analyzer_eval(glob_arr5[0][0] == 1); // expected-warning{{TRUE}}
|
||
clang_analyzer_eval(glob_arr5[0][1] == 0); // expected-warning{{TRUE}}
|
||
clang_analyzer_eval(glob_arr5[1][0] == 3); // expected-warning{{TRUE}}
|
||
clang_analyzer_eval(glob_arr5[1][1] == 4); // expected-warning{{TRUE}}
|
||
clang_analyzer_eval(glob_arr5[2][0] == 5); // expected-warning{{TRUE}}
|
||
clang_analyzer_eval(glob_arr5[2][1] == 0); // expected-warning{{TRUE}}
|
||
clang_analyzer_eval(glob_arr5[3][0] == 0); // expected-warning{{TRUE}}
|
||
clang_analyzer_eval(glob_arr5[3][1] == 0); // expected-warning{{TRUE}}
|
||
}
|
||
|
||
void glob_ptr_index2() {
|
||
int const *ptr = glob_arr5[1];
|
||
clang_analyzer_eval(ptr[0] == 3); // expected-warning{{TRUE}}
|
||
clang_analyzer_eval(ptr[1] == 4); // expected-warning{{TRUE}}
|
||
clang_analyzer_eval(ptr[2] == 5); // expected-warning{{UNDEFINED}}
|
||
clang_analyzer_eval(ptr[3] == 0); // expected-warning{{UNDEFINED}}
|
||
clang_analyzer_eval(ptr[4] == 0); // expected-warning{{UNDEFINED}}
|
||
}
|
||
|
||
void glob_invalid_index5() {
|
||
int idx = -42;
|
||
auto x = glob_arr5[1][idx]; // expected-warning{{uninitialized}}
|
||
}
|
||
|
||
void glob_invalid_index6() {
|
||
int const *ptr = &glob_arr5[1][0];
|
||
int idx = 42;
|
||
auto x = ptr[idx]; // expected-warning{{uninitialized}}
|
||
}
|
||
|
||
extern const int glob_arr_no_init[10];
|
||
void glob_array_index4() {
|
||
clang_analyzer_eval(glob_arr_no_init[2]); // expected-warning{{UNKNOWN}}
|
||
}
|
||
|
||
struct S2 {
|
||
static const int arr_no_init[10];
|
||
};
|
||
void struct_arr_index1() {
|
||
clang_analyzer_eval(S2::arr_no_init[2]); // expected-warning{{UNKNOWN}}
|
||
}
|
||
|
||
char const glob_arr6[5] = "123";
|
||
void glob_array_index5() {
|
||
clang_analyzer_eval(glob_arr6[0] == '1'); // expected-warning{{TRUE}}
|
||
clang_analyzer_eval(glob_arr6[1] == '2'); // expected-warning{{TRUE}}
|
||
clang_analyzer_eval(glob_arr6[2] == '3'); // expected-warning{{TRUE}}
|
||
clang_analyzer_eval(glob_arr6[3] == '\0'); // expected-warning{{TRUE}}
|
||
clang_analyzer_eval(glob_arr6[4] == '\0'); // expected-warning{{TRUE}}
|
||
}
|
||
|
||
void glob_ptr_index3() {
|
||
char const *ptr = glob_arr6;
|
||
clang_analyzer_eval(ptr[-42] == '\0'); // expected-warning{{UNDEFINED}}
|
||
clang_analyzer_eval(ptr[0] == '1'); // expected-warning{{TRUE}}
|
||
clang_analyzer_eval(ptr[1] == '2'); // expected-warning{{TRUE}}
|
||
clang_analyzer_eval(ptr[2] == '3'); // expected-warning{{TRUE}}
|
||
clang_analyzer_eval(ptr[3] == '\0'); // expected-warning{{TRUE}}
|
||
clang_analyzer_eval(ptr[4] == '\0'); // expected-warning{{TRUE}}
|
||
clang_analyzer_eval(ptr[5] == '\0'); // expected-warning{{UNDEFINED}}
|
||
clang_analyzer_eval(ptr[6] == '\0'); // expected-warning{{UNDEFINED}}
|
||
}
|
||
|
||
void glob_invalid_index7() {
|
||
int idx = -42;
|
||
auto x = glob_arr6[idx]; // expected-warning{{uninitialized}}
|
||
}
|
||
|
||
void glob_invalid_index8() {
|
||
const char *ptr = glob_arr6;
|
||
int idx = 42;
|
||
auto x = ptr[idx]; // expected-warning{{uninitialized}}
|
||
}
|
||
|
||
char const glob_arr7[5] = {"123"};
|
||
void glob_array_index6() {
|
||
clang_analyzer_eval(glob_arr7[0] == '1'); // expected-warning{{TRUE}}
|
||
clang_analyzer_eval(glob_arr7[1] == '2'); // expected-warning{{TRUE}}
|
||
clang_analyzer_eval(glob_arr7[2] == '3'); // expected-warning{{TRUE}}
|
||
clang_analyzer_eval(glob_arr7[3] == '\0'); // expected-warning{{TRUE}}
|
||
clang_analyzer_eval(glob_arr7[4] == '\0'); // expected-warning{{TRUE}}
|
||
}
|
||
|
||
void glob_invalid_index9() {
|
||
int idx = -42;
|
||
auto x = glob_arr7[idx]; // expected-warning{{uninitialized}}
|
||
}
|
||
|
||
void glob_invalid_index10() {
|
||
const char *ptr = glob_arr7;
|
||
int idx = 42;
|
||
auto x = ptr[idx]; // expected-warning{{uninitialized}}
|
||
}
|
||
|
||
char const *const glob_ptr8 = "123";
|
||
void glob_ptr_index4() {
|
||
clang_analyzer_eval(glob_ptr8[0] == '1'); // expected-warning{{TRUE}}
|
||
clang_analyzer_eval(glob_ptr8[1] == '2'); // expected-warning{{TRUE}}
|
||
clang_analyzer_eval(glob_ptr8[2] == '3'); // expected-warning{{TRUE}}
|
||
clang_analyzer_eval(glob_ptr8[3] == '\0'); // expected-warning{{TRUE}}
|
||
// FIXME: Should be UNDEFINED.
|
||
// We should take into account a declaration in which the literal is used.
|
||
clang_analyzer_eval(glob_ptr8[4] == '\0'); // expected-warning{{TRUE}}
|
||
}
|
||
|
||
void glob_invalid_index11() {
|
||
int idx = -42;
|
||
auto x = glob_ptr8[idx]; // expected-warning{{uninitialized}}
|
||
}
|
||
|
||
void glob_invalid_index12() {
|
||
int idx = 42;
|
||
// FIXME: Should warn {{uninitialized}}
|
||
// We should take into account a declaration in which the literal is used.
|
||
auto x = glob_ptr8[idx]; // no-warning
|
||
}
|
||
|
||
const char16_t *const glob_ptr9 = u"абв";
|
||
void glob_ptr_index5() {
|
||
clang_analyzer_eval(glob_ptr9[0] == u'а'); // expected-warning{{TRUE}}
|
||
clang_analyzer_eval(glob_ptr9[1] == u'б'); // expected-warning{{TRUE}}
|
||
clang_analyzer_eval(glob_ptr9[2] == u'в'); // expected-warning{{TRUE}}
|
||
clang_analyzer_eval(glob_ptr9[3] == '\0'); // expected-warning{{TRUE}}
|
||
}
|
||
|
||
const char32_t *const glob_ptr10 = U"\U0001F607\U0001F608\U0001F609";
|
||
void glob_ptr_index6() {
|
||
clang_analyzer_eval(glob_ptr10[0] == U'\U0001F607'); // expected-warning{{TRUE}}
|
||
clang_analyzer_eval(glob_ptr10[1] == U'\U0001F608'); // expected-warning{{TRUE}}
|
||
clang_analyzer_eval(glob_ptr10[2] == U'\U0001F609'); // expected-warning{{TRUE}}
|
||
clang_analyzer_eval(glob_ptr10[3] == '\0'); // expected-warning{{TRUE}}
|
||
}
|
||
|
||
const wchar_t *const glob_ptr11 = L"\123\u0041\xFF";
|
||
void glob_ptr_index7() {
|
||
clang_analyzer_eval(glob_ptr11[0] == L'\123'); // expected-warning{{TRUE}}
|
||
clang_analyzer_eval(glob_ptr11[1] == L'\u0041'); // expected-warning{{TRUE}}
|
||
clang_analyzer_eval(glob_ptr11[2] == L'\xFF'); // expected-warning{{TRUE}}
|
||
clang_analyzer_eval(glob_ptr11[3] == L'\0'); // expected-warning{{TRUE}}
|
||
}
|
||
|
||
const char *const glob_ptr12 = u8"abc";
|
||
void glob_ptr_index8() {
|
||
clang_analyzer_eval(glob_ptr12[0] == 'a'); // expected-warning{{TRUE}}
|
||
clang_analyzer_eval(glob_ptr12[1] == 'b'); // expected-warning{{TRUE}}
|
||
clang_analyzer_eval(glob_ptr12[2] == 'c'); // expected-warning{{TRUE}}
|
||
clang_analyzer_eval(glob_ptr12[3] == '\0'); // expected-warning{{TRUE}}
|
||
}
|
||
|
||
typedef int Int;
|
||
typedef Int const CInt;
|
||
typedef CInt Arr[2];
|
||
typedef Arr Arr2[4];
|
||
Arr2 glob_arr8 = {{1}, 3, 4, 5}; // const int[4][2]
|
||
void glob_array_typedef1() {
|
||
clang_analyzer_eval(glob_arr8[0][0] == 1); // expected-warning{{TRUE}}
|
||
clang_analyzer_eval(glob_arr8[0][1] == 0); // expected-warning{{TRUE}}
|
||
clang_analyzer_eval(glob_arr8[1][0] == 3); // expected-warning{{TRUE}}
|
||
clang_analyzer_eval(glob_arr8[1][1] == 4); // expected-warning{{TRUE}}
|
||
clang_analyzer_eval(glob_arr8[2][0] == 5); // expected-warning{{TRUE}}
|
||
clang_analyzer_eval(glob_arr8[2][1] == 0); // expected-warning{{TRUE}}
|
||
clang_analyzer_eval(glob_arr8[3][0] == 0); // expected-warning{{TRUE}}
|
||
clang_analyzer_eval(glob_arr8[3][1] == 0); // expected-warning{{TRUE}}
|
||
}
|
||
|
||
const int glob_arr9[2][4] = {{(1), 2, ((3)), 4}, 5, 6, (((7)))};
|
||
void glob_array_parentheses1() {
|
||
clang_analyzer_eval(glob_arr9[0][0] == 1); // expected-warning{{TRUE}}
|
||
clang_analyzer_eval(glob_arr9[0][1] == 2); // expected-warning{{TRUE}}
|
||
clang_analyzer_eval(glob_arr9[0][2] == 3); // expected-warning{{TRUE}}
|
||
clang_analyzer_eval(glob_arr9[0][3] == 4); // expected-warning{{TRUE}}
|
||
clang_analyzer_eval(glob_arr9[1][0] == 5); // expected-warning{{TRUE}}
|
||
clang_analyzer_eval(glob_arr9[1][1] == 6); // expected-warning{{TRUE}}
|
||
clang_analyzer_eval(glob_arr9[1][2] == 7); // expected-warning{{TRUE}}
|
||
clang_analyzer_eval(glob_arr9[1][3] == 0); // expected-warning{{TRUE}}
|
||
}
|
||
|
||
enum class E {};
|
||
const E glob[] = {{}};
|
||
void initlistWithinInitlist() {
|
||
// no-crash
|
||
clang_analyzer_dump(glob[0]); // expected-warning-re {{reg_${{[0-9]+}}<enum E Element{glob,0 S64b,enum E}>}}
|
||
}
|