mirror of
https://github.com/llvm/llvm-project.git
synced 2025-04-25 05:26:06 +00:00
3dd5a298bf
Summary: Right now we annotate C++'s `operator new` with `noalias` attribute, which very much is healthy for optimizations. However as per [[ http://eel.is/c++draft/basic.stc.dynamic.allocation | `[basic.stc.dynamic.allocation]` ]], there are more promises on global `operator new`, namely: * non-`std::nothrow_t` `operator new` *never* returns `nullptr` * If `std::align_val_t align` parameter is taken, the pointer will also be `align`-aligned * ~~global `operator new`-returned pointer is `__STDCPP_DEFAULT_NEW_ALIGNMENT__`-aligned ~~ It's more caveated than that. Supplying this information may not cause immediate landslide effects on any specific benchmarks, but it for sure will be healthy for optimizer in the sense that the IR will better reflect the guarantees provided in the source code. The caveat is `-fno-assume-sane-operator-new`, which currently prevents emitting `noalias` attribute, and is automatically passed by Sanitizers ([[ https://bugs.llvm.org/show_bug.cgi?id=16386 | PR16386 ]]) - should it also cover these attributes? The problem is that the flag is back-end-specific, as seen in `test/Modules/explicit-build-flags.cpp`. But while it is okay to add `noalias` metadata in backend, we really should be adding at least the alignment metadata to the AST, since that allows us to perform sema checks on it. Reviewers: erichkeane, rjmccall, jdoerfert, eugenis, rsmith Reviewed By: rsmith Subscribers: xbolva00, jrtc27, atanasyan, nlopes, cfe-commits Tags: #llvm, #clang Differential Revision: https://reviews.llvm.org/D73380
42 lines
1.1 KiB
C++
42 lines
1.1 KiB
C++
// RUN: %clang_analyze_cc1 -std=c++14 \
|
|
// RUN: -analyzer-checker=core,debug.ExprInspection \
|
|
// RUN: -verify %s
|
|
|
|
void clang_analyzer_eval(bool);
|
|
void clang_analyzer_warnIfReached();
|
|
|
|
typedef __typeof__(sizeof(int)) size_t;
|
|
|
|
void *operator new(size_t size) throw() {
|
|
return nullptr;
|
|
// expected-warning@-1 {{null returned from function that requires a non-null return value}}
|
|
}
|
|
void *operator new[](size_t size) throw() {
|
|
return nullptr;
|
|
// expected-warning@-1 {{null returned from function that requires a non-null return value}}
|
|
}
|
|
|
|
struct S {
|
|
int x;
|
|
S() : x(1) {
|
|
// FIXME: Constructor should not be called with null this, even if it was
|
|
// returned by operator new().
|
|
clang_analyzer_warnIfReached(); // expected-warning{{REACHABLE}}
|
|
}
|
|
~S() {}
|
|
};
|
|
|
|
void testArrays() {
|
|
S *s = new S[10]; // no-crash
|
|
s[0].x = 2;
|
|
// no-warning: 'Dereference of null pointer' suppressed by ReturnVisitor.
|
|
}
|
|
|
|
int global;
|
|
void testInvalidationOnConstructionIntoNull() {
|
|
global = 0;
|
|
S *s = new S();
|
|
// FIXME: Should be FALSE - we should not invalidate globals.
|
|
clang_analyzer_eval(global); // expected-warning{{UNKNOWN}}
|
|
}
|