mirror of
https://github.com/llvm/llvm-project.git
synced 2025-04-25 10:36:07 +00:00
8138d85f63
A clang user pointed out that messages for the static analyzer undefined assignment checker use the term ‘garbage’, which might have a negative connotation to some users. This change updates the messages to use the term ‘uninitialized’. This is the usual reason why a value is undefined in the static analyzer and describes the logical error that a programmer should take action to fix. Out-of-bounds reads can also produce undefined values in the static analyzer. The right long-term design is to have to the array bounds checker cover out-of-bounds reads, so we do not cover that case in the updated messages. The recent improvements to the array bounds checker make it a candidate to add to the core set of checkers. rdar://133418644
117 lines
2.2 KiB
C++
117 lines
2.2 KiB
C++
// RUN: %clang_analyze_cc1 -analyzer-checker=core,debug.ExprInspection -std=c++17 -verify %s
|
|
|
|
void clang_analyzer_eval(bool);
|
|
|
|
struct s {
|
|
int a;
|
|
int b;
|
|
};
|
|
|
|
void a(void) {
|
|
s tst;
|
|
|
|
auto [i, j] = tst;
|
|
|
|
int x = i; // expected-warning{{Assigned value is uninitialized}}
|
|
}
|
|
|
|
void b(void) {
|
|
s tst;
|
|
tst.a = 1;
|
|
|
|
auto [i, j] = tst;
|
|
|
|
clang_analyzer_eval(i == 1); // expected-warning{{TRUE}}
|
|
int y = j; // expected-warning{{Assigned value is uninitialized}}
|
|
}
|
|
|
|
void c(void) {
|
|
s tst;
|
|
|
|
auto &[i, j] = tst;
|
|
|
|
int x = i; // expected-warning{{Assigned value is uninitialized}}
|
|
}
|
|
|
|
void d(void) {
|
|
s tst;
|
|
tst.a = 1;
|
|
|
|
auto &[i, j] = tst;
|
|
|
|
clang_analyzer_eval(i == 1); // expected-warning{{TRUE}}
|
|
i = 2;
|
|
clang_analyzer_eval(tst.a == 2); // expected-warning{{TRUE}}
|
|
|
|
int y = j; // expected-warning{{Assigned value is uninitialized}}
|
|
}
|
|
|
|
void e(void) {
|
|
s tst;
|
|
tst.a = 1;
|
|
|
|
auto &[i, j] = tst;
|
|
|
|
clang_analyzer_eval(i == 1); // expected-warning{{TRUE}}
|
|
|
|
tst.b = 2;
|
|
clang_analyzer_eval(j == 2); // expected-warning{{TRUE}}
|
|
}
|
|
|
|
void f(void) {
|
|
s tst;
|
|
|
|
auto &&[i, j] = tst;
|
|
|
|
int x = i; // expected-warning{{Assigned value is uninitialized}}
|
|
}
|
|
|
|
void g(void) {
|
|
s tst;
|
|
tst.a = 1;
|
|
|
|
auto &&[i, j] = tst;
|
|
|
|
clang_analyzer_eval(i == 1); // expected-warning{{TRUE}}
|
|
int y = j; // expected-warning{{Assigned value is uninitialized}}
|
|
}
|
|
|
|
struct s2 {
|
|
int a = 1;
|
|
int b = 2;
|
|
};
|
|
|
|
struct s3 {
|
|
s x;
|
|
s2 y;
|
|
};
|
|
|
|
void h(void) {
|
|
s3 tst;
|
|
|
|
clang_analyzer_eval(tst.y.a == 1); // expected-warning{{TRUE}}
|
|
|
|
auto [i, j] = tst;
|
|
|
|
// FIXME: These should be undefined, but we have to fix
|
|
// reading undefined from lazy compound values first.
|
|
clang_analyzer_eval(i.a); // expected-warning{{UNKNOWN}}
|
|
clang_analyzer_eval(i.b); // expected-warning{{UNKNOWN}}
|
|
|
|
clang_analyzer_eval(j.a == 1); // expected-warning{{TRUE}}
|
|
clang_analyzer_eval(j.b == 2); // expected-warning{{TRUE}}
|
|
}
|
|
|
|
void i(void) {
|
|
s3 tst;
|
|
|
|
clang_analyzer_eval(tst.y.a == 1); // expected-warning{{TRUE}}
|
|
|
|
auto &[i, j] = tst;
|
|
j.a = 3;
|
|
|
|
clang_analyzer_eval(tst.y.a == 3); // expected-warning{{TRUE}}
|
|
clang_analyzer_eval(tst.y.b == 2); // expected-warning{{TRUE}}
|
|
clang_analyzer_eval(j.b == 2); // expected-warning{{TRUE}}
|
|
}
|