mirror of
https://github.com/llvm/llvm-project.git
synced 2025-04-17 03:36:37 +00:00
90828d67ea
There are some very odd (even for Fortran) rules in F'2023 subclause 19.4 (paras 6 & 8) pertaining to the index variables of FORALL and DO CONCURRENT constructs/statements, and they are not currently implemented correctly. Although these index variables are construct entities, they have restrictions in the standard that would essentially allow them to also be variables in their enclosing scopes. If their names are present in the enclosing scope, and the construct does not have an explicit type specification for its indices, then the names in the enclosing scope must either be scalar variables or COMMON blocks, and their type must be integer. Reimplement these restrictions largely with portability warnings rather than hard errors. Retain the semantic interpretation that the type of an untyped index variable be taken from the type of a variable of the same name in the enclosing scope, if it exists, although that bit of the standard could be interpreted otherwise. Fixes https://github.com/llvm/llvm-project/issues/76978.
148 lines
4.1 KiB
Fortran
148 lines
4.1 KiB
Fortran
! RUN: %python %S/test_errors.py %s %flang_fc1 -pedantic
|
|
! Construct names
|
|
|
|
subroutine s1
|
|
real :: foo
|
|
!ERROR: 'foo' is already declared in this scoping unit
|
|
foo: block
|
|
end block foo
|
|
end
|
|
|
|
subroutine s2(x)
|
|
logical :: x
|
|
foo: if (x) then
|
|
end if foo
|
|
!ERROR: 'foo' is already declared in this scoping unit
|
|
foo: do i = 1, 10
|
|
end do foo
|
|
end
|
|
|
|
subroutine s3
|
|
real :: a(10,10), b(10,10)
|
|
type y; end type
|
|
integer(8) :: x
|
|
!PORTABILITY: Index variable 'y' should be a scalar object or common block if it is present in the enclosing scope
|
|
!ERROR: Must have INTEGER type, but is REAL(4)
|
|
forall(x=1:10, y=1:10)
|
|
!ERROR: Must have INTEGER type, but is REAL(4)
|
|
!ERROR: Must have INTEGER type, but is REAL(4)
|
|
a(x, y) = b(x, y)
|
|
end forall
|
|
!PORTABILITY: Index variable 'y' should be a scalar object or common block if it is present in the enclosing scope
|
|
!ERROR: Must have INTEGER type, but is REAL(4)
|
|
!ERROR: Must have INTEGER type, but is REAL(4)
|
|
!ERROR: Must have INTEGER type, but is REAL(4)
|
|
forall(x=1:10, y=1:10) a(x, y) = b(x, y)
|
|
end
|
|
|
|
subroutine s4
|
|
real :: a(10), b(10)
|
|
complex :: x
|
|
integer :: i(2)
|
|
!ERROR: Must have INTEGER type, but is COMPLEX(4)
|
|
forall(x=1:10)
|
|
!ERROR: Must have INTEGER type, but is COMPLEX(4)
|
|
!ERROR: Must have INTEGER type, but is COMPLEX(4)
|
|
a(x) = b(x)
|
|
end forall
|
|
!ERROR: Must have INTEGER type, but is REAL(4)
|
|
forall(y=1:10)
|
|
!ERROR: Must have INTEGER type, but is REAL(4)
|
|
!ERROR: Must have INTEGER type, but is REAL(4)
|
|
a(y) = b(y)
|
|
end forall
|
|
!PORTABILITY: Index variable 'i' should be scalar in the enclosing scope
|
|
forall(i=1:10)
|
|
a(i) = b(i)
|
|
end forall
|
|
end
|
|
|
|
subroutine s6
|
|
integer, parameter :: n = 4
|
|
real, dimension(n) :: x
|
|
data(x(i), i=1, n) / n * 0.0 /
|
|
!PORTABILITY: Index variable 't' should be a scalar object or common block if it is present in the enclosing scope
|
|
!ERROR: Must have INTEGER type, but is REAL(4)
|
|
!ERROR: Must have INTEGER type, but is REAL(4)
|
|
forall(t=1:n) x(t) = 0.0
|
|
contains
|
|
subroutine t
|
|
end
|
|
end
|
|
|
|
subroutine s6b
|
|
integer, parameter :: k = 4
|
|
integer :: l = 4
|
|
forall(integer(k) :: i = 1:10)
|
|
end forall
|
|
! C713 A scalar-int-constant-name shall be a named constant of type integer.
|
|
!ERROR: Must be a constant value
|
|
forall(integer(l) :: i = 1:10)
|
|
end forall
|
|
end
|
|
|
|
subroutine s7
|
|
!ERROR: 'i' is already declared in this scoping unit
|
|
do concurrent(integer::i=1:5) local(j, i) &
|
|
!ERROR: 'j' is already declared in this scoping unit
|
|
local_init(k, j) &
|
|
!WARNING: Variable 'a' with SHARED locality implicitly declared
|
|
shared(a)
|
|
a = j + 1
|
|
end do
|
|
end
|
|
|
|
subroutine s8
|
|
implicit none
|
|
!ERROR: No explicit type declared for 'i'
|
|
do concurrent(i=1:5) &
|
|
!ERROR: No explicit type declared for 'j'
|
|
local(j) &
|
|
!ERROR: No explicit type declared for 'k'
|
|
local_init(k)
|
|
end do
|
|
end
|
|
|
|
subroutine s9
|
|
integer :: j
|
|
!ERROR: 'i' is already declared in this scoping unit
|
|
do concurrent(integer::i=1:5) shared(i) &
|
|
shared(j) &
|
|
!ERROR: 'j' is already declared in this scoping unit
|
|
shared(j)
|
|
end do
|
|
end
|
|
|
|
subroutine s10
|
|
external bad1
|
|
real, parameter :: bad2 = 1.0
|
|
x = cos(0.)
|
|
do concurrent(i=1:2) &
|
|
!ERROR: 'bad1' may not appear in a locality-spec because it is not definable
|
|
!BECAUSE: 'bad1' is not a variable
|
|
local(bad1) &
|
|
!ERROR: 'bad2' may not appear in a locality-spec because it is not definable
|
|
!BECAUSE: 'bad2' is not a variable
|
|
local(bad2) &
|
|
!ERROR: 'bad3' may not appear in a locality-spec because it is not definable
|
|
!BECAUSE: 'bad3' is not a variable
|
|
local(bad3) &
|
|
!ERROR: 'cos' may not appear in a locality-spec because it is not definable
|
|
!BECAUSE: 'cos' is not a variable
|
|
local(cos)
|
|
end do
|
|
do concurrent(i=1:2) &
|
|
!ERROR: The name 'bad1' must be a variable to appear in a locality-spec
|
|
shared(bad1) &
|
|
!ERROR: The name 'bad2' must be a variable to appear in a locality-spec
|
|
shared(bad2) &
|
|
!ERROR: The name 'bad3' must be a variable to appear in a locality-spec
|
|
shared(bad3) &
|
|
!ERROR: The name 'cos' must be a variable to appear in a locality-spec
|
|
shared(cos)
|
|
end do
|
|
contains
|
|
subroutine bad3
|
|
end
|
|
end
|