mirrors/llvm-project
0
0
Fork 0
mirror of https://github.com/llvm/llvm-project.git synced 2025-05-18 19:46:05 +00:00
Code Issues Projects Releases Wiki Activity
llvm-project/llvm/lib/Support
History
Roman Lebedev 29d05c005f [CodeGen] [SelectionDAG] More efficient code for X % C == 0 (UREM case) (try 3) 
Summary:
I'm submitting a new revision since i don't understand how to reclaim/reopen/take over the existing one, D50222.
There is no such action in "Add Action" menu...

This implements an optimization described in Hacker's Delight 10-17: when `C` is constant,
the result of `X % C == 0` can be computed more cheaply without actually calculating the remainder.
The motivation is discussed here: https://bugs.llvm.org/show_bug.cgi?id=35479.

This is a recommit, the original commit rL364563 was reverted in rL364568
because test-suite detected miscompile - the new comparison constant 'Q'
was being computed incorrectly (we divided by `D0` instead of `D`).

Original patch D50222 by @hermord (Dmytro Shynkevych)

Notes:
- In principle, it's possible to also handle the `X % C1 == C2` case, as discussed on bugzilla.
  This seems to require an extra branch on overflow, so I refrained from implementing this for now.
- An explicit check for when the `REM` can be reduced to just its LHS is included:
  the `X % C` == 0 optimization breaks `test1` in `test/CodeGen/X86/jump_sign.ll` otherwise.
  I hadn't managed to find a better way to not generate worse output in this case.
- The `test/CodeGen/X86/jump_sign.ll` regresses, and is being fixed by a followup patch D63390.

Reviewers: RKSimon, craig.topper, spatel, hermord, xbolva00

Reviewed By: RKSimon, xbolva00

Subscribers: dexonsmith, kristina, xbolva00, javed.absar, llvm-commits, hermord

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D63391

llvm-svn: 364600
2019-06-27 21:52:10 +00:00
..
Unix
[Support] Fix build under Emscripten
2019-06-23 00:29:59 +00:00
Windows
[Support] Renamed member 'Size' to 'AllocatedSize' in MemoryBlock and OwningMemoryBlock.
2019-05-20 20:53:05 +00:00
AArch64TargetParser.cpp
[AArch64][SVE2] Add SVE2 target features to backend and TargetParser
2019-05-13 10:10:24 +00:00
Allocator.cpp
Update the file headers across all of the LLVM projects in the monorepo
2019-01-19 08:50:56 +00:00
AMDGPUMetadata.cpp
[AMDGPU] Factored PAL metadata handling out into its own class
2019-03-20 17:42:00 +00:00
APFloat.cpp
[clang] Add storage for APValue in ConstantExpr
2019-06-15 10:24:47 +00:00
APInt.cpp
[CodeGen] [SelectionDAG] More efficient code for X % C == 0 (UREM case) (try 3)
2019-06-27 21:52:10 +00:00
APSInt.cpp
Update the file headers across all of the LLVM projects in the monorepo
2019-01-19 08:50:56 +00:00
ARMAttributeParser.cpp
Fix failing test on ARM buildbot
2019-06-14 13:45:21 +00:00
ARMBuildAttrs.cpp
[ARM] add target arch definitions for 8.1-M and MVE
2019-05-30 12:57:04 +00:00
ARMTargetParser.cpp
[ARM] Fix bugs introduced by the fp64/d32 rework.
2019-06-07 12:42:54 +00:00
ARMWinEH.cpp
Update the file headers across all of the LLVM projects in the monorepo
2019-01-19 08:50:56 +00:00
Atomic.cpp
Update the file headers across all of the LLVM projects in the monorepo
2019-01-19 08:50:56 +00:00
BinaryStreamError.cpp
Update the file headers across all of the LLVM projects in the monorepo
2019-01-19 08:50:56 +00:00
BinaryStreamReader.cpp
[Support] Add LEB128 support to BinaryStreamReader/Writer.
2019-04-17 15:38:27 +00:00
BinaryStreamRef.cpp
Update the file headers across all of the LLVM projects in the monorepo
2019-01-19 08:50:56 +00:00
BinaryStreamWriter.cpp
[Support] Add LEB128 support to BinaryStreamReader/Writer.
2019-04-17 15:38:27 +00:00
BlockFrequency.cpp
Update the file headers across all of the LLVM projects in the monorepo
2019-01-19 08:50:56 +00:00
BranchProbability.cpp
[BranchProbability] Delete a redundant overflow check
2019-06-15 10:09:59 +00:00
BuryPointer.cpp
Update the file headers across all of the LLVM projects in the monorepo
2019-01-19 08:50:56 +00:00
CachePruning.cpp
[CachePruning] Simplify comparator
2019-04-21 06:17:40 +00:00
Chrono.cpp
Update the file headers across all of the LLVM projects in the monorepo
2019-01-19 08:50:56 +00:00
circular_raw_ostream.cpp
Update the file headers across all of the LLVM projects in the monorepo
2019-01-19 08:50:56 +00:00
CMakeLists.txt
Attempt to recommit r357901
2019-04-08 12:31:12 +00:00
CodeGenCoverage.cpp
Update the file headers across all of the LLVM projects in the monorepo
2019-01-19 08:50:56 +00:00
COM.cpp
Update the file headers across all of the LLVM projects in the monorepo
2019-01-19 08:50:56 +00:00
CommandLine.cpp
Revert [CommandLine] Remove OptionCategory and SubCommand caches from the Option class.
2019-06-22 23:32:36 +00:00
Compression.cpp
Update the file headers across all of the LLVM projects in the monorepo
2019-01-19 08:50:56 +00:00
ConvertUTF.cpp
Update the file headers across all of the LLVM projects in the monorepo
2019-01-19 08:50:56 +00:00
ConvertUTFWrapper.cpp
Update the file headers across all of the LLVM projects in the monorepo
2019-01-19 08:50:56 +00:00
COPYRIGHT.regex
…
CrashRecoveryContext.cpp
Update the file headers across all of the LLVM projects in the monorepo
2019-01-19 08:50:56 +00:00
CRC.cpp
Attempt to recommit r357901
2019-04-08 12:31:12 +00:00
DAGDeltaAlgorithm.cpp
Update the file headers across all of the LLVM projects in the monorepo
2019-01-19 08:50:56 +00:00
DataExtractor.cpp
DataExtractor: use decodeSLEB128 to implement getSLEB128
2019-06-24 23:45:18 +00:00
Debug.cpp
Update the file headers across all of the LLVM projects in the monorepo
2019-01-19 08:50:56 +00:00
DebugCounter.cpp
Print out DebugCounter info with -print-debug-counter
2018-10-23 21:51:56 +00:00
DeltaAlgorithm.cpp
Update the file headers across all of the LLVM projects in the monorepo
2019-01-19 08:50:56 +00:00
DJB.cpp
[DJB] Fix variable case after D61178
2019-04-27 15:33:22 +00:00
DynamicLibrary.cpp
Update the file headers across all of the LLVM projects in the monorepo
2019-01-19 08:50:56 +00:00
Errno.cpp
Update the file headers across all of the LLVM projects in the monorepo
2019-01-19 08:50:56 +00:00
Error.cpp
Update the file headers across all of the LLVM projects in the monorepo
2019-01-19 08:50:56 +00:00
ErrorHandling.cpp
Update the file headers across all of the LLVM projects in the monorepo
2019-01-19 08:50:56 +00:00
FileCheck.cpp
[FileCheck] Stop qualifying expressions as numeric
2019-06-19 23:47:24 +00:00
FileOutputBuffer.cpp
[Support] Renamed member 'Size' to 'AllocatedSize' in MemoryBlock and OwningMemoryBlock.
2019-05-20 20:53:05 +00:00
FileUtilities.cpp
Update the file headers across all of the LLVM projects in the monorepo
2019-01-19 08:50:56 +00:00
FoldingSet.cpp
Update the file headers across all of the LLVM projects in the monorepo
2019-01-19 08:50:56 +00:00
FormattedStream.cpp
Update the file headers across all of the LLVM projects in the monorepo
2019-01-19 08:50:56 +00:00
FormatVariadic.cpp
Update the file headers across all of the LLVM projects in the monorepo
2019-01-19 08:50:56 +00:00
GlobPattern.cpp
Update the file headers across all of the LLVM projects in the monorepo
2019-01-19 08:50:56 +00:00
GraphWriter.cpp
Update the file headers across all of the LLVM projects in the monorepo
2019-01-19 08:50:56 +00:00
Hashing.cpp
Update the file headers across all of the LLVM projects in the monorepo
2019-01-19 08:50:56 +00:00
Host.cpp
[AArch64] Add more CPUs to host detection
2019-06-11 00:05:36 +00:00
InitLLVM.cpp
Update the file headers across all of the LLVM projects in the monorepo
2019-01-19 08:50:56 +00:00
IntEqClasses.cpp
Update the file headers across all of the LLVM projects in the monorepo
2019-01-19 08:50:56 +00:00
IntervalMap.cpp
Update the file headers across all of the LLVM projects in the monorepo
2019-01-19 08:50:56 +00:00
ItaniumManglingCanonicalizer.cpp
Update more file headers across all of the LLVM projects in the monorepo
2019-01-19 10:56:40 +00:00
JamCRC.cpp
Update the file headers across all of the LLVM projects in the monorepo
2019-01-19 08:50:56 +00:00
JSON.cpp
[Support] Add JSON streaming output API, faster where the heavy value types aren't needed.
2019-04-25 12:51:42 +00:00
KnownBits.cpp
[KnownBits] Add computeForAddCarry()
2019-04-12 18:18:08 +00:00
LEB128.cpp
Update the file headers across all of the LLVM projects in the monorepo
2019-01-19 08:50:56 +00:00
LineIterator.cpp
Update the file headers across all of the LLVM projects in the monorepo
2019-01-19 08:50:56 +00:00
LLVMBuild.txt
Update the file headers across all of the LLVM projects in the monorepo
2019-01-19 08:50:56 +00:00
Locale.cpp
[Windows] Convert from UTF-8 to UTF-16 when writing to a Windows console
2018-09-05 00:08:56 +00:00
LockFileManager.cpp
Update the file headers across all of the LLVM projects in the monorepo
2019-01-19 08:50:56 +00:00
LowLevelType.cpp
Update the file headers across all of the LLVM projects in the monorepo
2019-01-19 08:50:56 +00:00
ManagedStatic.cpp
Update the file headers across all of the LLVM projects in the monorepo
2019-01-19 08:50:56 +00:00
MathExtras.cpp
Update the file headers across all of the LLVM projects in the monorepo
2019-01-19 08:50:56 +00:00
MD5.cpp
Remove \brief commands from doxygen comments.
2018-05-01 15:54:18 +00:00
Memory.cpp
[Support] Renamed member 'Size' to 'AllocatedSize' in MemoryBlock and OwningMemoryBlock.
2019-05-20 20:53:05 +00:00
MemoryBuffer.cpp
[Support] Add error handling to sys::Process::getPageSize().
2019-05-08 02:11:07 +00:00
Mutex.cpp
Update the file headers across all of the LLVM projects in the monorepo
2019-01-19 08:50:56 +00:00
NativeFormatting.cpp
Update the file headers across all of the LLVM projects in the monorepo
2019-01-19 08:50:56 +00:00
Optional.cpp
Update the file headers across all of the LLVM projects in the monorepo
2019-01-19 08:50:56 +00:00
Options.cpp
Update the file headers across all of the LLVM projects in the monorepo
2019-01-19 08:50:56 +00:00
Parallel.cpp
Parallel: only allow the first TaskGroup to run tasks parallelly
2019-04-25 11:33:30 +00:00
Path.cpp
[Path] Set FD to -1 in moved-from TempFile
2019-06-11 16:42:42 +00:00
PluginLoader.cpp
Update the file headers across all of the LLVM projects in the monorepo
2019-01-19 08:50:56 +00:00
PrettyStackTrace.cpp
Support: enable backtraces on Windows
2019-02-27 03:21:50 +00:00
Process.cpp
Update the file headers across all of the LLVM projects in the monorepo
2019-01-19 08:50:56 +00:00
Program.cpp
Update the file headers across all of the LLVM projects in the monorepo
2019-01-19 08:50:56 +00:00
RandomNumberGenerator.cpp
[CommandLine] Provide parser<unsigned long> instantiation to allow cl::opt<uint64_t> on LP64 platforms
2019-04-24 02:40:20 +00:00
raw_os_ostream.cpp
Update the file headers across all of the LLVM projects in the monorepo
2019-01-19 08:50:56 +00:00
raw_ostream.cpp
Update the file headers across all of the LLVM projects in the monorepo
2019-01-19 08:50:56 +00:00
regcomp.c
Attempt to heal bots after r328970.
2018-04-02 13:49:35 +00:00
regengine.inc
[ADT] Replace std::isprint by llvm::isPrint.
2018-07-26 15:31:41 +00:00
regerror.c
…
regex2.h
…
regex_impl.h
Remove trailing space
2018-07-30 19:41:25 +00:00
Regex.cpp
Update the file headers across all of the LLVM projects in the monorepo
2019-01-19 08:50:56 +00:00
regexec.c
…
regfree.c
…
regstrlcpy.c
…
regutils.h
…
RWMutex.cpp
Update the file headers across all of the LLVM projects in the monorepo
2019-01-19 08:50:56 +00:00
ScaledNumber.cpp
Update the file headers across all of the LLVM projects in the monorepo
2019-01-19 08:50:56 +00:00
ScopedPrinter.cpp
…
SHA1.cpp
Update the file headers across all of the LLVM projects in the monorepo
2019-01-19 08:50:56 +00:00
Signals.cpp
Only use argv[0] as the main executable name if it exists.
2019-04-15 22:07:56 +00:00
Signposts.cpp
Annotate timeline in Instruments with passes and other timed regions.
2019-02-19 18:18:31 +00:00
SmallPtrSet.cpp
Update the file headers across all of the LLVM projects in the monorepo
2019-01-19 08:50:56 +00:00
SmallVector.cpp
Update the file headers across all of the LLVM projects in the monorepo
2019-01-19 08:50:56 +00:00
SourceMgr.cpp
Simplify std::lower_bound with llvm::{bsearch,lower_bound}. NFC
2019-06-21 05:40:31 +00:00
SpecialCaseList.cpp
Update the file headers across all of the LLVM projects in the monorepo
2019-01-19 08:50:56 +00:00
Statistic.cpp
Use llvm::stable_sort
2019-04-23 14:51:27 +00:00
StringExtras.cpp
Update the file headers across all of the LLVM projects in the monorepo
2019-01-19 08:50:56 +00:00
StringMap.cpp
Update the file headers across all of the LLVM projects in the monorepo
2019-01-19 08:50:56 +00:00
StringPool.cpp
Update the file headers across all of the LLVM projects in the monorepo
2019-01-19 08:50:56 +00:00
StringRef.cpp
Update the file headers across all of the LLVM projects in the monorepo
2019-01-19 08:50:56 +00:00
StringSaver.cpp
Update the file headers across all of the LLVM projects in the monorepo
2019-01-19 08:50:56 +00:00
SymbolRemappingReader.cpp
Update the file headers across all of the LLVM projects in the monorepo
2019-01-19 08:50:56 +00:00
SystemUtils.cpp
Update the file headers across all of the LLVM projects in the monorepo
2019-01-19 08:50:56 +00:00
TargetParser.cpp
[AMDGPU] gfx1011/gfx1012 targets
2019-06-14 00:33:31 +00:00
TargetRegistry.cpp
Update the file headers across all of the LLVM projects in the monorepo
2019-01-19 08:50:56 +00:00
TarWriter.cpp
Update the file headers across all of the LLVM projects in the monorepo
2019-01-19 08:50:56 +00:00
Threading.cpp
Update the file headers across all of the LLVM projects in the monorepo
2019-01-19 08:50:56 +00:00
ThreadLocal.cpp
Update the file headers across all of the LLVM projects in the monorepo
2019-01-19 08:50:56 +00:00
ThreadPool.cpp
Update the file headers across all of the LLVM projects in the monorepo
2019-01-19 08:50:56 +00:00
TimeProfiler.cpp
[Support] Add JSON streaming output API, faster where the heavy value types aren't needed.
2019-04-25 12:51:42 +00:00
Timer.cpp
[Legacy][TimePasses] allow -time-passes reporting into a custom stream
2019-03-22 23:11:08 +00:00
ToolOutputFile.cpp
Update the file headers across all of the LLVM projects in the monorepo
2019-01-19 08:50:56 +00:00
TrigramIndex.cpp
Update the file headers across all of the LLVM projects in the monorepo
2019-01-19 08:50:56 +00:00
Triple.cpp
[ARM] add target arch definitions for 8.1-M and MVE
2019-05-30 12:57:04 +00:00
Twine.cpp
Update the file headers across all of the LLVM projects in the monorepo
2019-01-19 08:50:56 +00:00
Unicode.cpp
Update the file headers across all of the LLVM projects in the monorepo
2019-01-19 08:50:56 +00:00
UnicodeCaseFold.cpp
…
Valgrind.cpp
Update the file headers across all of the LLVM projects in the monorepo
2019-01-19 08:50:56 +00:00
VersionTuple.cpp
Update the file headers across all of the LLVM projects in the monorepo
2019-01-19 08:50:56 +00:00
VirtualFileSystem.cpp
[VirtualFileSystem] Fix uninitialized variable warning. NFCI.
2019-05-22 11:20:52 +00:00
Watchdog.cpp
Update the file headers across all of the LLVM projects in the monorepo
2019-01-19 08:50:56 +00:00
WithColor.cpp
Update the file headers across all of the LLVM projects in the monorepo
2019-01-19 08:50:56 +00:00
xxhash.cpp
Make ICF log output order deterministic.
2018-07-31 18:04:58 +00:00
YAMLParser.cpp
Update the file headers across all of the LLVM projects in the monorepo
2019-01-19 08:50:56 +00:00
YAMLTraits.cpp
[yaml2obj] - Don't crash on invalid inputs.
2019-04-25 09:59:55 +00:00
Z3Solver.cpp
New methods to check for under-/overflow in the SMT API
2019-03-27 16:54:12 +00:00