mirror of
https://github.com/llvm/llvm-project.git
synced 2025-04-28 16:56:09 +00:00
3dc1669133
Currently, if clang::isBetterOverloadCandidate encounters an enable_if
attribute on either candidate that it's inspecting, it will ignore all
lower priority attributes (e.g. pass_object_size). This is problematic
in cases like:
```
void foo(char *c) __attribute__((enable_if(1, "")));
void foo(char *c __attribute__((pass_object_size(0))))
__attribute__((enable_if(1, "")));
```
...Because we would ignore the pass_object_size attribute in the second
`foo`, and consider any call to `foo` to be ambiguous.
This patch makes overload resolution consult further tiebreakers (e.g.
pass_object_size) if two candidates have equally good enable_if
attributes.
llvm-svn: 269005
96 lines
3.4 KiB
C
96 lines
3.4 KiB
C
// RUN: %clang_cc1 -emit-llvm %s -o - -triple=x86_64-pc-linux-gnu | FileCheck %s
|
|
|
|
// Verifying that we do, in fact, select the correct function in the following
|
|
// cases.
|
|
|
|
void foo(int m) __attribute__((overloadable, enable_if(m > 0, "")));
|
|
void foo(int m) __attribute__((overloadable));
|
|
|
|
// CHECK-LABEL: define void @test1
|
|
void test1() {
|
|
// CHECK: store void (i32)* @_Z3fooi
|
|
void (*p)(int) = foo;
|
|
// CHECK: store void (i32)* @_Z3fooi
|
|
void (*p2)(int) = &foo;
|
|
// CHECK: store void (i32)* @_Z3fooi
|
|
p = foo;
|
|
// CHECK: store void (i32)* @_Z3fooi
|
|
p = &foo;
|
|
|
|
// CHECK: store i8* bitcast (void (i32)* @_Z3fooi to i8*)
|
|
void *vp1 = (void*)&foo;
|
|
// CHECK: store i8* bitcast (void (i32)* @_Z3fooi to i8*)
|
|
void *vp2 = (void*)foo;
|
|
// CHECK: store i8* bitcast (void (i32)* @_Z3fooi to i8*)
|
|
vp1 = (void*)&foo;
|
|
// CHECK: store i8* bitcast (void (i32)* @_Z3fooi to i8*)
|
|
vp1 = (void*)foo;
|
|
}
|
|
|
|
void bar(int m) __attribute__((overloadable, enable_if(m > 0, "")));
|
|
void bar(int m) __attribute__((overloadable, enable_if(1, "")));
|
|
// CHECK-LABEL: define void @test2
|
|
void test2() {
|
|
// CHECK: store void (i32)* @_Z3barUa9enable_ifIXLi1EEEi
|
|
void (*p)(int) = bar;
|
|
// CHECK: store void (i32)* @_Z3barUa9enable_ifIXLi1EEEi
|
|
void (*p2)(int) = &bar;
|
|
// CHECK: store void (i32)* @_Z3barUa9enable_ifIXLi1EEEi
|
|
p = bar;
|
|
// CHECK: store void (i32)* @_Z3barUa9enable_ifIXLi1EEEi
|
|
p = &bar;
|
|
|
|
// CHECK: store i8* bitcast (void (i32)* @_Z3barUa9enable_ifIXLi1EEEi to i8*)
|
|
void *vp1 = (void*)&bar;
|
|
// CHECK: store i8* bitcast (void (i32)* @_Z3barUa9enable_ifIXLi1EEEi to i8*)
|
|
void *vp2 = (void*)bar;
|
|
// CHECK: store i8* bitcast (void (i32)* @_Z3barUa9enable_ifIXLi1EEEi to i8*)
|
|
vp1 = (void*)&bar;
|
|
// CHECK: store i8* bitcast (void (i32)* @_Z3barUa9enable_ifIXLi1EEEi to i8*)
|
|
vp1 = (void*)bar;
|
|
}
|
|
|
|
void baz(int m) __attribute__((overloadable, enable_if(1, "")));
|
|
void baz(int m) __attribute__((overloadable));
|
|
// CHECK-LABEL: define void @test3
|
|
void test3() {
|
|
// CHECK: store void (i32)* @_Z3bazUa9enable_ifIXLi1EEEi
|
|
void (*p)(int) = baz;
|
|
// CHECK: store void (i32)* @_Z3bazUa9enable_ifIXLi1EEEi
|
|
void (*p2)(int) = &baz;
|
|
// CHECK: store void (i32)* @_Z3bazUa9enable_ifIXLi1EEEi
|
|
p = baz;
|
|
// CHECK: store void (i32)* @_Z3bazUa9enable_ifIXLi1EEEi
|
|
p = &baz;
|
|
}
|
|
|
|
|
|
const int TRUEFACTS = 1;
|
|
void qux(int m) __attribute__((overloadable, enable_if(1, ""),
|
|
enable_if(TRUEFACTS, "")));
|
|
void qux(int m) __attribute__((overloadable, enable_if(1, "")));
|
|
// CHECK-LABEL: define void @test4
|
|
void test4() {
|
|
// CHECK: store void (i32)* @_Z3quxUa9enable_ifIXLi1EEXL_Z9TRUEFACTSEEEi
|
|
void (*p)(int) = qux;
|
|
// CHECK: store void (i32)* @_Z3quxUa9enable_ifIXLi1EEXL_Z9TRUEFACTSEEEi
|
|
void (*p2)(int) = &qux;
|
|
// CHECK: store void (i32)* @_Z3quxUa9enable_ifIXLi1EEXL_Z9TRUEFACTSEEEi
|
|
p = qux;
|
|
// CHECK: store void (i32)* @_Z3quxUa9enable_ifIXLi1EEXL_Z9TRUEFACTSEEEi
|
|
p = &qux;
|
|
}
|
|
|
|
// There was a bug where, when enable_if was present, overload resolution
|
|
// wouldn't pay attention to lower-priority attributes.
|
|
// (N.B. `foo` with pass_object_size should always be preferred)
|
|
// CHECK-LABEL: define void @test5
|
|
void test5() {
|
|
int foo(char *i) __attribute__((enable_if(1, ""), overloadable));
|
|
int foo(char *i __attribute__((pass_object_size(0))))
|
|
__attribute__((enable_if(1, ""), overloadable));
|
|
|
|
// CHECK: call i32 @_Z3fooUa9enable_ifIXLi1EEEPcU17pass_object_size0
|
|
foo((void*)0);
|
|
}
|