mirror of
https://github.com/llvm/llvm-project.git
synced 2025-04-29 03:26:06 +00:00
17ebdb239f
When a function taking transparent union is declared as taking one of union members earlier in the translation unit, clang would hit an "Invalid cast" assertion during EmitFunctionProlog. This case corresponds to function f1 in test/CodeGen/transparent-union-redecl.c. We decided to cast i32 to union because after merging function declarations function parameter type becomes int, CGFunctionInfo::ArgInfo type matches with ABIArgInfo type, so we decide it is a trivial case. But these types should also be castable to parameter declaration type which is not the case here. Now the fix is in converting from ABIArgInfo type to VarDecl type and using argument demotion when necessary. Additional tests in Sema/transparent-union.c capture current behavior and make sure there are no regressions. rdar://problem/34949329 Reviewers: rjmccall, rafael Reviewed By: rjmccall Subscribers: aemerson, cfe-commits, kristof.beyls, ahatanak Differential Revision: https://reviews.llvm.org/D41311 llvm-svn: 323156
45 lines
1.5 KiB
C
45 lines
1.5 KiB
C
// RUN: %clang_cc1 -Werror -triple i386-linux -emit-llvm -o - %s | FileCheck %s
|
|
|
|
// Test that different order of declarations is acceptable and that
|
|
// implementing different redeclarations is acceptable.
|
|
// rdar://problem/34949329
|
|
|
|
typedef union {
|
|
int i;
|
|
float f;
|
|
} TU __attribute__((transparent_union));
|
|
|
|
// CHECK-LABEL: define void @f0(i32 %tu.coerce)
|
|
// CHECK: %tu = alloca %union.TU, align 4
|
|
// CHECK: %coerce.dive = getelementptr inbounds %union.TU, %union.TU* %tu, i32 0, i32 0
|
|
// CHECK: store i32 %tu.coerce, i32* %coerce.dive, align 4
|
|
void f0(TU tu) {}
|
|
void f0(int i);
|
|
|
|
// CHECK-LABEL: define void @f1(i32 %tu.coerce)
|
|
// CHECK: %tu = alloca %union.TU, align 4
|
|
// CHECK: %coerce.dive = getelementptr inbounds %union.TU, %union.TU* %tu, i32 0, i32 0
|
|
// CHECK: store i32 %tu.coerce, i32* %coerce.dive, align 4
|
|
void f1(int i);
|
|
void f1(TU tu) {}
|
|
|
|
// CHECK-LABEL: define void @f2(i32 %i)
|
|
// CHECK: %i.addr = alloca i32, align 4
|
|
// CHECK: store i32 %i, i32* %i.addr, align 4
|
|
void f2(TU tu);
|
|
void f2(int i) {}
|
|
|
|
// CHECK-LABEL: define void @f3(i32 %i)
|
|
// CHECK: %i.addr = alloca i32, align 4
|
|
// CHECK: store i32 %i, i32* %i.addr, align 4
|
|
void f3(int i) {}
|
|
void f3(TU tu);
|
|
|
|
// Also test functions with parameters specified K&R style.
|
|
// CHECK-LABEL: define void @knrStyle(i32 %tu.coerce)
|
|
// CHECK: %tu = alloca %union.TU, align 4
|
|
// CHECK: %coerce.dive = getelementptr inbounds %union.TU, %union.TU* %tu, i32 0, i32 0
|
|
// CHECK: store i32 %tu.coerce, i32* %coerce.dive, align 4
|
|
void knrStyle(int i);
|
|
void knrStyle(tu) TU tu; {}
|