mirror of
https://github.com/llvm/llvm-project.git
synced 2025-04-28 14:56:07 +00:00
12f78e740c
In preparation of making `-Wreturn-type` default to an error (as there
is virtually no situation where you’d *want* to fall off the end of a
function that is supposed to return a value), this patch fixes tests
that have relied on this being only a warning, of which there seem
to be 3 kinds:
1. Tests which for no apparent reason have a function that triggers the
warning.
I suspect that a lot of these were on accident (or from before the
warning was introduced), since a lot of people will open issues w/ their
problematic code in the `main` function (which is the one case where you
don’t need to return from a non-void function, after all...), which
someone will then copy, possibly into a namespace, possibly renaming it,
the end result of that being that you end up w/ something that
definitely is not `main` anymore, but which still is declared as
returning `int`, and which still has no return statement (another reason
why I think this might apply to a lot of these is because usually the
actual return type of such problematic functions is quite literally
`int`).
A lot of these are really old tests that don’t use `-verify`, which is
why no-one noticed or had to care about the extra warning that was
already being emitted by them until now.
2. Tests which test either `-Wreturn-type`, `[[noreturn]]`, or what
codegen and sanitisers do whenever you do fall off the end of a
function.
3. Tests where I struggle to figure out what is even being tested
(usually because they’re Objective-C tests, and I don’t know
Objective-C), whether falling off the end of a function matters in the
first place, and tests where actually spelling out an expression to
return would be rather cumbersome (e.g. matrix types currently don’t
support list initialisation, so I can’t write e.g. `return {}`).
For tests that fall into categories 2 and 3, I just added
`-Wno-error=return-type` to the `RUN` lines and called it a day. This
was especially necessary for the former since `-Wreturn-type` is an
analysis-based warning, meaning that it is currently impossible to test
for more than one occurrence of it in the same compilation if it
defaults to an error since the analysis pass is skipped for subsequent
functions as soon as an error is emitted.
I’ve also added `-Werror=return-type` to a few tests that I had already
updated as this patch was previously already making the warning an error
by default, but we’ve decided to split that into two patches instead.
56 lines
1.6 KiB
Objective-C
56 lines
1.6 KiB
Objective-C
// RUN: %clang_cc1 -emit-llvm -triple i686-apple-darwin8 -fobjc-runtime=macosx-fragile-10.5 -o %t %s
|
|
|
|
// No object generated
|
|
// RUN: not grep OBJC_PROTOCOL_P0 %t
|
|
@protocol P0;
|
|
|
|
// No object generated
|
|
// RUN: not grep OBJC_PROTOCOL_P1 %t
|
|
@protocol P1 -im1; @end
|
|
|
|
// Definition triggered by protocol reference.
|
|
// RUN: grep OBJC_PROTOCOL_P2 %t | count 3
|
|
// RUN: grep OBJC_PROTOCOL_INSTANCE_METHODS_P2 %t | count 3
|
|
@protocol P2 -im1; @end
|
|
void f0(void) { id x = @protocol(P2); }
|
|
|
|
// Forward definition triggered by protocol reference.
|
|
// RUN: grep OBJC_PROTOCOL_P3 %t | count 3
|
|
// RUN: not grep OBJC_PROTOCOL_INSTANCE_METHODS_P3 %t
|
|
@protocol P3;
|
|
@interface UserP3<P3>
|
|
@end
|
|
@implementation UserP3
|
|
@end
|
|
|
|
// Definition triggered by class reference.
|
|
// RUN: grep OBJC_PROTOCOL_P4 %t | count 3
|
|
// RUN: grep OBJC_PROTOCOL_INSTANCE_METHODS_P4 %t | count 3
|
|
@protocol P4 -im1; @end
|
|
@interface I0<P4> @end
|
|
@implementation I0 -im1 { return 0; }; @end
|
|
|
|
// Definition following forward reference.
|
|
// RUN: grep OBJC_PROTOCOL_P5 %t | count 3
|
|
// RUN: grep OBJC_PROTOCOL_INSTANCE_METHODS_P5 %t | count 3
|
|
@protocol P5;
|
|
@interface UserP5<P5> // This generates a forward
|
|
// reference, which has to be
|
|
// updated on the next line.
|
|
@end
|
|
@protocol P5 -im1; @end
|
|
@implementation UserP5
|
|
|
|
- im1 { __builtin_unreachable(); }
|
|
|
|
@end
|
|
|
|
// Protocol reference following definition.
|
|
// RUN: grep OBJC_PROTOCOL_P6 %t | count 4
|
|
// RUN: grep OBJC_PROTOCOL_INSTANCE_METHODS_P6 %t | count 3
|
|
@protocol P6 -im1; @end
|
|
@interface I1<P6> @end
|
|
@implementation I1 -im1 { return 0; }; @end
|
|
void f3(void) { id x = @protocol(P6); }
|
|
|