mirror of
https://github.com/llvm/llvm-project.git
synced 2025-04-28 08:36:06 +00:00
a8f2e24e48
We have seen random symbol not found "__cxa_throw" error in fuschia build bots and out-of-tree users. The understanding have been that they are built without exception support, but it turned out that these platforms have LLVM_STATIC_LINK_CXX_STDLIB ON so that they link libstdc++ to llvm statically. The reason why this is problematic for clang-repl is that by default clang-repl tries to find symbols from symbol table of executable and dynamic libraries loaded by current process. It needs to load another libstdc++, but the platform that had LLVM_STATIC_LINK_CXX_STDLIB turned on is usally those with missing or obsolate shared libstdc++ in the first place -- trying to load it again would be destined to fail eventually with a risk to introuduce mixed libstdc++ versions. A proper solution that doesn't take a workaround is statically link the same libstdc++ by clang-repl side, but this is not possible with old JIT linker runtimedyld. New just-in-time linker JITLink handles this relatively well, but it's not availalbe in majority of platforms. For now, this patch just disables the building of clang-repl when LLVM_STATIC_LINK_CXX_STDLIB is ON and removes the "__cxa_throw" check in exception unittest as well as reverting previous exception check flag patch. Reviewed By: v.g.vassilev Differential Revision: https://reviews.llvm.org/D130788
13 lines
505 B
C++
13 lines
505 B
C++
// RUN: clang-repl "int x = 10;" "int y=7; err;" "int y = 10;"
|
|
// RUN: clang-repl "int i = 10;" 'extern "C" int printf(const char*,...);' \
|
|
// RUN: 'auto r1 = printf("i = %d\n", i);' | FileCheck --check-prefix=CHECK-DRIVER %s
|
|
// CHECK-DRIVER: i = 10
|
|
// UNSUPPORTED: system-aix, system-windows
|
|
// RUN: cat %s | clang-repl | FileCheck %s
|
|
extern "C" int printf(const char *, ...);
|
|
int __attribute__((weak)) bar() { return 42; }
|
|
auto r4 = printf("bar() = %d\n", bar());
|
|
// CHECK: bar() = 42
|
|
|
|
%quit
|