mirror of
https://github.com/llvm/llvm-project.git
synced 2025-04-25 10:26:06 +00:00
58f3c5e696
This supersedes https://github.com/llvm/llvm-project/pull/87818 and fixes https://github.com/llvm/llvm-project/issues/52767 When calculating arm64 thunks, we make a few assumptions that may not hold when considering code sections outside of `__text`: 1. That a section needs thunks only if its size is larger than the branch range. 2. That any calls into `__stubs` are necessarily forward jumps (that is, the section with the jump is ordered before `__stubs`) Sections like this exist in the wild, most prominently the `__lcxx_overrides` section introduced in https://github.com/llvm/llvm-project/pull/69498 This change: - Ensures that if one section in `__TEXT` gets thunks, all of them do. - Makes all code sections in `__TEXT` contiguous (and guaranteed to be placed before `__stubs`)
37 lines
1.1 KiB
C++
37 lines
1.1 KiB
C++
//===- Sections.cpp ---------------------------------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "Sections.h"
|
|
#include "InputSection.h"
|
|
#include "OutputSegment.h"
|
|
|
|
#include "llvm/ADT/StringSwitch.h"
|
|
|
|
using namespace llvm;
|
|
using namespace llvm::MachO;
|
|
|
|
namespace lld::macho::sections {
|
|
bool isCodeSection(StringRef name, StringRef segName, uint32_t flags) {
|
|
uint32_t type = sectionType(flags);
|
|
if (type != S_REGULAR && type != S_COALESCED)
|
|
return false;
|
|
|
|
uint32_t attr = flags & SECTION_ATTRIBUTES_USR;
|
|
if (attr == S_ATTR_PURE_INSTRUCTIONS)
|
|
return true;
|
|
|
|
if (segName == segment_names::text)
|
|
return StringSwitch<bool>(name)
|
|
.Cases(section_names::textCoalNt, section_names::staticInit, true)
|
|
.Default(false);
|
|
|
|
return false;
|
|
}
|
|
|
|
} // namespace lld::macho::sections
|