mirror of
https://github.com/llvm/llvm-project.git
synced 2025-04-25 18:36:05 +00:00
0f1c1be196
We have a new policy in place making links to private resources something we try to avoid in source and test files. Normally, we'd organically switch to the new policy rather than make a sweeping change across a project. However, Clang is in a somewhat special circumstance currently: recently, I've had several new contributors run into rdar links around test code which their patch was changing the behavior of. This turns out to be a surprisingly bad experience, especially for newer folks, for a handful of reasons: not understanding what the link is and feeling intimidated by it, wondering whether their changes are actually breaking something important to a downstream in some way, having to hunt down strangers not involved with the patch to impose on them for help, accidental pressure from asking for potentially private IP to be made public, etc. Because folks run into these links entirely by chance (through fixing bugs or working on new features), there's not really a set of problematic links to focus on -- all of the links have basically the same potential for causing these problems. As a result, this is an omnibus patch to remove all such links. This was not a mechanical change; it was done by manually searching for rdar, radar, radr, and other variants to find all the various problematic links. From there, I tried to retain or reword the surrounding comments so that we would lose as little context as possible. However, because most links were just a plain link with no supporting context, the majority of the changes are simple removals. Differential Review: https://reviews.llvm.org/D158071
29 lines
1.2 KiB
C++
29 lines
1.2 KiB
C++
// RUN: %clang_cc1 %s -triple=x86_64-apple-darwin -debug-info-kind=limited -emit-llvm -o - | FileCheck %s
|
|
// This test is for a crash when emitting debug info for not-yet-completed
|
|
// types.
|
|
// Test that we don't actually emit a forward decl for the offending class:
|
|
// CHECK: !DICompositeType(tag: DW_TAG_structure_type, name: "Derived<int>"
|
|
// CHECK-NOT: DIFlagFwdDecl
|
|
// CHECK-SAME: ){{$}}
|
|
template <class A> class Derived;
|
|
|
|
template <class A> class Base {
|
|
static Derived<A> *create();
|
|
};
|
|
|
|
template <class A> struct Derived : Base<A> {
|
|
};
|
|
|
|
Base<int> *f;
|
|
|
|
// During the instantiation of Derived<int>, Base<int> becomes required to be
|
|
// complete - since the declaration has already been emitted (due to 'f',
|
|
// above), we immediately try to build debug info for Base<int> which then
|
|
// requires the (incomplete definition) of Derived<int> which is problematic.
|
|
//
|
|
// (if 'f' is not present, the point at which Base<int> becomes required to be
|
|
// complete during the instantiation of Derived<int> is a no-op because
|
|
// Base<int> was never emitted so we ignore it and carry on until we
|
|
// wire up the base class of Derived<int> in the debug info later on)
|
|
Derived<int> d;
|