mirrors/llvm-project
0
0
Fork 0
mirror of https://github.com/llvm/llvm-project.git synced 2025-05-02 01:56:07 +00:00
Code Issues Projects Releases Wiki Activity
llvm-project/libcxx/include/__algorithm
History
Hui Xie 7abbd6224b [libc++] Fix proxy iterator issues that trigger an assertion in Chromium. 
Crash report:
https://bugs.chromium.org/p/chromium/issues/detail?id=1346012

The triggered assertion is related sorting with `v8::internal::AtomicSlot`.
`AtomicSlot` is a proxy iterator with a proxy type `AtomicSlot::Reference`
(see 9bcb5eb590/src/objects/slots-atomic-inl.h).

https://reviews.llvm.org/D130197 correctly spotted the issue in
`__iter_move` but doesn't actually fix the issue. The reason is that
`AtomicSlot::operator*` returns a prvalue `Reference`. After the fix in
D130197, the return type of `__iter_move` is `Reference&&`. But the
rvalue reference is bound to the temporary value returned by
`operator*`, which will be dangling after `__iter_move` returns.

The idea of the fix in this change is borrowed from C++17's move_iterator
https://timsong-cpp.github.io/cppwp/n4659/move.iterators#move.iterator-1
When the underlying reference is a prvalue, we just return it by value.

Differential Revision: https://reviews.llvm.org/D130212
2022-07-20 18:05:49 -07:00
..
adjacent_find.h
[libc++] Revert "Protect users from relying on detail headers" & related changes
2022-03-01 08:20:24 -05:00
all_of.h
[libc++] Revert "Protect users from relying on detail headers" & related changes
2022-03-01 08:20:24 -05:00
any_of.h
[libc++] Revert "Protect users from relying on detail headers" & related changes
2022-03-01 08:20:24 -05:00
binary_search.h
[libc++] Make parameter names consistent and enforce the naming style using readability-identifier-naming
2022-07-08 18:17:47 +02:00
clamp.h
[libc++] Revert "Protect users from relying on detail headers" & related changes
2022-03-01 08:20:24 -05:00
comp_ref_type.h
[libc++] Make the Debug mode a configuration-time only option
2022-06-07 16:33:53 -04:00
comp.h
[libc++] Revert "Protect users from relying on detail headers" & related changes
2022-03-01 08:20:24 -05:00
copy_backward.h
[libc++] Implement ranges::copy{, _n, _if, _backward}
2022-04-15 13:44:11 +02:00
copy_if.h
[libc++] Revert "Protect users from relying on detail headers" & related changes
2022-03-01 08:20:24 -05:00
copy_n.h
[libc++] Revert "Protect users from relying on detail headers" & related changes
2022-03-01 08:20:24 -05:00
copy.h
[libc++] Unwrap reverse_iterator<reverse_iterator<Iter>> in __unwrap_iter
2022-06-17 18:47:18 +02:00
count_if.h
[libc++] Revert "Protect users from relying on detail headers" & related changes
2022-03-01 08:20:24 -05:00
count.h
[libc++] Make parameter names consistent and enforce the naming style using readability-identifier-naming
2022-07-08 18:17:47 +02:00
equal_range.h
[lib++][ranges][NFC] Refactor iterator_operations.h to use tags.
2022-07-12 17:53:58 -07:00
equal.h
[libc++] Revert "Protect users from relying on detail headers" & related changes
2022-03-01 08:20:24 -05:00
fill_n.h
[libc++] Make parameter names consistent and enforce the naming style using readability-identifier-naming
2022-07-08 18:17:47 +02:00
fill.h
[libc++] Make parameter names consistent and enforce the naming style using readability-identifier-naming
2022-07-08 18:17:47 +02:00
find_end.h
[libc++] Implement ranges::find_end, ranges::search{, _n}
2022-07-13 20:30:55 +02:00
find_first_of.h
[libc++] Revert "Protect users from relying on detail headers" & related changes
2022-03-01 08:20:24 -05:00
find_if_not.h
[libc++] Revert "Protect users from relying on detail headers" & related changes
2022-03-01 08:20:24 -05:00
find_if.h
[libc++] Revert "Protect users from relying on detail headers" & related changes
2022-03-01 08:20:24 -05:00
find.h
[libc++] Make parameter names consistent and enforce the naming style using readability-identifier-naming
2022-07-08 18:17:47 +02:00
for_each_n.h
[libc++] Revert "Protect users from relying on detail headers" & related changes
2022-03-01 08:20:24 -05:00
for_each.h
[libc++] Revert "Protect users from relying on detail headers" & related changes
2022-03-01 08:20:24 -05:00
generate_n.h
[libc++] Revert "Protect users from relying on detail headers" & related changes
2022-03-01 08:20:24 -05:00
generate.h
[libc++] Revert "Protect users from relying on detail headers" & related changes
2022-03-01 08:20:24 -05:00
half_positive.h
[libc++] Revert "Protect users from relying on detail headers" & related changes
2022-03-01 08:20:24 -05:00
in_found_result.h
[libc++] Rename the template arguments of the algorithm result types
2022-04-10 14:22:13 +02:00
in_fun_result.h
[libc++] Rename the template arguments of the algorithm result types
2022-04-10 14:22:13 +02:00
in_in_out_result.h
[libc++] Rename the template arguments of the algorithm result types
2022-04-10 14:22:13 +02:00
in_in_result.h
[libc++] Rename the template arguments of the algorithm result types
2022-04-10 14:22:13 +02:00
in_out_out_result.h
[libc++] Rename the template arguments of the algorithm result types
2022-04-10 14:22:13 +02:00
in_out_result.h
[libc++] Rename the template arguments of the algorithm result types
2022-04-10 14:22:13 +02:00
includes.h
[libc++] Revert "Protect users from relying on detail headers" & related changes
2022-03-01 08:20:24 -05:00
inplace_merge.h
[libc++][ranges] Make range algorithms support proxy iterators
2022-07-17 18:12:06 -07:00
is_heap_until.h
[libc++] Revert "Protect users from relying on detail headers" & related changes
2022-03-01 08:20:24 -05:00
is_heap.h
[libc++] Revert "Protect users from relying on detail headers" & related changes
2022-03-01 08:20:24 -05:00
is_partitioned.h
[libc++] Revert "Protect users from relying on detail headers" & related changes
2022-03-01 08:20:24 -05:00
is_permutation.h
[libc++] Revert "Protect users from relying on detail headers" & related changes
2022-03-01 08:20:24 -05:00
is_sorted_until.h
[libc++] Revert "Protect users from relying on detail headers" & related changes
2022-03-01 08:20:24 -05:00
is_sorted.h
[libc++] Revert "Protect users from relying on detail headers" & related changes
2022-03-01 08:20:24 -05:00
iter_swap.h
[libc++] Revert "Protect users from relying on detail headers" & related changes
2022-03-01 08:20:24 -05:00
iterator_operations.h
[libc++] Fix proxy iterator issues that trigger an assertion in Chromium.
2022-07-20 18:05:49 -07:00
lexicographical_compare.h
[libc++] Revert "Protect users from relying on detail headers" & related changes
2022-03-01 08:20:24 -05:00
lower_bound.h
[lib++][ranges][NFC] Refactor iterator_operations.h to use tags.
2022-07-12 17:53:58 -07:00
make_heap.h
[libc++][ranges] Make range algorithms support proxy iterators
2022-07-17 18:12:06 -07:00
make_projected.h
[libc++][ranges] Implement ranges::{,stable_}partition.
2022-07-18 21:06:17 -07:00
max_element.h
[libc++] Revert "Protect users from relying on detail headers" & related changes
2022-03-01 08:20:24 -05:00
max.h
[libc++] Revert "Protect users from relying on detail headers" & related changes
2022-03-01 08:20:24 -05:00
merge.h
[libc++] Revert "Protect users from relying on detail headers" & related changes
2022-03-01 08:20:24 -05:00
min_element.h
[libc++][ranges] Make range algorithms support proxy iterators
2022-07-17 18:12:06 -07:00
min_max_result.h
[libc++] Canonicalize the ranges results and their tests
2022-04-02 08:26:31 +02:00
min.h
[libc++] Revert "Protect users from relying on detail headers" & related changes
2022-03-01 08:20:24 -05:00
minmax_element.h
[libc++] Make parameter names consistent and enforce the naming style using readability-identifier-naming
2022-07-08 18:17:47 +02:00
minmax.h
[libc++][ranges] Implement ranges::minmax and ranges::minmax_element
2022-04-14 15:37:22 +02:00
mismatch.h
[libc++] Revert "Protect users from relying on detail headers" & related changes
2022-03-01 08:20:24 -05:00
move_backward.h
[libc++] Revert "Protect users from relying on detail headers" & related changes
2022-03-01 08:20:24 -05:00
move.h
[libc++] Implement ranges::move{, _backward}
2022-06-23 13:52:49 +02:00
next_permutation.h
[libc++] Revert "Protect users from relying on detail headers" & related changes
2022-03-01 08:20:24 -05:00
none_of.h
[libc++] Revert "Protect users from relying on detail headers" & related changes
2022-03-01 08:20:24 -05:00
nth_element.h
[libc++][ranges] Make range algorithms support proxy iterators
2022-07-17 18:12:06 -07:00
partial_sort_copy.h
[libc++][ranges] Make range algorithms support proxy iterators
2022-07-17 18:12:06 -07:00
partial_sort.h
[libc++][ranges] Implement ranges::partial_sort.
2022-07-19 20:10:34 -07:00
partition_copy.h
[libc++] Revert "Protect users from relying on detail headers" & related changes
2022-03-01 08:20:24 -05:00
partition_point.h
[libc++] Granularize <iterator> includes
2022-06-10 22:43:57 +02:00
partition.h
[libc++][ranges] Implement ranges::{,stable_}partition.
2022-07-18 21:06:17 -07:00
pop_heap.h
[libc++][ranges] Implement ranges::partial_sort.
2022-07-19 20:10:34 -07:00
prev_permutation.h
[libc++] Revert "Protect users from relying on detail headers" & related changes
2022-03-01 08:20:24 -05:00
push_heap.h
[libc++][ranges] Implement ranges::partial_sort.
2022-07-19 20:10:34 -07:00
ranges_adjacent_find.h
[libc++] Implement ranges::adjacent_find
2022-06-08 12:15:03 +02:00
ranges_all_of.h
[libc++] Implement ranges::{all, any, none}_of
2022-05-26 16:50:08 +02:00
ranges_any_of.h
[libc++] Implement ranges::{all, any, none}_of
2022-05-26 16:50:08 +02:00
ranges_binary_search.h
[lib++][ranges][NFC] Refactor iterator_operations.h to use tags.
2022-07-12 17:53:58 -07:00
ranges_copy_backward.h
[libc++] Implement ranges::copy{, _n, _if, _backward}
2022-04-15 13:44:11 +02:00
ranges_copy_if.h
[libc++] Implement ranges::copy{, _n, _if, _backward}
2022-04-15 13:44:11 +02:00
ranges_copy_n.h
[libc++] Implement ranges::copy{, _n, _if, _backward}
2022-04-15 13:44:11 +02:00
ranges_copy.h
[libc++] Implement ranges::copy{, _n, _if, _backward}
2022-04-15 13:44:11 +02:00
ranges_count_if.h
[libc++] Granularize <iterator> includes
2022-06-10 22:43:57 +02:00
ranges_count.h
[libc++] Granularize <iterator> includes
2022-06-10 22:43:57 +02:00
ranges_equal_range.h
[libc++][ranges][NFC] Implement the repetitive parts of the remaining range algorithms:
2022-07-12 02:48:31 -07:00
ranges_equal.h
[libc++] Implement ranges::equal
2022-05-26 10:46:54 +02:00
ranges_fill_n.h
[libc++] Implement ranges::fill{, _n}
2022-05-25 10:27:13 +02:00
ranges_fill.h
[libc++][ranges] Make range algorithms support proxy iterators
2022-07-17 18:12:06 -07:00
ranges_find_end.h
[libc++][ranges] Implement ranges::{,stable_}partition.
2022-07-18 21:06:17 -07:00
ranges_find_first_of.h
[libc++] Implement ranges::find_first_of
2022-06-06 22:29:02 +02:00
ranges_find_if_not.h
[libc++][ranges] Implement ranges::find{, _if, _if_not}
2022-03-12 01:46:02 +01:00
ranges_find_if.h
[libc++][ranges] Implement ranges::find{, _if, _if_not}
2022-03-12 01:46:02 +01:00
ranges_find.h
[libc++][ranges] Implement ranges::find{, _if, _if_not}
2022-03-12 01:46:02 +01:00
ranges_for_each_n.h
[libc++][ranges][NFC] Consolidate range algorithm checks for returning dangling.
2022-07-19 20:46:22 -07:00
ranges_for_each.h
[libc++] Implement ranges::for_each{, _n}
2022-05-04 20:28:01 +02:00
ranges_generate_n.h
[libc++][ranges][NFC] Consolidate range algorithm checks for returning dangling.
2022-07-19 20:46:22 -07:00
ranges_generate.h
[libc++][ranges][NFC] Implement the repetitive parts of the remaining range algorithms:
2022-07-12 02:48:31 -07:00
ranges_includes.h
[libc++][ranges][NFC] Consolidate range algorithm checks for returning dangling.
2022-07-19 20:46:22 -07:00
ranges_inplace_merge.h
[libc++][ranges][NFC] Implement the repetitive parts of the remaining range algorithms:
2022-07-12 02:48:31 -07:00
ranges_is_heap_until.h
[libc++][ranges][NFC] Implement the repetitive parts of the remaining range algorithms:
2022-07-12 02:48:31 -07:00
ranges_is_heap.h
[libc++][ranges][NFC] Consolidate range algorithm checks for returning dangling.
2022-07-19 20:46:22 -07:00
ranges_is_partitioned.h
[libc++] Implement ranges::is_partitioned
2022-05-06 13:02:38 +02:00
ranges_is_sorted_until.h
[libc++] Implement ranges::is_sorted{, _until}
2022-05-27 10:28:44 +02:00
ranges_is_sorted.h
[libc++] Implement ranges::is_sorted{, _until}
2022-05-27 10:28:44 +02:00
ranges_iterator_concept.h
[libc++][ranges] Implement ranges::{,stable_}partition.
2022-07-18 21:06:17 -07:00
ranges_lexicographical_compare.h
[libc++] Implement ranges::lexicographical_compare
2022-06-15 22:29:21 +02:00
ranges_lower_bound.h
[lib++][ranges][NFC] Refactor iterator_operations.h to use tags.
2022-07-12 17:53:58 -07:00
ranges_make_heap.h
[libc++][ranges] Make range algorithms support proxy iterators
2022-07-17 18:12:06 -07:00
ranges_max_element.h
[libc++] Add ranges::max_element to the synopsis and ADL-proof the __min_element_impl calls
2022-05-23 20:50:04 +02:00
ranges_max.h
[libc++][ranges] Implement ranges::max
2022-04-03 17:04:56 +02:00
ranges_merge.h
[libc++] Implement std::ranges::merge
2022-07-04 13:44:31 +01:00
ranges_min_element.h
[libc++][ranges] Make range algorithms support proxy iterators
2022-07-17 18:12:06 -07:00
ranges_min.h
[libc++][ranges] Implement ranges::min
2022-03-18 12:52:21 +01:00
ranges_minmax_element.h
[libc++][ranges] Implement ranges::minmax and ranges::minmax_element
2022-04-14 15:37:22 +02:00
ranges_minmax.h
[libc++] Add a few missing min/max macro push/pop
2022-06-27 12:57:39 -04:00
ranges_mismatch.h
[libc++] Canonicalize the ranges results and their tests
2022-04-02 08:26:31 +02:00
ranges_move_backward.h
[libc++] Implement ranges::move{, _backward}
2022-06-23 13:52:49 +02:00
ranges_move.h
[libc++] Implement ranges::move{, _backward}
2022-06-23 13:52:49 +02:00
ranges_none_of.h
[libc++] Implement ranges::{all, any, none}_of
2022-05-26 16:50:08 +02:00
ranges_nth_element.h
[libc++][ranges] Make range algorithms support proxy iterators
2022-07-17 18:12:06 -07:00
ranges_partial_sort_copy.h
[libc++][ranges][NFC] Implement the repetitive parts of the remaining range algorithms:
2022-07-12 02:48:31 -07:00
ranges_partial_sort.h
[libc++][ranges] Implement ranges::partial_sort.
2022-07-19 20:10:34 -07:00
ranges_partition_copy.h
[libc++][ranges] Implement std::ranges::partition_{point,copy}.
2022-07-20 11:39:07 -07:00
ranges_partition_point.h
[libc++][ranges] Implement std::ranges::partition_{point,copy}.
2022-07-20 11:39:07 -07:00
ranges_partition.h
[libc++][ranges] Implement ranges::{,stable_}partition.
2022-07-18 21:06:17 -07:00
ranges_pop_heap.h
[libc++][ranges] Make range algorithms support proxy iterators
2022-07-17 18:12:06 -07:00
ranges_push_heap.h
[libc++][ranges] Make range algorithms support proxy iterators
2022-07-17 18:12:06 -07:00
ranges_remove_copy_if.h
[libc++][ranges][NFC] Implement the repetitive parts of the remaining range algorithms:
2022-07-12 02:48:31 -07:00
ranges_remove_copy.h
[libc++][ranges][NFC] Implement the repetitive parts of the remaining range algorithms:
2022-07-12 02:48:31 -07:00
ranges_remove_if.h
[libc++] Implement ranges::remove{, _if}
2022-07-06 18:47:13 +02:00
ranges_remove.h
[libc++] Implement ranges::remove{, _if}
2022-07-06 18:47:13 +02:00
ranges_replace_copy_if.h
[libc++][ranges][NFC] Implement the repetitive parts of the remaining range algorithms:
2022-07-12 02:48:31 -07:00
ranges_replace_copy.h
[libc++][ranges][NFC] Implement the repetitive parts of the remaining range algorithms:
2022-07-12 02:48:31 -07:00
ranges_replace_if.h
[libc++] Implement ranges::replace{, _if}
2022-06-10 11:54:46 +02:00
ranges_replace.h
[libc++] Implement ranges::replace{, _if}
2022-06-10 11:54:46 +02:00
ranges_reverse_copy.h
[libc++] Implement ranges::{reverse, rotate}_copy
2022-07-11 21:13:08 +02:00
ranges_reverse.h
[libc++] Implement ranges::reverse
2022-05-24 10:33:57 +02:00
ranges_rotate_copy.h
[libc++] Implement ranges::{reverse, rotate}_copy
2022-07-11 21:13:08 +02:00
ranges_search_n.h
[libc++] Implement ranges::find_end, ranges::search{, _n}
2022-07-13 20:30:55 +02:00
ranges_search.h
[libc++] Implement ranges::find_end, ranges::search{, _n}
2022-07-13 20:30:55 +02:00
ranges_set_difference.h
[libcxx][ranges] implement std::ranges::set_difference
2022-07-08 13:26:23 +01:00
ranges_set_intersection.h
[libc++][ranges] implement std::ranges::set_symmetric_difference
2022-07-13 21:24:32 +01:00
ranges_set_symmetric_difference.h
[libc++][ranges] implement std::ranges::set_symmetric_difference
2022-07-13 21:24:32 +01:00
ranges_set_union.h
[libc++][ranges] implement std::ranges::set_union
2022-07-14 21:05:30 +01:00
ranges_shuffle.h
[libc++][ranges][NFC] Implement the repetitive parts of the remaining range algorithms:
2022-07-12 02:48:31 -07:00
ranges_sort_heap.h
[libc++][ranges] Make range algorithms support proxy iterators
2022-07-17 18:12:06 -07:00
ranges_sort.h
[libc++][ranges] Make range algorithms support proxy iterators
2022-07-17 18:12:06 -07:00
ranges_stable_partition.h
[libc++][ranges] Implement ranges::{,stable_}partition.
2022-07-18 21:06:17 -07:00
ranges_stable_sort.h
[libc++][ranges] Make range algorithms support proxy iterators
2022-07-17 18:12:06 -07:00
ranges_swap_ranges.h
[libc++] Canonicalize the ranges results and their tests
2022-04-02 08:26:31 +02:00
ranges_transform.h
[libc++][ranges] Implement ranges::transform
2022-04-05 11:06:28 +02:00
ranges_unique_copy.h
[libc++][ranges][NFC] Implement the repetitive parts of the remaining range algorithms:
2022-07-12 02:48:31 -07:00
ranges_unique.h
[libc++][ranges][NFC] Implement the repetitive parts of the remaining range algorithms:
2022-07-12 02:48:31 -07:00
ranges_upper_bound.h
[lib++][ranges][NFC] Refactor iterator_operations.h to use tags.
2022-07-12 17:53:58 -07:00
remove_copy_if.h
[libc++] Revert "Protect users from relying on detail headers" & related changes
2022-03-01 08:20:24 -05:00
remove_copy.h
[libc++] Make parameter names consistent and enforce the naming style using readability-identifier-naming
2022-07-08 18:17:47 +02:00
remove_if.h
[libc++] Revert "Protect users from relying on detail headers" & related changes
2022-03-01 08:20:24 -05:00
remove.h
[libc++] Make parameter names consistent and enforce the naming style using readability-identifier-naming
2022-07-08 18:17:47 +02:00
replace_copy_if.h
[libc++] Revert "Protect users from relying on detail headers" & related changes
2022-03-01 08:20:24 -05:00
replace_copy.h
[libc++] Revert "Protect users from relying on detail headers" & related changes
2022-03-01 08:20:24 -05:00
replace_if.h
[libc++] Revert "Protect users from relying on detail headers" & related changes
2022-03-01 08:20:24 -05:00
replace.h
[libc++] Revert "Protect users from relying on detail headers" & related changes
2022-03-01 08:20:24 -05:00
reverse_copy.h
[libc++] Revert "Protect users from relying on detail headers" & related changes
2022-03-01 08:20:24 -05:00
reverse.h
[libc++] Revert "Protect users from relying on detail headers" & related changes
2022-03-01 08:20:24 -05:00
rotate_copy.h
[libc++] Revert "Protect users from relying on detail headers" & related changes
2022-03-01 08:20:24 -05:00
rotate.h
[libc++][ranges] Implement ranges::{,stable_}partition.
2022-07-18 21:06:17 -07:00
sample.h
[libc++] Granularize <iterator> includes
2022-06-10 22:43:57 +02:00
search_n.h
[libc++][ranges] fix std::search_n incorrect static_assert
2022-07-19 17:24:47 -07:00
search.h
[libc++] Implement ranges::find_end, ranges::search{, _n}
2022-07-13 20:30:55 +02:00
set_difference.h
[libcxx][ranges] implement std::ranges::set_difference
2022-07-08 13:26:23 +01:00
set_intersection.h
[libc++][ranges] implement std::ranges::set_symmetric_difference
2022-07-13 21:24:32 +01:00
set_symmetric_difference.h
[libc++][ranges] implement std::ranges::set_symmetric_difference
2022-07-13 21:24:32 +01:00
set_union.h
[libc++][ranges] implement std::ranges::set_union
2022-07-14 21:05:30 +01:00
shift_left.h
[libc++] Revert "Protect users from relying on detail headers" & related changes
2022-03-01 08:20:24 -05:00
shift_right.h
[libc++] Revert "Protect users from relying on detail headers" & related changes
2022-03-01 08:20:24 -05:00
shuffle.h
[libc++][ranges] Make range algorithms support proxy iterators
2022-07-17 18:12:06 -07:00
sift_down.h
[libc++][ranges] Make range algorithms support proxy iterators
2022-07-17 18:12:06 -07:00
sort_heap.h
[libc++][ranges] Implement ranges::partial_sort.
2022-07-19 20:10:34 -07:00
sort.h
[libc++][ranges] Implement ranges::partial_sort.
2022-07-19 20:10:34 -07:00
stable_partition.h
[libc++][ranges] Implement ranges::{,stable_}partition.
2022-07-18 21:06:17 -07:00
stable_sort.h
[libc++][ranges] Make range algorithms support proxy iterators
2022-07-17 18:12:06 -07:00
swap_ranges.h
[libc++] Revert "Protect users from relying on detail headers" & related changes
2022-03-01 08:20:24 -05:00
transform.h
[libc++] Revert "Protect users from relying on detail headers" & related changes
2022-03-01 08:20:24 -05:00
unique_copy.h
[libc++] Revert "Protect users from relying on detail headers" & related changes
2022-03-01 08:20:24 -05:00
unique.h
[libc++] Revert "Protect users from relying on detail headers" & related changes
2022-03-01 08:20:24 -05:00
unwrap_iter.h
[libc++] Use __unwrap_iter_impl for both unwrapping and rewrapping
2022-07-14 20:01:19 +02:00
upper_bound.h
[libc++] Make parameter names consistent and enforce the naming style using readability-identifier-naming
2022-07-08 18:17:47 +02:00