mirror of
https://github.com/llvm/llvm-project.git
synced 2025-04-29 01:46:05 +00:00
0f1c1be196
We have a new policy in place making links to private resources something we try to avoid in source and test files. Normally, we'd organically switch to the new policy rather than make a sweeping change across a project. However, Clang is in a somewhat special circumstance currently: recently, I've had several new contributors run into rdar links around test code which their patch was changing the behavior of. This turns out to be a surprisingly bad experience, especially for newer folks, for a handful of reasons: not understanding what the link is and feeling intimidated by it, wondering whether their changes are actually breaking something important to a downstream in some way, having to hunt down strangers not involved with the patch to impose on them for help, accidental pressure from asking for potentially private IP to be made public, etc. Because folks run into these links entirely by chance (through fixing bugs or working on new features), there's not really a set of problematic links to focus on -- all of the links have basically the same potential for causing these problems. As a result, this is an omnibus patch to remove all such links. This was not a mechanical change; it was done by manually searching for rdar, radar, radr, and other variants to find all the various problematic links. From there, I tried to retain or reword the surrounding comments so that we would lose as little context as possible. However, because most links were just a plain link with no supporting context, the majority of the changes are simple removals. Differential Review: https://reviews.llvm.org/D158071
63 lines
1.9 KiB
C
63 lines
1.9 KiB
C
// RUN: %clang_cc1 -emit-llvm -o - -triple i386-linux-gnu %s | FileCheck %s
|
|
|
|
// This checks that the global won't be marked as common.
|
|
// (It shouldn't because it's being initialized).
|
|
|
|
int a;
|
|
int a = 242;
|
|
// CHECK: @a ={{.*}} global i32 242
|
|
|
|
// This should get normal weak linkage.
|
|
int c __attribute__((weak))= 0;
|
|
// CHECK: @c = weak global i32 0
|
|
|
|
// Even though is marked const, it should get still get "weak"
|
|
// linkage, not "weak_odr" as the weak attribute makes it possible
|
|
// that there is a strong definition that changes the value linktime,
|
|
// so the value must not be considered constant.
|
|
// CHECK: @d = weak constant i32 0
|
|
const int d __attribute__((weak))= 0;
|
|
|
|
// However, "selectany" is similar to "weak", but isn't interposable
|
|
// by a strong definition, and should appear as weak_odr.
|
|
// CHECK: @e = weak_odr constant i32 17
|
|
const int e __attribute__((selectany)) = 17;
|
|
|
|
// PR6168 "too many undefs"
|
|
struct ManyFields {
|
|
int a;
|
|
int b;
|
|
int c;
|
|
char d;
|
|
int e;
|
|
int f;
|
|
};
|
|
|
|
// CHECK: global %struct.ManyFields { i32 1, i32 2, i32 0, i8 0, i32 0, i32 0 }
|
|
struct ManyFields FewInits = {1, 2};
|
|
|
|
|
|
// PR6766
|
|
// CHECK: @l ={{.*}} global %struct.K { [6 x i32] [i32 102, i32 111, i32 111, i32 0, i32 0, i32 0], i32 1 }
|
|
typedef __WCHAR_TYPE__ wchar_t;
|
|
struct K {
|
|
wchar_t L[6];
|
|
int M;
|
|
} l = { { L"foo" }, 1 };
|
|
|
|
|
|
// CHECK: @yuv_types ={{.*}} global [4 x [6 x i8]] {{\[}}[6 x i8] c"4:0:0\00", [6 x i8] c"4:2:0\00", [6 x i8] c"4:2:2\00", [6 x i8] c"4:4:4\00"]
|
|
char yuv_types[4][6]= {"4:0:0","4:2:0","4:2:2","4:4:4"};
|
|
|
|
unsigned long long x = -1000;
|
|
// CHECK: @x ={{.*}} global i64 -1000
|
|
unsigned long long uint_max = 4294967295u;
|
|
// CHECK: @uint_max ={{.*}} global i64 4294967295
|
|
|
|
|
|
// NOTE: tentative definitions are processed at the end of the translation unit.
|
|
|
|
// This shouldn't be emitted as common because it has an explicit section.
|
|
// CHECK: @b ={{.*}} global i32 0, section "foo"
|
|
int b __attribute__((section("foo")));
|