mirror of
https://github.com/llvm/llvm-project.git
synced 2025-05-02 15:36:08 +00:00
6542cb55a3
This patch is basically the rewording of the static assert statement's
output(error) on screen after failing. Failing a _Static_assert in C
should not report that static_assert failed. It’d probably be better to
reword the diagnostic to be more like GCC and say “static assertion”
failed in both C and C++.
consider a c file having code
_Static_assert(0, "oh no!");
In clang the output is like:
<source>:1:1: error: static_assert failed: oh no!
_Static_assert(0, "oh no!");
^ ~
1 error generated.
Compiler returned: 1
Thus here the "static_assert" is not much good, it will be better to
reword it to the "static assertion failed" to more generic. as the gcc
prints as:
<source>:1:1: error: static assertion failed: "oh no!"
1 | _Static_assert(0, "oh no!");
| ^~~~~~~~~~~~~~
Compiler returned: 1
The above can also be seen here. This patch is about rewording
the static_assert to static assertion.
Differential Revision: https://reviews.llvm.org/D129048
52 lines
1.6 KiB
C++
52 lines
1.6 KiB
C++
//===----------------------------------------------------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
// <string>
|
|
// ... manipulating sequences of any non-array trivial standard-layout types.
|
|
|
|
#include <string>
|
|
#include "test_traits.h"
|
|
|
|
struct NotTrivial {
|
|
NotTrivial() : value(3) {}
|
|
int value;
|
|
};
|
|
|
|
struct NotStandardLayout {
|
|
public:
|
|
NotStandardLayout() : one(1), two(2) {}
|
|
int sum() const { return one + two; } // silences "unused field 'two' warning"
|
|
int one;
|
|
private:
|
|
int two;
|
|
};
|
|
|
|
void f() {
|
|
{
|
|
// array
|
|
typedef char C[3];
|
|
static_assert(std::is_array<C>::value, "");
|
|
std::basic_string<C, test_traits<C> > s;
|
|
// expected-error-re@string:* {{static assertion failed{{.*}}Character type of basic_string must not be an array}}
|
|
}
|
|
|
|
{
|
|
// not trivial
|
|
static_assert(!std::is_trivial<NotTrivial>::value, "");
|
|
std::basic_string<NotTrivial, test_traits<NotTrivial> > s;
|
|
// expected-error-re@string:* {{static assertion failed{{.*}}Character type of basic_string must be trivial}}
|
|
}
|
|
|
|
{
|
|
// not standard layout
|
|
static_assert(!std::is_standard_layout<NotStandardLayout>::value, "");
|
|
std::basic_string<NotStandardLayout, test_traits<NotStandardLayout> > s;
|
|
// expected-error-re@string:* {{static assertion failed{{.*}}Character type of basic_string must be standard-layout}}
|
|
}
|
|
}
|