mirror of
https://github.com/llvm/llvm-project.git
synced 2025-05-02 09:56:07 +00:00
70ec1dd14d
In the current implementation, we run visitors until the fixed point is reached. That is, if a visitor adds another visitor, the currently processed path is destroyed, all diagnostics is discarded, and it is regenerated again, until it's no longer modified. This pattern has a few negative implications: - This loop does not even guarantee to terminate. E.g. just imagine two visitors bouncing a diagnostics around. - Performance-wise, e.g. for sqlite3 all visitors are being re-run at least 10 times for some bugs. We have already seen a few reports where it leads to timeouts. - If we want to add more computationally intense visitors, this will become worse. - From architectural standpoint, the current layout requires copying visitors, which is conceptually wrong, and can be annoying (e.g. no unique_ptr on visitors allowed). The proposed change is a much simpler architecture: the outer loop processes nodes upwards, and whenever the visitor is added it only processes current nodes and above, thus guaranteeing termination. Differential Revision: https://reviews.llvm.org/D47856 llvm-svn: 335666
53 lines
3.0 KiB
C
53 lines
3.0 KiB
C
// RUN: %clang_analyze_cc1 -w -x c -analyzer-checker=core,unix -analyzer-output=text -verify %s
|
|
|
|
// Avoid the crash when finding the expression for tracking the origins
|
|
// of the null pointer for path notes.
|
|
void pr34373() {
|
|
int *a = 0; // expected-note{{'a' initialized to a null pointer value}}
|
|
(a + 0)[0]; // expected-warning{{Array access results in a null pointer dereference}}
|
|
// expected-note@-1{{Array access results in a null pointer dereference}}
|
|
}
|
|
|
|
typedef __typeof(sizeof(int)) size_t;
|
|
void *memcpy(void *dest, const void *src, unsigned long count);
|
|
|
|
void f1(char *source) {
|
|
char *destination = 0; // expected-note{{'destination' initialized to a null pointer value}}
|
|
memcpy(destination + 0, source, 10); // expected-warning{{Null pointer argument in call to memory copy function}}
|
|
// expected-note@-1{{Null pointer argument in call to memory copy function}}
|
|
}
|
|
|
|
void f2(char *source) {
|
|
char *destination = 0; // expected-note{{'destination' initialized to a null pointer value}}
|
|
memcpy(destination - 0, source, 10); // expected-warning{{Null pointer argument in call to memory copy function}}
|
|
// expected-note@-1{{Null pointer argument in call to memory copy function}}
|
|
}
|
|
|
|
void f3(char *source) {
|
|
char *destination = 0; // expected-note{{'destination' initialized to a null pointer value}}
|
|
destination = destination + 0; // expected-note{{Null pointer value stored to 'destination'}}
|
|
memcpy(destination, source, 10); // expected-warning{{Null pointer argument in call to memory copy function}}
|
|
// expected-note@-1{{Null pointer argument in call to memory copy function}}
|
|
}
|
|
|
|
void f4(char *source) {
|
|
char *destination = 0; // expected-note{{'destination' initialized to a null pointer value}}
|
|
destination = destination - 0; // expected-note{{Null pointer value stored to 'destination'}}
|
|
memcpy(destination, source, 10); // expected-warning{{Null pointer argument in call to memory copy function}}
|
|
// expected-note@-1{{Null pointer argument in call to memory copy function}}
|
|
}
|
|
|
|
void f5(char *source) {
|
|
char *destination1 = 0; // expected-note{{'destination1' initialized to a null pointer value}}
|
|
char *destination2 = destination1 + 0; // expected-note{{'destination2' initialized to a null pointer value}}
|
|
memcpy(destination2, source, 10); // expected-warning{{Null pointer argument in call to memory copy function}}
|
|
// expected-note@-1{{Null pointer argument in call to memory copy function}}
|
|
}
|
|
|
|
void f6(char *source) {
|
|
char *destination1 = 0; // expected-note{{'destination1' initialized to a null pointer value}}
|
|
char *destination2 = destination1 - 0; // expected-note{{'destination2' initialized to a null pointer value}}
|
|
memcpy(destination2, source, 10); // expected-warning{{Null pointer argument in call to memory copy function}}
|
|
// expected-note@-1{{Null pointer argument in call to memory copy function}}
|
|
}
|