mirror of
https://github.com/llvm/llvm-project.git
synced 2025-05-06 03:46:06 +00:00
38818b60c5
Use deduction guides instead of helper functions.
The only non-automatic changes have been:
1. ArrayRef(some_uint8_pointer, 0) needs to be changed into ArrayRef(some_uint8_pointer, (size_t)0) to avoid an ambiguous call with ArrayRef((uint8_t*), (uint8_t*))
2. CVSymbol sym(makeArrayRef(symStorage)); needed to be rewritten as CVSymbol sym{ArrayRef(symStorage)}; otherwise the compiler is confused and thinks we have a (bad) function prototype. There was a few similar situation across the codebase.
3. ADL doesn't seem to work the same for deduction-guides and functions, so at some point the llvm namespace must be explicitly stated.
4. The "reference mode" of makeArrayRef(ArrayRef<T> &) that acts as no-op is not supported (a constructor cannot achieve that).
Per reviewers' comment, some useless makeArrayRef have been removed in the process.
This is a follow-up to https://reviews.llvm.org/D140896 that introduced
the deduction guides.
Differential Revision: https://reviews.llvm.org/D140955
127 lines
3.9 KiB
C++
127 lines
3.9 KiB
C++
//===- DebugInlineeLinesSubsection.cpp ------------------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "llvm/DebugInfo/CodeView/DebugInlineeLinesSubsection.h"
|
|
#include "llvm/ADT/ArrayRef.h"
|
|
#include "llvm/DebugInfo/CodeView/CodeView.h"
|
|
#include "llvm/DebugInfo/CodeView/DebugChecksumsSubsection.h"
|
|
#include "llvm/DebugInfo/CodeView/RecordSerialization.h"
|
|
#include "llvm/Support/BinaryStreamReader.h"
|
|
#include "llvm/Support/BinaryStreamWriter.h"
|
|
#include "llvm/Support/Endian.h"
|
|
#include "llvm/Support/Error.h"
|
|
#include <cassert>
|
|
#include <cstdint>
|
|
|
|
using namespace llvm;
|
|
using namespace llvm::codeview;
|
|
|
|
Error VarStreamArrayExtractor<InlineeSourceLine>::
|
|
operator()(BinaryStreamRef Stream, uint32_t &Len, InlineeSourceLine &Item) {
|
|
BinaryStreamReader Reader(Stream);
|
|
|
|
if (auto EC = Reader.readObject(Item.Header))
|
|
return EC;
|
|
|
|
if (HasExtraFiles) {
|
|
uint32_t ExtraFileCount;
|
|
if (auto EC = Reader.readInteger(ExtraFileCount))
|
|
return EC;
|
|
if (auto EC = Reader.readArray(Item.ExtraFiles, ExtraFileCount))
|
|
return EC;
|
|
}
|
|
|
|
Len = Reader.getOffset();
|
|
return Error::success();
|
|
}
|
|
|
|
DebugInlineeLinesSubsectionRef::DebugInlineeLinesSubsectionRef()
|
|
: DebugSubsectionRef(DebugSubsectionKind::InlineeLines) {}
|
|
|
|
Error DebugInlineeLinesSubsectionRef::initialize(BinaryStreamReader Reader) {
|
|
if (auto EC = Reader.readEnum(Signature))
|
|
return EC;
|
|
|
|
Lines.getExtractor().HasExtraFiles = hasExtraFiles();
|
|
if (auto EC = Reader.readArray(Lines, Reader.bytesRemaining()))
|
|
return EC;
|
|
|
|
assert(Reader.bytesRemaining() == 0);
|
|
return Error::success();
|
|
}
|
|
|
|
bool DebugInlineeLinesSubsectionRef::hasExtraFiles() const {
|
|
return Signature == InlineeLinesSignature::ExtraFiles;
|
|
}
|
|
|
|
DebugInlineeLinesSubsection::DebugInlineeLinesSubsection(
|
|
DebugChecksumsSubsection &Checksums, bool HasExtraFiles)
|
|
: DebugSubsection(DebugSubsectionKind::InlineeLines), Checksums(Checksums),
|
|
HasExtraFiles(HasExtraFiles) {}
|
|
|
|
uint32_t DebugInlineeLinesSubsection::calculateSerializedSize() const {
|
|
// 4 bytes for the signature
|
|
uint32_t Size = sizeof(InlineeLinesSignature);
|
|
|
|
// one header for each entry.
|
|
Size += Entries.size() * sizeof(InlineeSourceLineHeader);
|
|
if (HasExtraFiles) {
|
|
// If extra files are enabled, one count for each entry.
|
|
Size += Entries.size() * sizeof(uint32_t);
|
|
|
|
// And one file id for each file.
|
|
Size += ExtraFileCount * sizeof(uint32_t);
|
|
}
|
|
assert(Size % 4 == 0);
|
|
return Size;
|
|
}
|
|
|
|
Error DebugInlineeLinesSubsection::commit(BinaryStreamWriter &Writer) const {
|
|
InlineeLinesSignature Sig = InlineeLinesSignature::Normal;
|
|
if (HasExtraFiles)
|
|
Sig = InlineeLinesSignature::ExtraFiles;
|
|
|
|
if (auto EC = Writer.writeEnum(Sig))
|
|
return EC;
|
|
|
|
for (const auto &E : Entries) {
|
|
if (auto EC = Writer.writeObject(E.Header))
|
|
return EC;
|
|
|
|
if (!HasExtraFiles)
|
|
continue;
|
|
|
|
if (auto EC = Writer.writeInteger<uint32_t>(E.ExtraFiles.size()))
|
|
return EC;
|
|
if (auto EC = Writer.writeArray(ArrayRef(E.ExtraFiles)))
|
|
return EC;
|
|
}
|
|
|
|
return Error::success();
|
|
}
|
|
|
|
void DebugInlineeLinesSubsection::addExtraFile(StringRef FileName) {
|
|
uint32_t Offset = Checksums.mapChecksumOffset(FileName);
|
|
|
|
auto &Entry = Entries.back();
|
|
Entry.ExtraFiles.push_back(ulittle32_t(Offset));
|
|
++ExtraFileCount;
|
|
}
|
|
|
|
void DebugInlineeLinesSubsection::addInlineSite(TypeIndex FuncId,
|
|
StringRef FileName,
|
|
uint32_t SourceLine) {
|
|
uint32_t Offset = Checksums.mapChecksumOffset(FileName);
|
|
|
|
Entries.emplace_back();
|
|
auto &Entry = Entries.back();
|
|
Entry.Header.FileID = Offset;
|
|
Entry.Header.SourceLineNum = SourceLine;
|
|
Entry.Header.Inlinee = FuncId;
|
|
}
|