mirror of
https://github.com/llvm/llvm-project.git
synced 2025-04-18 18:46:40 +00:00
3e20bae827
Fix compile time regression and memory leak In the previous change, we saw: - Memory leak: https://lab.llvm.org/buildbot/#/builders/169/builds/5193 - 0.5% Compile time regression [link](https://llvm-compile-time-tracker.com/compare.php?from=4a68e4cbd2423dcacada8162ab7c4bb8d7f7e2cf&to=8c4331c1abeb33eabf3cdbefa7f2b6e0540e7f4f&stat=instructions:u) For compile time regression, we make the Param->Idx `StringMap` for **all** functions. This `StringMap` is expensive and should not be computed when none of the params are annotated with `[[clang::lifetime_capture_by(X)]]`. For the memory leak, the small vectors used in Attribute are not destroyed because the attributes are allocated through ASTContext's allocator. We therefore need a raw array in this case.
48 lines
2.6 KiB
C++
48 lines
2.6 KiB
C++
// RUN: %clang_cc1 -std=c++23 -verify %s
|
|
|
|
struct S {
|
|
const int *x;
|
|
void captureInt(const int&x [[clang::lifetime_capture_by(this)]]) { this->x = &x; }
|
|
};
|
|
|
|
///////////////////////////
|
|
// Test for valid usages.
|
|
///////////////////////////
|
|
[[clang::lifetime_capture_by(unknown)]] // expected-error {{'lifetime_capture_by' attribute only applies to parameters and implicit object parameters}}
|
|
void nonMember(
|
|
const int &x1 [[clang::lifetime_capture_by(s, t)]],
|
|
S &s,
|
|
S &t,
|
|
const int &x2 [[clang::lifetime_capture_by(12345 + 12)]], // expected-error {{'lifetime_capture_by' attribute argument 12345 + 12 is not a known function parameter; must be a function parameter, 'this', 'global' or 'unknown'}}
|
|
const int &x3 [[clang::lifetime_capture_by(abcdefgh)]], // expected-error {{'lifetime_capture_by' attribute argument 'abcdefgh' is not a known function parameter; must be a function parameter, 'this', 'global' or 'unknown'}}
|
|
const int &x4 [[clang::lifetime_capture_by("abcdefgh")]], // expected-error {{'lifetime_capture_by' attribute argument "abcdefgh" is not a known function parameter; must be a function parameter, 'this', 'global' or 'unknown'}}
|
|
const int &x5 [[clang::lifetime_capture_by(this)]], // expected-error {{'lifetime_capture_by' argument references unavailable implicit 'this'}}
|
|
const int &x6 [[clang::lifetime_capture_by()]], // expected-error {{'lifetime_capture_by' attribute specifies no capturing entity}}
|
|
const int& x7 [[clang::lifetime_capture_by(u,
|
|
x7)]], // expected-error {{'lifetime_capture_by' argument references itself}}
|
|
const int &x8 [[clang::lifetime_capture_by(global)]],
|
|
const int &x9 [[clang::lifetime_capture_by(unknown)]],
|
|
const int &test_memory_leak[[clang::lifetime_capture_by(x1,x2, x3, x4, x5, x6, x7, x8, x9)]],
|
|
const S& u
|
|
)
|
|
{
|
|
s.captureInt(x1);
|
|
}
|
|
|
|
void unknown_param_name(const int& unknown, // expected-error {{parameter cannot be named 'unknown' while using 'lifetime_capture_by(unknown)'}}
|
|
const int& s [[clang::lifetime_capture_by(unknown)]]);
|
|
void global_param_name(const int& global, // expected-error {{parameter cannot be named 'global' while using 'lifetime_capture_by(global)'}}
|
|
const int& s [[clang::lifetime_capture_by(global)]]);
|
|
struct T {
|
|
void member(
|
|
const int &x [[clang::lifetime_capture_by(s)]],
|
|
S &s,
|
|
S &t,
|
|
const int &y [[clang::lifetime_capture_by(s)]],
|
|
const int &z [[clang::lifetime_capture_by(this, x, y)]],
|
|
const int &u [[clang::lifetime_capture_by(global, unknown, x, s)]])
|
|
{
|
|
s.captureInt(x);
|
|
}
|
|
};
|