mirror of
https://github.com/llvm/llvm-project.git
synced 2025-04-17 17:26:41 +00:00

The language wording change forgot to update overload resolution to rank implicit conversion sequences based on qualification conversions in reference bindings. The anticipated resolution for that oversight is implemented here -- we order candidates based on qualification conversion, not only on top-level cv-qualifiers, including ranking reference bindings against non-reference bindings if they differ in non-top-level qualification conversions. For OpenCL/C++, this allows reference binding between pointers with differing (nested) address spaces. This makes the behavior of reference binding consistent with that of implicit pointer conversions, as is the purpose of this change, but that pre-existing behavior for pointer conversions is itself probably not correct. In any case, it's now consistently the same behavior and implemented in only one place. This reinstates commit de21704ba96fa80d3e9402f12c6505917a3885f4, reverted in commit d8018233d1ea4234de68d5b4593abd773db79484, with workarounds for some overload resolution ordering problems introduced by CWG2352.
51 lines
1.2 KiB
C++
51 lines
1.2 KiB
C++
// RUN: %clang_cc1 -fsyntax-only -verify %s -std=c++11
|
|
|
|
enum E2 { };
|
|
|
|
struct A {
|
|
operator E2&(); // expected-note 3 {{candidate function}}
|
|
};
|
|
|
|
struct B {
|
|
operator E2&(); // expected-note 3 {{candidate function}}
|
|
};
|
|
|
|
struct C : B, A {
|
|
};
|
|
|
|
void test(C c) {
|
|
const E2 &e2 = c; // expected-error {{reference initialization of type 'const E2 &' with initializer of type 'C' is ambiguous}}
|
|
}
|
|
|
|
void foo(const E2 &);// expected-note{{passing argument to parameter here}}
|
|
|
|
const E2 & re(C c) {
|
|
foo(c); // expected-error {{reference initialization of type 'const E2 &' with initializer of type 'C' is ambiguous}}
|
|
|
|
return c; // expected-error {{reference initialization of type 'const E2 &' with initializer of type 'C' is ambiguous}}
|
|
}
|
|
|
|
namespace CWG2352 {
|
|
void f(const int * const &) = delete;
|
|
void f(int *);
|
|
|
|
void g(int * &);
|
|
void g(const int *) = delete;
|
|
|
|
void h1(int *const * const &);
|
|
void h1(const int *const *) = delete;
|
|
void h2(const int *const * const &) = delete;
|
|
void h2(int *const *);
|
|
|
|
void test() {
|
|
int *x;
|
|
// Under CWG2352, this became ambiguous. We order by qualification
|
|
// conversion even when comparing a reference binding to a
|
|
// non-reference-binding.
|
|
f(x);
|
|
g(x);
|
|
h1(&x);
|
|
h2(&x);
|
|
}
|
|
}
|