mirror of
https://github.com/llvm/llvm-project.git
synced 2025-04-17 17:46:49 +00:00
eb10b065f2
Background: ----------- There are two related argument types which can be sent into a diagnostic to display the name of an entity: DeclarationName (ak_declarationname) or NamedDecl* (ak_nameddecl) (there is also ak_identifierinfo for IdentifierInfo*, but we are not concerned with it here). A DeclarationName in a diagnostic will just be streamed to the output, which will directly result in a call to DeclarationName::print. A NamedDecl* in a diagnostic will also ultimately result in a call to DeclarationName::print, but with two customisation points along the way: The first customisation point is NamedDecl::getNameForDiagnostic which is overloaded by FunctionDecl, ClassTemplateSpecializationDecl and VarTemplateSpecializationDecl to print the template arguments, if any. The second customisation point is NamedDecl::printName. By default it just streams the stored DeclarationName into the output but it can be customised to provide a user-friendly name for an entity. It is currently overloaded by DecompositionDecl and MSGuidDecl. What this patch does: --------------------- For many diagnostics a DeclarationName is used instead of the NamedDecl*. This bypasses the two customisation points mentioned above. This patches fix this for diagnostics in Sema.cpp, SemaCast.cpp, SemaChecking.cpp, SemaDecl.cpp, SemaDeclAttr.cpp, SemaDecl.cpp, SemaOverload.cpp and SemaStmt.cpp. I have only modified diagnostics where I could construct a test-case which demonstrates that the change is appropriate (either with this patch or the next one). Reviewed By: erichkeane, aaron.ballman Differential Revision: https://reviews.llvm.org/D84656
64 lines
1.0 KiB
C++
64 lines
1.0 KiB
C++
// RUN: %clang_cc1 -fsyntax-only -verify -Wall %s
|
|
|
|
namespace test1 {
|
|
static void f() {} // expected-warning {{function 'f' is not needed and will not be emitted}}
|
|
static void f();
|
|
template <typename T>
|
|
void foo() {
|
|
f();
|
|
}
|
|
}
|
|
|
|
namespace test1_template {
|
|
template <typename T> static void f() {}
|
|
template <> void f<int>() {} // expected-warning {{function 'f<int>' is not needed and will not be emitted}}
|
|
template <typename T>
|
|
void foo() {
|
|
f<int>();
|
|
f<long>();
|
|
}
|
|
} // namespace test1_template
|
|
|
|
namespace test2 {
|
|
static void f() {}
|
|
static void f();
|
|
static void g() { f(); }
|
|
void h() { g(); }
|
|
}
|
|
|
|
namespace test3 {
|
|
static void f();
|
|
template<typename T>
|
|
static void g() {
|
|
f();
|
|
}
|
|
static void f() {
|
|
}
|
|
void h() {
|
|
g<int>();
|
|
}
|
|
}
|
|
|
|
namespace test4 {
|
|
static void f();
|
|
static void f();
|
|
template<typename T>
|
|
static void g() {
|
|
f();
|
|
}
|
|
static void f() {
|
|
}
|
|
void h() {
|
|
g<int>();
|
|
}
|
|
}
|
|
|
|
namespace test4 {
|
|
static void func();
|
|
void bar() {
|
|
void func();
|
|
func();
|
|
}
|
|
static void func() {}
|
|
}
|