mirror of
https://github.com/llvm/llvm-project.git
synced 2025-04-18 00:16:39 +00:00
eb10b065f2
Background: ----------- There are two related argument types which can be sent into a diagnostic to display the name of an entity: DeclarationName (ak_declarationname) or NamedDecl* (ak_nameddecl) (there is also ak_identifierinfo for IdentifierInfo*, but we are not concerned with it here). A DeclarationName in a diagnostic will just be streamed to the output, which will directly result in a call to DeclarationName::print. A NamedDecl* in a diagnostic will also ultimately result in a call to DeclarationName::print, but with two customisation points along the way: The first customisation point is NamedDecl::getNameForDiagnostic which is overloaded by FunctionDecl, ClassTemplateSpecializationDecl and VarTemplateSpecializationDecl to print the template arguments, if any. The second customisation point is NamedDecl::printName. By default it just streams the stored DeclarationName into the output but it can be customised to provide a user-friendly name for an entity. It is currently overloaded by DecompositionDecl and MSGuidDecl. What this patch does: --------------------- For many diagnostics a DeclarationName is used instead of the NamedDecl*. This bypasses the two customisation points mentioned above. This patches fix this for diagnostics in Sema.cpp, SemaCast.cpp, SemaChecking.cpp, SemaDecl.cpp, SemaDeclAttr.cpp, SemaDecl.cpp, SemaOverload.cpp and SemaStmt.cpp. I have only modified diagnostics where I could construct a test-case which demonstrates that the change is appropriate (either with this patch or the next one). Reviewed By: erichkeane, aaron.ballman Differential Revision: https://reviews.llvm.org/D84656
55 lines
2.1 KiB
C++
55 lines
2.1 KiB
C++
// RUN: %clang_cc1 %s -fsyntax-only -verify -Wcall-to-pure-virtual-from-ctor-dtor
|
|
struct A {
|
|
A() { f(); } // expected-warning {{call to pure virtual member function 'f' has undefined behavior; overrides of 'f' in subclasses are not available in the constructor of 'A'}}
|
|
~A() { f(); } // expected-warning {{call to pure virtual member function 'f' has undefined behavior; overrides of 'f' in subclasses are not available in the destructor of 'A'}}
|
|
|
|
virtual void f() = 0; // expected-note 2 {{'f' declared here}}
|
|
};
|
|
|
|
// Don't warn (or note) when calling the function on a pointer. (PR10195)
|
|
struct B {
|
|
A *a;
|
|
B() { a->f(); };
|
|
~B() { a->f(); };
|
|
};
|
|
|
|
// Don't warn if the call is fully qualified. (PR23215)
|
|
struct C {
|
|
virtual void f() = 0;
|
|
C() {
|
|
C::f();
|
|
}
|
|
};
|
|
|
|
template <typename T> struct TA {
|
|
TA() { f(); } // expected-warning {{call to pure virtual member function 'f' has undefined behavior; overrides of 'f' in subclasses are not available in the constructor of 'TA<float>'}}
|
|
~TA() { f(); } // expected-warning {{call to pure virtual member function 'f' has undefined behavior; overrides of 'f' in subclasses are not available in the destructor of 'TA<float>'}}
|
|
|
|
virtual void f() = 0; // expected-note 2{{'f' declared here}}
|
|
};
|
|
|
|
template <> struct TA<int> {
|
|
TA() { f(); }
|
|
~TA() { f(); }
|
|
void f();
|
|
};
|
|
|
|
template <> struct TA<long> {
|
|
TA() { f(); } // expected-warning {{call to pure virtual member function 'f' has undefined behavior; overrides of 'f' in subclasses are not available in the constructor of 'TA<long>'}}
|
|
~TA() { f(); } // expected-warning {{call to pure virtual member function 'f' has undefined behavior; overrides of 'f' in subclasses are not available in the destructor of 'TA<long>'}}
|
|
virtual void f() = 0; // expected-note 2{{'f' declared here}}
|
|
};
|
|
|
|
struct TB : TA<float> { // expected-note {{in instantiation of member function 'TA<float>::TA' requested here}}
|
|
void f() override; // expected-note@-1 {{in instantiation of member function 'TA<float>::~TA' requested here}}
|
|
};
|
|
TB tb;
|
|
|
|
struct TC : TA<int> {}; // ok
|
|
TC tc; // ok
|
|
|
|
struct TD : TA<long> {
|
|
void f() override;
|
|
};
|
|
TD td;
|