mirror of
https://github.com/llvm/llvm-project.git
synced 2025-04-17 22:16:46 +00:00
acf5ad2a4e
Consider the following:
```
template<typename T>
struct A
{
struct B : A { };
};
```
According to [class.derived.general] p2:
> [...] A _class-or-decltype_ shall denote a (possibly cv-qualified)
class type that is not an incompletely defined class; any cv-qualifiers
are ignored. [...]
Although GCC and EDG rejects this, Clang accepts it. This is incorrect,
as `A` is incomplete within its own definition (outside of a
complete-class context). This patch correctly diagnoses instances where
the current instantiation is used as a base class before it is complete.
Conversely, Clang erroneously rejects the following:
```
template<typename T>
struct A
{
struct B;
struct C : B { };
struct B : C { }; // error: circular inheritance between 'C' and 'A::B'
};
```
Though it may seem like no valid specialization of this template can be
instantiated, an explicit specialization of either member classes for an
implicit instantiated specialization of `A` would permit the definition
of the other member class to be instantiated, e.g.:
```
template<>
struct A<int>::B { };
A<int>::C c; // ok
```
So this patch also does away with this error. This means that circular
inheritance is diagnosed during instantiation of the definition as a
consequence of requiring the base class type to be complete (matching
the behavior of GCC and EDG).
107 lines
1.9 KiB
C++
107 lines
1.9 KiB
C++
// RUN: %clang_cc1 -fsyntax-only -verify -std=c++11 %s
|
|
|
|
template<typename A> class s0 {
|
|
template<typename B> class s1;
|
|
};
|
|
|
|
template<typename A>
|
|
template<typename B>
|
|
class s0<A>::s1 : s0<A> {
|
|
~s1() {}
|
|
s0<A> ms0;
|
|
};
|
|
|
|
struct Incomplete;
|
|
|
|
template<typename T>
|
|
void destroy_me(T me) {
|
|
me.~T();
|
|
}
|
|
|
|
template void destroy_me(Incomplete*);
|
|
|
|
namespace PR6152 {
|
|
template<typename T> struct X { void f(); };
|
|
template<typename T> struct Y { };
|
|
template<typename T>
|
|
void X<T>::f() {
|
|
Y<T> *y;
|
|
y->template Y<T>::~Y();
|
|
y->template Y<T>::~Y<T>();
|
|
y->~Y();
|
|
}
|
|
|
|
template struct X<int>;
|
|
}
|
|
|
|
namespace cvquals {
|
|
template<typename T>
|
|
void f(int *ptr) {
|
|
ptr->~T();
|
|
}
|
|
|
|
template void f<const volatile int>(int *);
|
|
}
|
|
|
|
namespace PR7239 {
|
|
template<class E> class A { };
|
|
class B {
|
|
void f() {
|
|
A<int>* x;
|
|
x->A<int>::~A<int>();
|
|
}
|
|
};
|
|
}
|
|
|
|
namespace PR7904 {
|
|
struct Foo {};
|
|
template <class T>
|
|
Foo::~Foo() { // expected-error{{destructor cannot be declared as a template}}
|
|
T t;
|
|
T &pT = t;
|
|
pT;
|
|
}
|
|
Foo f;
|
|
}
|
|
|
|
namespace rdar13140795 {
|
|
template <class T> class shared_ptr {};
|
|
|
|
template <typename T> struct Marshal {
|
|
static int gc();
|
|
};
|
|
|
|
|
|
template <typename T> int Marshal<T>::gc() {
|
|
shared_ptr<T> *x;
|
|
x->template shared_ptr<T>::~shared_ptr();
|
|
return 0;
|
|
}
|
|
|
|
void test() {
|
|
Marshal<int>::gc();
|
|
}
|
|
}
|
|
|
|
namespace PR16852 {
|
|
template<typename T> struct S { int a; T x; };
|
|
template<typename T> decltype(S<T>().~S()) f(); // expected-note {{candidate template ignored: couldn't infer template argument 'T'}}
|
|
void g() { f(); } // expected-error {{no matching function for call to 'f'}}
|
|
}
|
|
|
|
class PR33189
|
|
{
|
|
template <class T>
|
|
~PR33189() { } // expected-error{{destructor cannot be declared as a template}}
|
|
};
|
|
|
|
namespace PR38671 {
|
|
struct S {
|
|
template <class>
|
|
~S(); // expected-error{{destructor cannot be declared as a template}}
|
|
};
|
|
struct T : S {
|
|
~T() = default;
|
|
};
|
|
} // namespace PR38671
|