Karl-Johan Karlsson fb463778a7 [builtins] Fix undefined behavior in negdi2.c and negti2.c
When compiling the builtins with the undefined behavior sanitizer and running testcases you end up with the following warning:

UBSan: negdi2.c:20:10: negation of -9223372036854775808 cannot be represented in type 'di_int' (aka 'long long'); cast to an unsigned type to negate this value to itself

This can be avoided by doing negation in a matching unsigned variant of the type.

The same kind of pattern is found in negti2.c

This was found in an out of tree target.

Reviewed By: MaskRay

Differential Revision: https://reviews.llvm.org/D158818
2023-08-28 06:39:47 +02:00

26 lines
776 B
C

//===-- negti2.c - Implement __negti2 -------------------------------------===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
//
// This file implements __negti2 for the compiler_rt library.
//
//===----------------------------------------------------------------------===//
#include "int_lib.h"
#ifdef CRT_HAS_128BIT
// Returns: -a
COMPILER_RT_ABI ti_int __negti2(ti_int a) {
// Note: this routine is here for API compatibility; any sane compiler
// should expand it inline.
return -(tu_int)a;
}
#endif // CRT_HAS_128BIT