mirror of
https://github.com/llvm/llvm-project.git
synced 2025-04-25 20:56:06 +00:00
330d8983d2
In a nutshell, this moves our libomptarget code to populate the offload subproject. With this commit, users need to enable the new LLVM/Offload subproject as a runtime in their cmake configuration. No further changes are expected for downstream code. Tests and other components still depend on OpenMP and have also not been renamed. The results below are for a build in which OpenMP and Offload are enabled runtimes. In addition to the pure `git mv`, we needed to adjust some CMake files. Nothing is intended to change semantics. ``` ninja check-offload ``` Works with the X86 and AMDGPU offload tests ``` ninja check-openmp ``` Still works but doesn't build offload tests anymore. ``` ls install/lib ``` Shows all expected libraries, incl. - `libomptarget.devicertl.a` - `libomptarget-nvptx-sm_90.bc` - `libomptarget.rtl.amdgpu.so` -> `libomptarget.rtl.amdgpu.so.18git` - `libomptarget.so` -> `libomptarget.so.18git` Fixes: https://github.com/llvm/llvm-project/issues/75124 --------- Co-authored-by: Saiyedul Islam <Saiyedul.Islam@amd.com>
48 lines
1.3 KiB
C
48 lines
1.3 KiB
C
// Check that omp atomic compare handles signedness of integer comparisons
|
|
// correctly.
|
|
//
|
|
// At one time, a bug sometimes reversed the signedness.
|
|
|
|
// RUN: %libomptarget-compile-generic
|
|
// RUN: %libomptarget-run-generic | %fcheck-generic
|
|
// RUN: %libomptarget-compileopt-generic -fopenmp-version=51
|
|
// RUN: %libomptarget-run-generic | %fcheck-generic
|
|
|
|
// High parallelism increases our chances of detecting a lack of atomicity.
|
|
#define NUM_THREADS_TRY 256
|
|
|
|
#include <limits.h>
|
|
#include <omp.h>
|
|
#include <stdio.h>
|
|
|
|
int main() {
|
|
// CHECK: signed: num_threads=[[#NUM_THREADS:]]{{$}}
|
|
// CHECK-NEXT: signed: xs=[[#NUM_THREADS-1]]{{$}}
|
|
int xs = -1;
|
|
int numThreads;
|
|
#pragma omp target parallel for num_threads(NUM_THREADS_TRY) \
|
|
map(tofrom : xs, numThreads)
|
|
for (int i = 0; i < omp_get_num_threads(); ++i) {
|
|
#pragma omp atomic compare
|
|
if (xs < i) {
|
|
xs = i;
|
|
}
|
|
if (i == 0)
|
|
numThreads = omp_get_num_threads();
|
|
}
|
|
printf("signed: num_threads=%d\n", numThreads);
|
|
printf("signed: xs=%d\n", xs);
|
|
|
|
// CHECK-NEXT: unsigned: xu=0x0{{$}}
|
|
unsigned xu = UINT_MAX;
|
|
#pragma omp target parallel for num_threads(NUM_THREADS_TRY) map(tofrom : xu)
|
|
for (int i = 0; i < omp_get_num_threads(); ++i) {
|
|
#pragma omp atomic compare
|
|
if (xu > i) {
|
|
xu = i;
|
|
}
|
|
}
|
|
printf("unsigned: xu=0x%x\n", xu);
|
|
return 0;
|
|
}
|