mirror of
https://github.com/llvm/llvm-project.git
synced 2025-04-26 02:46:08 +00:00
0f1c1be196
We have a new policy in place making links to private resources something we try to avoid in source and test files. Normally, we'd organically switch to the new policy rather than make a sweeping change across a project. However, Clang is in a somewhat special circumstance currently: recently, I've had several new contributors run into rdar links around test code which their patch was changing the behavior of. This turns out to be a surprisingly bad experience, especially for newer folks, for a handful of reasons: not understanding what the link is and feeling intimidated by it, wondering whether their changes are actually breaking something important to a downstream in some way, having to hunt down strangers not involved with the patch to impose on them for help, accidental pressure from asking for potentially private IP to be made public, etc. Because folks run into these links entirely by chance (through fixing bugs or working on new features), there's not really a set of problematic links to focus on -- all of the links have basically the same potential for causing these problems. As a result, this is an omnibus patch to remove all such links. This was not a mechanical change; it was done by manually searching for rdar, radar, radr, and other variants to find all the various problematic links. From there, I tried to retain or reword the surrounding comments so that we would lose as little context as possible. However, because most links were just a plain link with no supporting context, the majority of the changes are simple removals. Differential Review: https://reviews.llvm.org/D158071
62 lines
2.4 KiB
C
62 lines
2.4 KiB
C
// RUN: %clang_cc1 -fsyntax-only -verify -Wassign-enum %s
|
|
|
|
typedef enum CCTestEnum
|
|
{
|
|
One,
|
|
Two=4,
|
|
Three
|
|
} CCTestEnum;
|
|
|
|
CCTestEnum test = 50; // expected-warning {{integer constant not in range of enumerated type 'CCTestEnum'}}
|
|
CCTestEnum test1 = -50; // expected-warning {{integer constant not in range of enumerated type 'CCTestEnum'}}
|
|
|
|
// Explicit cast should silence the warning.
|
|
static const CCTestEnum SilenceWithCast1 = 51; // expected-warning {{integer constant not in range of enumerated type 'CCTestEnum'}}
|
|
static const CCTestEnum SilenceWithCast2 = (CCTestEnum) 51; // no-warning
|
|
static const CCTestEnum SilenceWithCast3 = (const CCTestEnum) 51; // no-warning
|
|
static const CCTestEnum SilenceWithCast4 = (const volatile CCTestEnum) 51; // no-warning
|
|
|
|
void SilenceWithCastLocalVar(void) {
|
|
CCTestEnum SilenceWithCast1 = 51; // expected-warning {{integer constant not in range of enumerated type 'CCTestEnum'}}
|
|
CCTestEnum SilenceWithCast2 = (CCTestEnum) 51; // no-warning
|
|
CCTestEnum SilenceWithCast3 = (const CCTestEnum) 51; // no-warning
|
|
CCTestEnum SilenceWithCast4 = (const volatile CCTestEnum) 51; // no-warning
|
|
|
|
const CCTestEnum SilenceWithCast1c = 51; // expected-warning {{integer constant not in range of enumerated type 'CCTestEnum'}}
|
|
const CCTestEnum SilenceWithCast2c = (CCTestEnum) 51; // no-warning
|
|
const CCTestEnum SilenceWithCast3c = (const CCTestEnum) 51; // no-warning
|
|
const CCTestEnum SilenceWithCast4c = (const volatile CCTestEnum) 51; // no-warning
|
|
}
|
|
|
|
CCTestEnum foo(CCTestEnum r) {
|
|
return 20; // expected-warning {{integer constant not in range of enumerated type 'CCTestEnum'}}
|
|
}
|
|
|
|
enum Test2 { K_zero, K_one };
|
|
enum Test2 test2(enum Test2 *t) {
|
|
*t = 20; // expected-warning {{integer constant not in range of enumerated type 'enum Test2'}}
|
|
return 10; // expected-warning {{integer constant not in range of enumerated type 'enum Test2'}}
|
|
}
|
|
|
|
// PR15069
|
|
typedef enum
|
|
{
|
|
a = 0
|
|
} T;
|
|
|
|
void f(void)
|
|
{
|
|
T x = a;
|
|
x += 1; // expected-warning {{integer constant not in range of enumerated type}}
|
|
}
|
|
|
|
int main(void) {
|
|
CCTestEnum test = 1; // expected-warning {{integer constant not in range of enumerated type 'CCTestEnum'}}
|
|
test = 600; // expected-warning {{integer constant not in range of enumerated type 'CCTestEnum'}}
|
|
foo(2); // expected-warning {{integer constant not in range of enumerated type 'CCTestEnum'}}
|
|
foo(-1); // expected-warning {{integer constant not in range of enumerated type 'CCTestEnum'}}
|
|
foo(4);
|
|
foo(Two+1);
|
|
}
|
|
|