mirror of
https://github.com/llvm/llvm-project.git
synced 2025-04-26 12:26:08 +00:00
84a3aadf0f
Reapplication of 7339c0f782d5c70e0928f8991b0c05338a90c84c with a fix for a crash involving arrays without a size expression. Clang supports VLAs in C++ as an extension, but we currently only warn on their use when you pass -Wvla, -Wvla-extension, or -pedantic. However, VLAs as they're expressed in C have been considered by WG21 and rejected, are easy to use accidentally to the surprise of users (e.g., https://ddanilov.me/default-non-standard-features/), and they have potential security implications beyond constant-size arrays (https://wiki.sei.cmu.edu/confluence/display/c/ARR32-C.+Ensure+size+arguments+for+variable+length+arrays+are+in+a+valid+range). C++ users should strongly consider using other functionality such as std::vector instead. This seems like sufficiently compelling evidence to warn users about VLA use by default in C++ modes. This patch enables the -Wvla-extension diagnostic group in C++ language modes by default, and adds the warning group to -Wall in GNU++ language modes. The warning is still opt-in in C language modes, where support for VLAs is somewhat less surprising to users. RFC: https://discourse.llvm.org/t/rfc-diagnosing-use-of-vlas-in-c/73109 Fixes https://github.com/llvm/llvm-project/issues/62836 Differential Revision: https://reviews.llvm.org/D156565
136 lines
10 KiB
C
136 lines
10 KiB
C
// RUN: %clang_cc1 -fsyntax-only -verify=expected,conly -triple wasm32 -Wno-unused-value -target-feature +reference-types %s
|
|
// RUN: %clang_cc1 -x c++ -std=c++17 -fsyntax-only -verify=expected,cpp -triple wasm32 -Wno-unused-value -target-feature +reference-types %s
|
|
|
|
// Note: As WebAssembly references are sizeless types, we don't exhaustively
|
|
// test for cases covered by sizeless-1.c and similar tests.
|
|
|
|
// Unlike standard sizeless types, reftype globals are supported.
|
|
__externref_t r1;
|
|
extern __externref_t r2;
|
|
static __externref_t r3;
|
|
|
|
__externref_t *t1; // expected-error {{pointer to WebAssembly reference type is not allowed}}
|
|
__externref_t **t2; // expected-error {{pointer to WebAssembly reference type is not allowed}}
|
|
__externref_t ******t3; // expected-error {{pointer to WebAssembly reference type is not allowed}}
|
|
static __externref_t t4[3]; // expected-error {{only zero-length WebAssembly tables are currently supported}}
|
|
static __externref_t t5[]; // expected-error {{only zero-length WebAssembly tables are currently supported}}
|
|
static __externref_t t6[] = {0}; // expected-error {{only zero-length WebAssembly tables are currently supported}}
|
|
__externref_t t7[0]; // expected-error {{WebAssembly table must be static}}
|
|
static __externref_t t8[0][0]; // expected-error {{multi-dimensional arrays of WebAssembly references are not allowed}}
|
|
static __externref_t (*t9)[0]; // expected-error {{cannot form a pointer to a WebAssembly table}}
|
|
|
|
static __externref_t table[0];
|
|
static __externref_t other_table[0] = {};
|
|
static __externref_t another_table[] = {}; // expected-error {{only zero-length WebAssembly tables are currently supported}}
|
|
|
|
struct s {
|
|
__externref_t f1; // expected-error {{field has sizeless type '__externref_t'}}
|
|
__externref_t f2[0]; // expected-error {{field has sizeless type '__externref_t'}}
|
|
__externref_t f3[]; // expected-error {{field has sizeless type '__externref_t'}}
|
|
__externref_t f4[0][0]; // expected-error {{multi-dimensional arrays of WebAssembly references are not allowed}}
|
|
__externref_t *f5; // expected-error {{pointer to WebAssembly reference type is not allowed}}
|
|
__externref_t ****f6; // expected-error {{pointer to WebAssembly reference type is not allowed}}
|
|
__externref_t (*f7)[0]; // expected-error {{cannot form a pointer to a WebAssembly table}}
|
|
};
|
|
|
|
union u {
|
|
__externref_t f1; // expected-error {{field has sizeless type '__externref_t'}}
|
|
__externref_t f2[0]; // expected-error {{field has sizeless type '__externref_t'}}
|
|
__externref_t f3[]; // expected-error {{field has sizeless type '__externref_t'}}
|
|
__externref_t f4[0][0]; // expected-error {{multi-dimensional arrays of WebAssembly references are not allowed}}
|
|
__externref_t *f5; // expected-error {{pointer to WebAssembly reference type is not allowed}}
|
|
__externref_t ****f6; // expected-error {{pointer to WebAssembly reference type is not allowed}}
|
|
__externref_t (*f7)[0]; // expected-error {{cannot form a pointer to a WebAssembly table}}
|
|
};
|
|
|
|
void illegal_argument_1(__externref_t table[]); // expected-error {{cannot use WebAssembly table as a function parameter}}
|
|
void illegal_argument_2(__externref_t table[0][0]); // expected-error {{multi-dimensional arrays of WebAssembly references are not allowed}}
|
|
void illegal_argument_3(__externref_t *table); // expected-error {{pointer to WebAssembly reference type is not allowed}}
|
|
void illegal_argument_4(__externref_t ***table); // expected-error {{pointer to WebAssembly reference type is not allowed}}
|
|
void illegal_argument_5(__externref_t (*table)[0]); // expected-error {{cannot form a pointer to a WebAssembly table}}
|
|
void illegal_argument_6(__externref_t table[0]); // expected-error {{cannot use WebAssembly table as a function parameter}}
|
|
|
|
__externref_t *illegal_return_1(); // expected-error {{pointer to WebAssembly reference type is not allowed}}
|
|
__externref_t ***illegal_return_2(); // expected-error {{pointer to WebAssembly reference type is not allowed}}
|
|
__externref_t (*illegal_return_3())[0]; // expected-error {{cannot form a pointer to a WebAssembly table}}
|
|
|
|
void varargs(int, ...);
|
|
typedef void (*__funcref funcref_t)();
|
|
typedef void (*__funcref __funcref funcref_fail_t)(); // expected-warning {{attribute '__funcref' is already applied}}
|
|
|
|
__externref_t func(__externref_t ref) {
|
|
&ref; // expected-error {{cannot take address of WebAssembly reference}}
|
|
int foo = 40;
|
|
(__externref_t *)(&foo); // expected-error {{pointer to WebAssembly reference type is not allowed}}
|
|
(__externref_t ****)(&foo); // expected-error {{pointer to WebAssembly reference type is not allowed}}
|
|
sizeof(ref); // expected-error {{invalid application of 'sizeof' to sizeless type '__externref_t'}}
|
|
sizeof(__externref_t); // expected-error {{invalid application of 'sizeof' to sizeless type '__externref_t'}}
|
|
sizeof(__externref_t[0]); // expected-error {{invalid application of 'sizeof' to WebAssembly table}}
|
|
sizeof(table); // expected-error {{invalid application of 'sizeof' to WebAssembly table}}
|
|
sizeof(__externref_t[0][0]); // expected-error {{multi-dimensional arrays of WebAssembly references are not allowed}}
|
|
sizeof(__externref_t *); // expected-error {{pointer to WebAssembly reference type is not allowed}}
|
|
sizeof(__externref_t ***); // expected-error {{pointer to WebAssembly reference type is not allowed}};
|
|
// expected-warning@+1 {{'_Alignof' applied to an expression is a GNU extension}}
|
|
_Alignof(ref); // expected-error {{invalid application of 'alignof' to sizeless type '__externref_t'}}
|
|
_Alignof(__externref_t); // expected-error {{invalid application of 'alignof' to sizeless type '__externref_t'}}
|
|
_Alignof(__externref_t[]); // expected-error {{invalid application of 'alignof' to sizeless type '__externref_t'}}
|
|
_Alignof(__externref_t[0]); // expected-error {{invalid application of 'alignof' to sizeless type '__externref_t'}}
|
|
_Alignof(table); // expected-warning {{'_Alignof' applied to an expression is a GNU extension}} expected-error {{invalid application of 'alignof' to WebAssembly table}}
|
|
_Alignof(__externref_t[0][0]); // expected-error {{multi-dimensional arrays of WebAssembly references are not allowed}}
|
|
_Alignof(__externref_t *); // expected-error {{pointer to WebAssembly reference type is not allowed}}
|
|
_Alignof(__externref_t ***); // expected-error {{pointer to WebAssembly reference type is not allowed}};
|
|
varargs(1, ref); // expected-error {{cannot pass expression of type '__externref_t' to variadic function}}
|
|
|
|
__externref_t lt1[0]; // expected-error {{WebAssembly table cannot be declared within a function}}
|
|
static __externref_t lt2[0]; // expected-error {{WebAssembly table cannot be declared within a function}}
|
|
static __externref_t lt3[0][0]; // expected-error {{multi-dimensional arrays of WebAssembly references are not allowed}}
|
|
static __externref_t(*lt4)[0]; // expected-error {{cannot form a pointer to a WebAssembly table}}
|
|
// conly-error@+2 {{cannot use WebAssembly table as a function parameter}}
|
|
// cpp-error@+1 {{no matching function for call to 'illegal_argument_1'}}
|
|
illegal_argument_1(table);
|
|
varargs(1, table); // expected-error {{cannot use WebAssembly table as a function parameter}}
|
|
table == 1; // expected-error {{invalid operands to binary expression ('__attribute__((address_space(1))) __externref_t[0]' and 'int')}}
|
|
1 >= table; // expected-error {{invalid operands to binary expression ('int' and '__attribute__((address_space(1))) __externref_t[0]')}}
|
|
table == other_table; // expected-error {{invalid operands to binary expression ('__attribute__((address_space(1))) __externref_t[0]' and '__attribute__((address_space(1))) __externref_t[0]')}}
|
|
table !=- table; // expected-error {{invalid argument type '__attribute__((address_space(1))) __externref_t *' to unary expression}}
|
|
!table; // expected-error {{invalid argument type '__attribute__((address_space(1))) __externref_t *' to unary expression}}
|
|
1 && table; // expected-error {{invalid operands to binary expression ('int' and '__attribute__((address_space(1))) __externref_t[0]')}}
|
|
table || 1; // expected-error {{invalid operands to binary expression ('__attribute__((address_space(1))) __externref_t[0]' and 'int')}}
|
|
1 ? table : table; // expected-error {{cannot use a WebAssembly table within a branch of a conditional expression}}
|
|
table ? : other_table; // expected-error {{cannot use a WebAssembly table within a branch of a conditional expression}}
|
|
(void *)table; // expected-error {{cannot cast from a WebAssembly table}}
|
|
void *u;
|
|
u = table; // expected-error {{cannot assign a WebAssembly table}}
|
|
void *v = table; // expected-error {{cannot assign a WebAssembly table}}
|
|
&table; // expected-error {{cannot form a reference to a WebAssembly table}}
|
|
(void)table;
|
|
|
|
table[0]; // expected-error {{cannot subscript a WebAssembly table}}
|
|
table[0] = ref; // expected-error {{cannot subscript a WebAssembly table}}
|
|
|
|
int i = 0; // cpp-note {{declared here}}
|
|
__externref_t oh_no_vlas[i]; // expected-error {{WebAssembly table cannot be declared within a function}} \
|
|
cpp-warning {{variable length arrays in C++ are a Clang extension}} \
|
|
cpp-note {{read of non-const variable 'i' is not allowed in a constant expression}}
|
|
|
|
return ref;
|
|
}
|
|
|
|
void foo() {
|
|
static __externref_t t[0]; // expected-error {{WebAssembly table cannot be declared within a function}}
|
|
{
|
|
static __externref_t t2[0]; // expected-error {{WebAssembly table cannot be declared within a function}}
|
|
for (;;) {
|
|
static __externref_t t3[0]; // expected-error {{WebAssembly table cannot be declared within a function}}
|
|
}
|
|
}
|
|
int i = ({
|
|
static __externref_t t4[0]; // expected-error {{WebAssembly table cannot be declared within a function}}
|
|
1;
|
|
});
|
|
}
|
|
|
|
void *ret_void_ptr() {
|
|
return table; // expected-error {{cannot return a WebAssembly table}}
|
|
}
|