mirror of
https://github.com/llvm/llvm-project.git
synced 2025-04-27 11:46:07 +00:00

This patch removes all of the Set.* methods from Status. This cleanup is part of a series of patches that make it harder use the anti-pattern of keeping a long-lives Status object around and updating it while dropping any errors it contains on the floor. This patch is largely NFC, the more interesting next steps this enables is to: 1. remove Status.Clear() 2. assert that Status::operator=() never overwrites an error 3. remove Status::operator=() Note that step (2) will bring 90% of the benefits for users, and step (3) will dramatically clean up the error handling code in various places. In the end my goal is to convert all APIs that are of the form ` ResultTy DoFoo(Status& error) ` to ` llvm::Expected<ResultTy> DoFoo() ` How to read this patch? The interesting changes are in Status.h and Status.cpp, all other changes are mostly ` perl -pi -e 's/\.SetErrorString/ = Status::FromErrorString/g' $(git grep -l SetErrorString lldb/source) ` plus the occasional manual cleanup.
144 lines
4.2 KiB
C++
144 lines
4.2 KiB
C++
//===-- OptionValueString.cpp ---------------------------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "lldb/Interpreter/OptionValueString.h"
|
|
|
|
#include "lldb/Host/OptionParser.h"
|
|
#include "lldb/Utility/Args.h"
|
|
#include "lldb/Utility/Stream.h"
|
|
|
|
using namespace lldb;
|
|
using namespace lldb_private;
|
|
|
|
void OptionValueString::DumpValue(const ExecutionContext *exe_ctx, Stream &strm,
|
|
uint32_t dump_mask) {
|
|
if (dump_mask & eDumpOptionType)
|
|
strm.Printf("(%s)", GetTypeAsCString());
|
|
if (dump_mask & eDumpOptionValue) {
|
|
if (dump_mask & eDumpOptionType)
|
|
strm.PutCString(" = ");
|
|
if (!m_current_value.empty() || m_value_was_set) {
|
|
if (m_options.Test(eOptionEncodeCharacterEscapeSequences)) {
|
|
std::string expanded_escape_value;
|
|
Args::ExpandEscapedCharacters(m_current_value.c_str(),
|
|
expanded_escape_value);
|
|
if (dump_mask & eDumpOptionRaw)
|
|
strm.Printf("%s", expanded_escape_value.c_str());
|
|
else
|
|
strm.Printf("\"%s\"", expanded_escape_value.c_str());
|
|
} else {
|
|
if (dump_mask & eDumpOptionRaw)
|
|
strm.Printf("%s", m_current_value.c_str());
|
|
else
|
|
strm.Printf("\"%s\"", m_current_value.c_str());
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
Status OptionValueString::SetValueFromString(llvm::StringRef value,
|
|
VarSetOperationType op) {
|
|
Status error;
|
|
|
|
std::string value_str = value.str();
|
|
value = value.trim();
|
|
if (value.size() > 0) {
|
|
switch (value.front()) {
|
|
case '"':
|
|
case '\'': {
|
|
if (value.size() <= 1 || value.back() != value.front()) {
|
|
error = Status::FromErrorString("mismatched quotes");
|
|
return error;
|
|
}
|
|
value = value.drop_front().drop_back();
|
|
} break;
|
|
}
|
|
value_str = value.str();
|
|
}
|
|
|
|
switch (op) {
|
|
case eVarSetOperationInvalid:
|
|
case eVarSetOperationInsertBefore:
|
|
case eVarSetOperationInsertAfter:
|
|
case eVarSetOperationRemove:
|
|
if (m_validator) {
|
|
error = m_validator(value_str.c_str(), m_validator_baton);
|
|
if (error.Fail())
|
|
return error;
|
|
}
|
|
error = OptionValue::SetValueFromString(value, op);
|
|
break;
|
|
|
|
case eVarSetOperationAppend: {
|
|
std::string new_value(m_current_value);
|
|
if (value.size() > 0) {
|
|
if (m_options.Test(eOptionEncodeCharacterEscapeSequences)) {
|
|
std::string str;
|
|
Args::EncodeEscapeSequences(value_str.c_str(), str);
|
|
new_value.append(str);
|
|
} else
|
|
new_value.append(std::string(value));
|
|
}
|
|
if (m_validator) {
|
|
error = m_validator(new_value.c_str(), m_validator_baton);
|
|
if (error.Fail())
|
|
return error;
|
|
}
|
|
m_current_value.assign(new_value);
|
|
NotifyValueChanged();
|
|
} break;
|
|
|
|
case eVarSetOperationClear:
|
|
Clear();
|
|
NotifyValueChanged();
|
|
break;
|
|
|
|
case eVarSetOperationReplace:
|
|
case eVarSetOperationAssign:
|
|
if (m_validator) {
|
|
error = m_validator(value_str.c_str(), m_validator_baton);
|
|
if (error.Fail())
|
|
return error;
|
|
}
|
|
m_value_was_set = true;
|
|
if (m_options.Test(eOptionEncodeCharacterEscapeSequences)) {
|
|
Args::EncodeEscapeSequences(value_str.c_str(), m_current_value);
|
|
} else {
|
|
SetCurrentValue(value_str);
|
|
}
|
|
NotifyValueChanged();
|
|
break;
|
|
}
|
|
return error;
|
|
}
|
|
|
|
Status OptionValueString::SetCurrentValue(llvm::StringRef value) {
|
|
if (m_validator) {
|
|
Status error(m_validator(value.str().c_str(), m_validator_baton));
|
|
if (error.Fail())
|
|
return error;
|
|
}
|
|
m_current_value.assign(std::string(value));
|
|
return Status();
|
|
}
|
|
|
|
Status OptionValueString::AppendToCurrentValue(const char *value) {
|
|
if (value && value[0]) {
|
|
if (m_validator) {
|
|
std::string new_value(m_current_value);
|
|
new_value.append(value);
|
|
Status error(m_validator(value, m_validator_baton));
|
|
if (error.Fail())
|
|
return error;
|
|
m_current_value.assign(new_value);
|
|
} else
|
|
m_current_value.append(value);
|
|
}
|
|
return Status();
|
|
}
|