mirror of
https://github.com/llvm/llvm-project.git
synced 2025-04-25 22:16:05 +00:00
0f1c1be196
We have a new policy in place making links to private resources something we try to avoid in source and test files. Normally, we'd organically switch to the new policy rather than make a sweeping change across a project. However, Clang is in a somewhat special circumstance currently: recently, I've had several new contributors run into rdar links around test code which their patch was changing the behavior of. This turns out to be a surprisingly bad experience, especially for newer folks, for a handful of reasons: not understanding what the link is and feeling intimidated by it, wondering whether their changes are actually breaking something important to a downstream in some way, having to hunt down strangers not involved with the patch to impose on them for help, accidental pressure from asking for potentially private IP to be made public, etc. Because folks run into these links entirely by chance (through fixing bugs or working on new features), there's not really a set of problematic links to focus on -- all of the links have basically the same potential for causing these problems. As a result, this is an omnibus patch to remove all such links. This was not a mechanical change; it was done by manually searching for rdar, radar, radr, and other variants to find all the various problematic links. From there, I tried to retain or reword the surrounding comments so that we would lose as little context as possible. However, because most links were just a plain link with no supporting context, the majority of the changes are simple removals. Differential Review: https://reviews.llvm.org/D158071
248 lines
11 KiB
C
248 lines
11 KiB
C
// RUN: %clang_cc1 -fsyntax-only -fno-diagnostics-show-line-numbers %s 2>&1 | FileCheck %s -strict-whitespace
|
|
|
|
#define M1(x) x
|
|
#define M2 1;
|
|
void foo(void) {
|
|
M1(
|
|
M2);
|
|
// CHECK: {{.*}}:7:{{[0-9]+}}: warning: expression result unused
|
|
// CHECK: {{.*}}:4:{{[0-9]+}}: note: expanded from macro 'M2'
|
|
// CHECK: {{.*}}:3:{{[0-9]+}}: note: expanded from macro 'M1'
|
|
}
|
|
|
|
#define A(x) x
|
|
#define B(x) A(x)
|
|
#define C(x) B(x)
|
|
void bar(void) {
|
|
C(1);
|
|
// CHECK: {{.*}}:17:5: warning: expression result unused
|
|
}
|
|
|
|
#define sprintf(str, A, B) \
|
|
__builtin___sprintf_chk (str, 0, 42, A, B)
|
|
|
|
void baz(char *Msg) {
|
|
sprintf(Msg, " sizeof FoooLib : =%3u\n", 12LL);
|
|
}
|
|
|
|
|
|
// PR9279: comprehensive tests for multi-level macro back traces
|
|
#define macro_args1(x) x
|
|
#define macro_args2(x) macro_args1(x)
|
|
#define macro_args3(x) macro_args2(x)
|
|
|
|
#define macro_many_args1(x, y, z) y
|
|
#define macro_many_args2(x, y, z) macro_many_args1(x, y, z)
|
|
#define macro_many_args3(x, y, z) macro_many_args2(x, y, z)
|
|
|
|
void test(void) {
|
|
macro_args3(11);
|
|
// CHECK: {{.*}}:39:15: warning: expression result unused
|
|
// Also check that the 'caret' printing agrees with the location here where
|
|
// its easy to FileCheck.
|
|
// CHECK-NEXT: macro_args3(11);
|
|
// CHECK-NEXT: {{^ \^~}}
|
|
|
|
macro_many_args3(
|
|
1,
|
|
2,
|
|
3);
|
|
// CHECK: {{.*}}:48:5: warning: expression result unused
|
|
// CHECK: {{.*}}:36:55: note: expanded from macro 'macro_many_args3'
|
|
// CHECK: {{.*}}:35:55: note: expanded from macro 'macro_many_args2'
|
|
// CHECK: {{.*}}:34:35: note: expanded from macro 'macro_many_args1'
|
|
|
|
macro_many_args3(
|
|
1,
|
|
M2,
|
|
3);
|
|
// CHECK: {{.*}}:57:5: warning: expression result unused
|
|
// CHECK: {{.*}}:4:12: note: expanded from macro 'M2'
|
|
// CHECK: {{.*}}:36:55: note: expanded from macro 'macro_many_args3'
|
|
// CHECK: {{.*}}:35:55: note: expanded from macro 'macro_many_args2'
|
|
// CHECK: {{.*}}:34:35: note: expanded from macro 'macro_many_args1'
|
|
|
|
macro_many_args3(
|
|
1,
|
|
macro_args2(22),
|
|
3);
|
|
// CHECK: {{.*}}:67:17: warning: expression result unused
|
|
// This caret location needs to be printed *inside* a different macro's
|
|
// arguments.
|
|
// CHECK-NEXT: macro_args2(22),
|
|
// CHECK-NEXT: {{^ \^~}}
|
|
// CHECK: {{.*}}:31:36: note: expanded from macro 'macro_args2'
|
|
// CHECK: {{.*}}:30:24: note: expanded from macro 'macro_args1'
|
|
// CHECK: {{.*}}:36:55: note: expanded from macro 'macro_many_args3'
|
|
// CHECK: {{.*}}:35:55: note: expanded from macro 'macro_many_args2'
|
|
// CHECK: {{.*}}:34:35: note: expanded from macro 'macro_many_args1'
|
|
}
|
|
|
|
#define variadic_args1(x, y, ...) y
|
|
#define variadic_args2(x, ...) variadic_args1(x, __VA_ARGS__)
|
|
#define variadic_args3(x, y, ...) variadic_args2(x, y, __VA_ARGS__)
|
|
|
|
void test2(void) {
|
|
variadic_args3(1, 22, 3, 4);
|
|
// CHECK: {{.*}}:86:21: warning: expression result unused
|
|
// CHECK-NEXT: variadic_args3(1, 22, 3, 4);
|
|
// CHECK-NEXT: {{^ \^~}}
|
|
// CHECK: {{.*}}:83:53: note: expanded from macro 'variadic_args3'
|
|
// CHECK: {{.*}}:82:50: note: expanded from macro 'variadic_args2'
|
|
// CHECK: {{.*}}:81:35: note: expanded from macro 'variadic_args1'
|
|
}
|
|
|
|
#define variadic_pasting_args1(x, y, z) y
|
|
#define variadic_pasting_args2(x, ...) variadic_pasting_args1(x ## __VA_ARGS__)
|
|
#define variadic_pasting_args2a(x, y, ...) variadic_pasting_args1(x, y ## __VA_ARGS__)
|
|
#define variadic_pasting_args3(x, y, ...) variadic_pasting_args2(x, y, __VA_ARGS__)
|
|
#define variadic_pasting_args3a(x, y, ...) variadic_pasting_args2a(x, y, __VA_ARGS__)
|
|
|
|
void test3(void) {
|
|
variadic_pasting_args3(1, 2, 3, 4);
|
|
// CHECK: {{.*}}:102:32: warning: expression result unused
|
|
// CHECK: {{.*}}:98:72: note: expanded from macro 'variadic_pasting_args3'
|
|
// CHECK: {{.*}}:96:68: note: expanded from macro 'variadic_pasting_args2'
|
|
// CHECK: {{.*}}:95:41: note: expanded from macro 'variadic_pasting_args1'
|
|
|
|
variadic_pasting_args3a(1, 2, 3, 4);
|
|
// CHECK: {{.*}}:108:3: warning: expression result unused
|
|
// CHECK-NEXT: variadic_pasting_args3a(1, 2, 3, 4);
|
|
// CHECK-NEXT: {{ \^~~~~~~~~~~~~~~~~~~~~~~}}
|
|
// CHECK: {{.*}}:99:44: note: expanded from macro 'variadic_pasting_args3a'
|
|
// CHECK-NEXT: #define variadic_pasting_args3a(x, y, ...) variadic_pasting_args2a(x, y, __VA_ARGS__)
|
|
// CHECK-NEXT: {{ \^~~~~~~~~~~~~~~~~~~~~~~}}
|
|
// CHECK: {{.*}}:97:70: note: expanded from macro 'variadic_pasting_args2a'
|
|
// CHECK-NEXT: #define variadic_pasting_args2a(x, y, ...) variadic_pasting_args1(x, y ## __VA_ARGS__)
|
|
// CHECK-NEXT: {{ \^~~~~~~~~~~~~~~~}}
|
|
// CHECK: {{.*}}:95:41: note: expanded from macro 'variadic_pasting_args1'
|
|
// CHECK-NEXT: #define variadic_pasting_args1(x, y, z) y
|
|
// CHECK-NEXT: {{ \^}}
|
|
}
|
|
|
|
#define BAD_CONDITIONAL_OPERATOR (2<3)?2:3
|
|
int test4 = BAD_CONDITIONAL_OPERATOR+BAD_CONDITIONAL_OPERATOR;
|
|
// CHECK: {{.*}}:123:39: note: expanded from macro 'BAD_CONDITIONAL_OPERATOR'
|
|
// CHECK-NEXT: #define BAD_CONDITIONAL_OPERATOR (2<3)?2:3
|
|
// CHECK-NEXT: {{^ \^}}
|
|
// CHECK: {{.*}}:123:39: note: expanded from macro 'BAD_CONDITIONAL_OPERATOR'
|
|
// CHECK-NEXT: #define BAD_CONDITIONAL_OPERATOR (2<3)?2:3
|
|
// CHECK-NEXT: {{^ \^}}
|
|
// CHECK: {{.*}}:123:39: note: expanded from macro 'BAD_CONDITIONAL_OPERATOR'
|
|
// CHECK-NEXT: #define BAD_CONDITIONAL_OPERATOR (2<3)?2:3
|
|
// CHECK-NEXT: {{^ ~~~~~\^~~~}}
|
|
|
|
#define QMARK ?
|
|
#define TWOL (2<
|
|
#define X 1+TWOL 3) QMARK 4:5
|
|
int x = X;
|
|
// CHECK: {{.*}}:138:9: note: place parentheses around the '+' expression to silence this warning
|
|
// CHECK-NEXT: int x = X;
|
|
// CHECK-NEXT: {{^ \^}}
|
|
// CHECK-NEXT: {{.*}}:137:21: note: expanded from macro 'X'
|
|
// CHECK-NEXT: #define X 1+TWOL 3) QMARK 4:5
|
|
// CHECK-NEXT: {{^ ~~~~~~~~~ \^}}
|
|
// CHECK-NEXT: {{.*}}:135:15: note: expanded from macro 'QMARK'
|
|
// CHECK-NEXT: #define QMARK ?
|
|
// CHECK-NEXT: {{^ \^}}
|
|
// CHECK-NEXT: {{.*}}:138:9: note: place parentheses around the '?:' expression to evaluate it first
|
|
// CHECK-NEXT: int x = X;
|
|
// CHECK-NEXT: {{^ \^}}
|
|
// CHECK-NEXT: {{.*}}:137:21: note: expanded from macro 'X'
|
|
// CHECK-NEXT: #define X 1+TWOL 3) QMARK 4:5
|
|
// CHECK-NEXT: {{^ ~~~~~~~~\^~~~~~~~~}}
|
|
|
|
#define ONEPLUS 1+
|
|
#define Y ONEPLUS (2<3) QMARK 4:5
|
|
int y = Y;
|
|
// CHECK: {{.*}}:157:9: warning: operator '?:' has lower precedence than '+'; '+' will be evaluated first
|
|
// CHECK-NEXT: int y = Y;
|
|
// CHECK-NEXT: {{^ \^}}
|
|
// CHECK-NEXT: {{.*}}:156:25: note: expanded from macro 'Y'
|
|
// CHECK-NEXT: #define Y ONEPLUS (2<3) QMARK 4:5
|
|
// CHECK-NEXT: {{^ ~~~~~~~~~~~~~ \^}}
|
|
// CHECK-NEXT: {{.*}}:135:15: note: expanded from macro 'QMARK'
|
|
// CHECK-NEXT: #define QMARK ?
|
|
// CHECK-NEXT: {{^ \^}}
|
|
|
|
// PR14399
|
|
void iequals(int,int,int);
|
|
void foo_aa(char* s)
|
|
{
|
|
#define /* */ BARC(c, /* */b, a) (a + b ? c : c)
|
|
iequals(__LINE__, BARC(123, (456 < 345), 789), 8);
|
|
}
|
|
// CHECK: {{.*}}:173:21: warning: operator '?:' has lower precedence than '+'
|
|
// CHECK-NEXT: iequals(__LINE__, BARC(123, (456 < 345), 789), 8);
|
|
// CHECK-NEXT: {{^ \^~~~~~~~~~~~~~~~~~~~~~~~~~~}}
|
|
// CHECK-NEXT: {{.*}}:172:41: note: expanded from macro 'BARC'
|
|
// CHECK-NEXT: #define /* */ BARC(c, /* */b, a) (a + b ? c : c)
|
|
// CHECK-NEXT: {{^ ~~~~~ \^}}
|
|
|
|
#define APPEND2(NUM, SUFF) -1 != NUM ## SUFF
|
|
#define APPEND(NUM, SUFF) APPEND2(NUM, SUFF)
|
|
#define UTARG_MAX_U APPEND (MAX_UINT, UL)
|
|
#define MAX_UINT 18446744073709551615
|
|
#if UTARG_MAX_U
|
|
#endif
|
|
|
|
// CHECK: {{.*}}:186:5: warning: left side of operator converted from negative value to unsigned: -1 to 18446744073709551615
|
|
// CHECK-NEXT: #if UTARG_MAX_U
|
|
// CHECK-NEXT: {{^ \^~~~~~~~~~~}}
|
|
// CHECK-NEXT: {{.*}}:184:21: note: expanded from macro 'UTARG_MAX_U'
|
|
// CHECK-NEXT: #define UTARG_MAX_U APPEND (MAX_UINT, UL)
|
|
// CHECK-NEXT: {{^ \^~~~~~~~~~~~~~~~~~~~~}}
|
|
// CHECK-NEXT: {{.*}}:183:27: note: expanded from macro 'APPEND'
|
|
// CHECK-NEXT: #define APPEND(NUM, SUFF) APPEND2(NUM, SUFF)
|
|
// CHECK-NEXT: {{^ \^~~~~~~~~~~~~~~~~~}}
|
|
// CHECK-NEXT: {{.*}}:182:31: note: expanded from macro 'APPEND2'
|
|
// CHECK-NEXT: #define APPEND2(NUM, SUFF) -1 != NUM ## SUFF
|
|
// CHECK-NEXT: {{^ ~~ \^ ~~~~~~~~~~~}}
|
|
|
|
unsigned long strlen_test(const char *s);
|
|
#define __darwin_obsz(object) __builtin_object_size (object, 1)
|
|
#define sprintf2(str, ...) \
|
|
__builtin___sprintf_chk (str, 0, __darwin_obsz(str), __VA_ARGS__)
|
|
#define Cstrlen(a) strlen_test(a)
|
|
#define Csprintf sprintf2
|
|
void f(char* pMsgBuf, char* pKeepBuf) {
|
|
Csprintf(pMsgBuf,"\nEnter minimum anagram length (2-%1d): ", strlen_test(pKeepBuf));
|
|
// FIXME: Change test to use 'Cstrlen' instead of 'strlen_test' when macro printing is fixed.
|
|
}
|
|
// CHECK: {{.*}}:209:62: warning: format specifies type 'int' but the argument has type 'unsigned long'
|
|
// CHECK-NEXT: Csprintf(pMsgBuf,"\nEnter minimum anagram length (2-%1d): ", strlen_test(pKeepBuf));
|
|
// CHECK-NEXT: {{^ ~~~ \^~~~~~~~~~~~~~~~~~~~~}}
|
|
// CHECK-NEXT: {{^ %1lu}}
|
|
// CHECK-NEXT: {{.*}}:207:21: note: expanded from macro 'Csprintf'
|
|
// CHECK-NEXT: #define Csprintf sprintf2
|
|
// CHECK-NEXT: {{^ \^}}
|
|
// CHECK-NEXT: {{.*}}:205:56: note: expanded from macro 'sprintf2'
|
|
// CHECK-NEXT: __builtin___sprintf_chk (str, 0, __darwin_obsz(str), __VA_ARGS__)
|
|
// CHECK-NEXT: {{^ \^~~~~~~~~~~}}
|
|
|
|
#define SWAP_AND_APPLY(arg, macro) macro arg
|
|
#define APPLY(macro, arg) macro arg
|
|
#define DECLARE_HELPER() __builtin_printf("%d\n", mylong);
|
|
void use_evil_macros(long mylong) {
|
|
SWAP_AND_APPLY((), DECLARE_HELPER)
|
|
APPLY(DECLARE_HELPER, ())
|
|
}
|
|
// CHECK: {{.*}}:227:22: warning: format specifies type 'int' but the argument has type 'long'
|
|
// CHECK-NEXT: SWAP_AND_APPLY((), DECLARE_HELPER)
|
|
// CHECK-NEXT: ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~
|
|
// CHECK-NEXT: {{.*}}:223:36: note: expanded from macro 'SWAP_AND_APPLY'
|
|
// CHECK-NEXT: #define SWAP_AND_APPLY(arg, macro) macro arg
|
|
// CHECK-NEXT: ^~~~~~~~~
|
|
// CHECK-NEXT: {{.*}}:225:51: note: expanded from macro 'DECLARE_HELPER'
|
|
// CHECK-NEXT: #define DECLARE_HELPER() __builtin_printf("%d\n", mylong);
|
|
// CHECK-NEXT: ~~ ^~~~~~
|
|
// CHECK-NEXT: {{.*}}:228:9: warning: format specifies type 'int' but the argument has type 'long'
|
|
// CHECK-NEXT: APPLY(DECLARE_HELPER, ())
|
|
// CHECK-NEXT: ~~~~~~^~~~~~~~~~~~~~~~~~~
|
|
// CHECK-NEXT: {{.*}}:224:27: note: expanded from macro 'APPLY'
|
|
// CHECK-NEXT: #define APPLY(macro, arg) macro arg
|
|
// CHECK-NEXT: ^~~~~~~~~
|
|
// CHECK-NEXT: {{.*}}:225:51: note: expanded from macro 'DECLARE_HELPER'
|
|
// CHECK-NEXT: #define DECLARE_HELPER() __builtin_printf("%d\n", mylong);
|
|
// CHECK-NEXT: ~~ ^~~~~~
|