mirror of
https://github.com/llvm/llvm-project.git
synced 2025-04-29 07:06:06 +00:00
b3510c4254
Summary:
Make completion behave consistently no matter if it is run at the
start, in the middle or at the end of an identifier that happens to
be a keyword or a macro name. Since completion is often ran on
incomplete identifiers, they may turn into keywords by accident.
For example, we should produce same results for all of these
completion points:
// ^ is completion point.
^class
cla^ss
class^
Previously clang produced different results for the last case (as if
the completion point was after a space: `class ^`).
This change also updates some offsets in tests that (unintentionally?)
relied on the old behavior.
Reviewers: sammccall, bkramer, arphaman, aaron.ballman
Reviewed By: sammccall
Subscribers: cfe-commits
Differential Revision: https://reviews.llvm.org/D45887
llvm-svn: 330717
16 lines
600 B
C++
16 lines
600 B
C++
#define FUNC(X) X
|
|
#define FUNCTOR
|
|
using FUNCTION = int();
|
|
// We should get all three completions when the cursor is at the beginning,
|
|
// middle, or end.
|
|
FUNC(int) a = 10;
|
|
// ^FUNC(int)
|
|
// RUN: %clang_cc1 -code-completion-at=%s:6:1 -code-completion-macros %s | FileCheck %s
|
|
// FU^NC(int)
|
|
// RUN: %clang_cc1 -code-completion-at=%s:6:3 -code-completion-macros %s | FileCheck %s
|
|
// FUNC^(int)
|
|
// RUN: %clang_cc1 -code-completion-at=%s:6:5 -code-completion-macros %s | FileCheck %s
|
|
|
|
// CHECK: COMPLETION: FUNC : FUNC(<#X#>)
|
|
// CHECK: COMPLETION: FUNCTION : FUNCTION
|
|
// CHECK: COMPLETION: FUNCTOR : FUNCTOR
|