mirror of
https://github.com/llvm/llvm-project.git
synced 2025-04-30 04:36:09 +00:00
b7586afc4d
There are 2 reasons to remove strcasecmp and strncasecmp. 1) They are also modeled in CStringChecker and the related argumentum contraints are checked there. 2) The argument constraints are checked in CStringChecker::evalCall. This is fundamentally flawed, they should be checked in checkPreCall. Even if we set up CStringChecker as a weak dependency for StdLibraryFunctionsChecker then the latter reports the warning always. Besides, CStringChecker fails to discover the constraint violation before the call, so, its evalCall returns with `true` and then StdCLibraryFunctions also tries to evaluate, this causes an assertion in CheckerManager. Either we fix CStringChecker to handle the call prerequisites in checkPreCall, or we must not evaluate any pure functions in StdCLibraryFunctions that are also handled in CStringChecker. We do the latter in this patch. Differential Revision: https://reviews.llvm.org/D87239
22 lines
948 B
C
22 lines
948 B
C
// This test case crashes if strncasecmp is modeled in StdCLibraryFunctions.
|
|
// Either we fix CStringChecker to handle the call prerequisites in
|
|
// checkPreCall, or we must not evaluate any pure functions in
|
|
// StdCLibraryFunctions that are also handled in CStringChecker.
|
|
|
|
// RUN: %clang_analyze_cc1 %s \
|
|
// RUN: -analyzer-checker=core \
|
|
// RUN: -analyzer-checker=apiModeling.StdCLibraryFunctions \
|
|
// RUN: -analyzer-checker=unix.cstring.NullArg \
|
|
// RUN: -analyzer-config apiModeling.StdCLibraryFunctions:ModelPOSIX=true \
|
|
// RUN: -analyzer-checker=alpha.unix.StdCLibraryFunctionArgs \
|
|
// RUN: -triple x86_64-unknown-linux-gnu \
|
|
// RUN: -verify
|
|
|
|
typedef __typeof(sizeof(int)) size_t;
|
|
int strncasecmp(const char *s1, const char *s2, size_t n);
|
|
|
|
int strncasecmp_null_argument(char *a, size_t n) {
|
|
char *b = 0;
|
|
return strncasecmp(a, b, n); // expected-warning{{Null pointer passed as 2nd argument to string comparison function}}
|
|
}
|