mirror of
https://github.com/llvm/llvm-project.git
synced 2025-05-02 21:06:04 +00:00

Consider this program: struct A { virtual void operator-() { printf("base\n"); } }; struct B final : public A { virtual void operator-() override { printf("derived\n"); } }; int main() { B* b = new B; -static_cast<A&>(*b); } Before this patch, clang saw the virtual call to A::operator-(), figured out that it can be devirtualized, and then just called A::operator-() directly, without going through the vtable. Instead, it should've looked up which operator-() the call devirtualizes to and should've called that. For regular virtual member calls, clang gets all this right already. So instead of giving EmitCXXOperatorMemberCallee() all the logic that EmitCXXMemberCallExpr() already has, cut the latter function into two pieces, call the second piece EmitCXXMemberOrOperatorMemberCallExpr(), and use it also to generate code for calls to virtual member operators. This way, virtual overloaded operators automatically don't get devirtualized if they have covariant returns (like it was done for regular calls in r218602), etc. This also happens to fix (or at least improve) codegen for explicit constructor calls (`A a; a.A::A()`) in MS mode with -fsanitize-address-field-padding=1. (This adjustment for virtual operator calls seems still wrong with the MS ABI.) llvm-svn: 223185
228 lines
4.8 KiB
C++
228 lines
4.8 KiB
C++
// RUN: %clang_cc1 -triple i386-unknown-unknown -std=c++11 %s -emit-llvm -o - | FileCheck %s
|
|
|
|
namespace Test1 {
|
|
struct A {
|
|
virtual int f() final;
|
|
};
|
|
|
|
// CHECK-LABEL: define i32 @_ZN5Test11fEPNS_1AE
|
|
int f(A *a) {
|
|
// CHECK: call i32 @_ZN5Test11A1fEv
|
|
return a->f();
|
|
}
|
|
}
|
|
|
|
namespace Test2 {
|
|
struct A final {
|
|
virtual int f();
|
|
};
|
|
|
|
// CHECK-LABEL: define i32 @_ZN5Test21fEPNS_1AE
|
|
int f(A *a) {
|
|
// CHECK: call i32 @_ZN5Test21A1fEv
|
|
return a->f();
|
|
}
|
|
}
|
|
|
|
namespace Test3 {
|
|
struct A {
|
|
virtual int f();
|
|
};
|
|
|
|
struct B final : A { };
|
|
|
|
// CHECK-LABEL: define i32 @_ZN5Test31fEPNS_1BE
|
|
int f(B *b) {
|
|
// CHECK: call i32 @_ZN5Test31A1fEv
|
|
return b->f();
|
|
}
|
|
|
|
// CHECK-LABEL: define i32 @_ZN5Test31fERNS_1BE
|
|
int f(B &b) {
|
|
// CHECK: call i32 @_ZN5Test31A1fEv
|
|
return b.f();
|
|
}
|
|
|
|
// CHECK-LABEL: define i32 @_ZN5Test31fEPv
|
|
int f(void *v) {
|
|
// CHECK: call i32 @_ZN5Test31A1fEv
|
|
return static_cast<B*>(v)->f();
|
|
}
|
|
}
|
|
|
|
namespace Test4 {
|
|
struct A {
|
|
virtual void f();
|
|
virtual int operator-();
|
|
};
|
|
|
|
struct B final : A {
|
|
virtual void f();
|
|
virtual int operator-();
|
|
};
|
|
|
|
// CHECK-LABEL: define void @_ZN5Test41fEPNS_1BE
|
|
void f(B* d) {
|
|
// CHECK: call void @_ZN5Test41B1fEv
|
|
static_cast<A*>(d)->f();
|
|
// CHECK: call i32 @_ZN5Test41BngEv
|
|
-static_cast<A&>(*d);
|
|
}
|
|
}
|
|
|
|
namespace Test5 {
|
|
struct A {
|
|
virtual void f();
|
|
virtual int operator-();
|
|
};
|
|
|
|
struct B : A {
|
|
virtual void f();
|
|
virtual int operator-();
|
|
};
|
|
|
|
struct C final : B {
|
|
};
|
|
|
|
// CHECK-LABEL: define void @_ZN5Test51fEPNS_1CE
|
|
void f(C* d) {
|
|
// FIXME: It should be possible to devirtualize this case, but that is
|
|
// not implemented yet.
|
|
// CHECK: getelementptr
|
|
// CHECK-NEXT: %[[FUNC:.*]] = load
|
|
// CHECK-NEXT: call void %[[FUNC]]
|
|
static_cast<A*>(d)->f();
|
|
}
|
|
// CHECK-LABEL: define void @_ZN5Test53fopEPNS_1CE
|
|
void fop(C* d) {
|
|
// FIXME: It should be possible to devirtualize this case, but that is
|
|
// not implemented yet.
|
|
// CHECK: getelementptr
|
|
// CHECK-NEXT: %[[FUNC:.*]] = load
|
|
// CHECK-NEXT: call i32 %[[FUNC]]
|
|
-static_cast<A&>(*d);
|
|
}
|
|
}
|
|
|
|
namespace Test6 {
|
|
struct A {
|
|
virtual ~A();
|
|
};
|
|
|
|
struct B : public A {
|
|
virtual ~B();
|
|
};
|
|
|
|
struct C {
|
|
virtual ~C();
|
|
};
|
|
|
|
struct D final : public C, public B {
|
|
};
|
|
|
|
// CHECK-LABEL: define void @_ZN5Test61fEPNS_1DE
|
|
void f(D* d) {
|
|
// CHECK: call void @_ZN5Test61DD1Ev
|
|
static_cast<A*>(d)->~A();
|
|
}
|
|
}
|
|
|
|
namespace Test7 {
|
|
struct foo {
|
|
virtual void g() {}
|
|
};
|
|
|
|
struct bar {
|
|
virtual int f() { return 0; }
|
|
};
|
|
|
|
struct zed final : public foo, public bar {
|
|
int z;
|
|
virtual int f() {return z;}
|
|
};
|
|
|
|
// CHECK-LABEL: define i32 @_ZN5Test71fEPNS_3zedE
|
|
int f(zed *z) {
|
|
// CHECK: alloca
|
|
// CHECK-NEXT: store
|
|
// CHECK-NEXT: load
|
|
// CHECK-NEXT: call i32 @_ZN5Test73zed1fEv
|
|
// CHECK-NEXT: ret
|
|
return static_cast<bar*>(z)->f();
|
|
}
|
|
}
|
|
|
|
namespace Test8 {
|
|
struct A { virtual ~A() {} };
|
|
struct B {
|
|
int b;
|
|
virtual int foo() { return b; }
|
|
};
|
|
struct C final : A, B { };
|
|
// CHECK-LABEL: define i32 @_ZN5Test84testEPNS_1CE
|
|
int test(C *c) {
|
|
// CHECK: %[[THIS:.*]] = phi
|
|
// CHECK-NEXT: call i32 @_ZN5Test81B3fooEv(%"struct.Test8::B"* %[[THIS]])
|
|
return static_cast<B*>(c)->foo();
|
|
}
|
|
}
|
|
|
|
namespace Test9 {
|
|
struct A {
|
|
int a;
|
|
};
|
|
struct B {
|
|
int b;
|
|
};
|
|
struct C : public B, public A {
|
|
};
|
|
struct RA {
|
|
virtual A *f() {
|
|
return 0;
|
|
}
|
|
virtual A *operator-() {
|
|
return 0;
|
|
}
|
|
};
|
|
struct RC final : public RA {
|
|
virtual C *f() {
|
|
C *x = new C();
|
|
x->a = 1;
|
|
x->b = 2;
|
|
return x;
|
|
}
|
|
virtual C *operator-() {
|
|
C *x = new C();
|
|
x->a = 1;
|
|
x->b = 2;
|
|
return x;
|
|
}
|
|
};
|
|
// CHECK: define {{.*}} @_ZN5Test91fEPNS_2RCE
|
|
A *f(RC *x) {
|
|
// FIXME: It should be possible to devirtualize this case, but that is
|
|
// not implemented yet.
|
|
// CHECK: load
|
|
// CHECK: bitcast
|
|
// CHECK: [[F_PTR_RA:%.+]] = bitcast
|
|
// CHECK: [[VTABLE:%.+]] = load {{.+}} [[F_PTR_RA]]
|
|
// CHECK: [[VFN:%.+]] = getelementptr inbounds {{.+}} [[VTABLE]], i{{[0-9]+}} 0
|
|
// CHECK-NEXT: %[[FUNC:.*]] = load {{.+}} [[VFN]]
|
|
// CHECK-NEXT: = call {{.*}} %[[FUNC]]
|
|
return static_cast<RA*>(x)->f();
|
|
}
|
|
// CHECK: define {{.*}} @_ZN5Test93fopEPNS_2RCE
|
|
A *fop(RC *x) {
|
|
// FIXME: It should be possible to devirtualize this case, but that is
|
|
// not implemented yet.
|
|
// CHECK: load
|
|
// CHECK: bitcast
|
|
// CHECK: [[F_PTR_RA:%.+]] = bitcast
|
|
// CHECK: [[VTABLE:%.+]] = load {{.+}} [[F_PTR_RA]]
|
|
// CHECK: [[VFN:%.+]] = getelementptr inbounds {{.+}} [[VTABLE]], i{{[0-9]+}} 1
|
|
// CHECK-NEXT: %[[FUNC:.*]] = load {{.+}} [[VFN]]
|
|
// CHECK-NEXT: = call {{.*}} %[[FUNC]]
|
|
return -static_cast<RA&>(*x);
|
|
}
|
|
}
|