mirror of
https://github.com/llvm/llvm-project.git
synced 2025-05-01 17:26:04 +00:00
aee4925507
Based on post-commit review discussion on 2bd84938470bf2e337801faafb8a67710f46429d with Richard Smith. Other uses of forcing HasEmptyPlaceHolder to false seem OK to me - they're all around pointer/reference types where the pointer/reference token will appear at the rightmost side of the left side of the type name, so they make nested types (eg: the "int" in "int *") behave as though there is a non-empty placeholder (because the "*" is essentially the placeholder as far as the "int" is concerned). This was originally committed in 277623f4d5a672d707390e2c3eaf30a9eb4b075c Reverted in f9ad1d1c775a8e264bebc15d75e0c6e5c20eefc7 due to breakages outside of clang - lldb seems to have some strange/strong dependence on "char [N]" versus "char[N]" when printing strings (not due to that name appearing in DWARF, but probably due to using clang to stringify type names) that'll need to be addressed, plus a few other odds and ends in other subprojects (clang-tools-extra, compiler-rt, etc).
59 lines
2.8 KiB
C++
59 lines
2.8 KiB
C++
// RUN: %clang_cc1 -fsyntax-only -verify %s
|
|
|
|
__attribute__((noreturn)) extern void bar();
|
|
|
|
int test_no_warn(int x) {
|
|
if (x) {
|
|
if (__builtin_expect_with_probability(1, 1, 1))
|
|
bar();
|
|
} else {
|
|
return 0;
|
|
}
|
|
} // should not emit warn "control may reach end of non-void function" here since expr is constantly true, so the "if(__bui..)" should be constantly true condition and be ignored
|
|
|
|
template <int b> void tempf() {
|
|
static_assert(b == 1, "should be evaluated as 1"); // should not have error here
|
|
}
|
|
|
|
constexpr int constf() {
|
|
return __builtin_expect_with_probability(1, 1, 1);
|
|
}
|
|
|
|
void foo() {
|
|
tempf<__builtin_expect_with_probability(1, 1, 1)>();
|
|
constexpr int f = constf();
|
|
static_assert(f == 1, "should be evaluated as 1"); // should not have error here
|
|
}
|
|
|
|
extern int global;
|
|
|
|
struct S {
|
|
static constexpr float prob = 0.7;
|
|
};
|
|
|
|
template<typename T>
|
|
void expect_taken(int x) {
|
|
if (__builtin_expect_with_probability(x > 0, 1, T::prob)) {
|
|
global++;
|
|
}
|
|
}
|
|
|
|
void test(int x, double p) { // expected-note {{declared here}}
|
|
bool dummy;
|
|
dummy = __builtin_expect_with_probability(x > 0, 1, 0.9);
|
|
dummy = __builtin_expect_with_probability(x > 0, 1, 1.1); // expected-error {{probability argument to __builtin_expect_with_probability is outside the range [0.0, 1.0]}}
|
|
dummy = __builtin_expect_with_probability(x > 0, 1, -1); // expected-error {{probability argument to __builtin_expect_with_probability is outside the range [0.0, 1.0]}}
|
|
dummy = __builtin_expect_with_probability(x > 0, 1, p); // expected-error {{probability argument to __builtin_expect_with_probability must be constant floating-point expression}} expected-note {{function parameter 'p'}}
|
|
dummy = __builtin_expect_with_probability(x > 0, 1, "aa"); // expected-error {{cannot initialize a parameter of type 'double' with an lvalue of type 'const char[3]'}}
|
|
dummy = __builtin_expect_with_probability(x > 0, 1, __builtin_nan("")); // expected-error {{probability argument to __builtin_expect_with_probability is outside the range [0.0, 1.0]}}
|
|
dummy = __builtin_expect_with_probability(x > 0, 1, __builtin_inf()); // expected-error {{probability argument to __builtin_expect_with_probability is outside the range [0.0, 1.0]}}
|
|
dummy = __builtin_expect_with_probability(x > 0, 1, -0.0);
|
|
dummy = __builtin_expect_with_probability(x > 0, 1, 1.0 + __DBL_EPSILON__); // expected-error {{probability argument to __builtin_expect_with_probability is outside the range [0.0, 1.0]}}
|
|
dummy = __builtin_expect_with_probability(x > 0, 1, -__DBL_DENORM_MIN__); // expected-error {{probability argument to __builtin_expect_with_probability is outside the range [0.0, 1.0]}}
|
|
constexpr double pd = 0.7;
|
|
dummy = __builtin_expect_with_probability(x > 0, 1, pd);
|
|
constexpr int pi = 1;
|
|
dummy = __builtin_expect_with_probability(x > 0, 1, pi);
|
|
expect_taken<S>(x);
|
|
}
|