mirror of
https://github.com/llvm/llvm-project.git
synced 2025-05-16 10:26:07 +00:00
f57351570e
along the way. Important changes: 1) To generate a sink node, use GenerateSink(); GenerateNode() is for generating regular transitions. This makes the API clearer and also allows us to use the 'bool' option to GenerateNode() for a different purpose. 2) GenerateNode() now automatically adds the generated node to the destination ExplodedNodeSet (autotransition) unless the client specifies otherwise with a bool flag. Several checkers did not call 'addTransition()' after calling 'GenerateNode()', causing the simulation path to be prematurely culled when a non-fail stop bug was encountered. 3) Add variants of GenerateNode()/GenerateSink() that take neither a Stmt* or a GRState*; most callers of GenerateNode() just pass in the same Stmt* as provided when the CheckerContext object is created; we can just use that the majority of the time. This cleanup also allows us to potentially coelesce the APIs for evaluating branches and end-of-paths (which currently directly use builders). 4) addTransition() no longer needs to be called except for a few cases. We now have a variant of addTransition() that takes a GRState*; this allows one to propagate the updated state without caring about generating a new node explicitly. This nicely cleaned up a bunch of cases that called autoTransition() with a bunch of conditional logic surround the call (that common logic has now been swallowed up by addTransition() itself). llvm-svn: 89707
78 lines
2.4 KiB
C++
78 lines
2.4 KiB
C++
//=== CastToStructChecker.cpp - Fixed address usage checker ----*- C++ -*--===//
|
|
//
|
|
// The LLVM Compiler Infrastructure
|
|
//
|
|
// This file is distributed under the University of Illinois Open Source
|
|
// License. See LICENSE.TXT for details.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
//
|
|
// This files defines CastToStructChecker, a builtin checker that checks for
|
|
// assignment of a fixed address to a pointer.
|
|
// This check corresponds to CWE-588.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "clang/Analysis/PathSensitive/CheckerVisitor.h"
|
|
#include "GRExprEngineInternalChecks.h"
|
|
|
|
using namespace clang;
|
|
|
|
namespace {
|
|
class VISIBILITY_HIDDEN CastToStructChecker
|
|
: public CheckerVisitor<CastToStructChecker> {
|
|
BuiltinBug *BT;
|
|
public:
|
|
CastToStructChecker() : BT(0) {}
|
|
static void *getTag();
|
|
void PreVisitCastExpr(CheckerContext &C, const CastExpr *B);
|
|
};
|
|
}
|
|
|
|
void *CastToStructChecker::getTag() {
|
|
static int x;
|
|
return &x;
|
|
}
|
|
|
|
void CastToStructChecker::PreVisitCastExpr(CheckerContext &C,
|
|
const CastExpr *CE) {
|
|
const Expr *E = CE->getSubExpr();
|
|
ASTContext &Ctx = C.getASTContext();
|
|
QualType OrigTy = Ctx.getCanonicalType(E->getType());
|
|
QualType ToTy = Ctx.getCanonicalType(CE->getType());
|
|
|
|
PointerType *OrigPTy = dyn_cast<PointerType>(OrigTy.getTypePtr());
|
|
PointerType *ToPTy = dyn_cast<PointerType>(ToTy.getTypePtr());
|
|
|
|
if (!ToPTy || !OrigPTy)
|
|
return;
|
|
|
|
QualType OrigPointeeTy = OrigPTy->getPointeeType();
|
|
QualType ToPointeeTy = ToPTy->getPointeeType();
|
|
|
|
if (!ToPointeeTy->isStructureType())
|
|
return;
|
|
|
|
// We allow cast from void*.
|
|
if (OrigPointeeTy->isVoidType())
|
|
return;
|
|
|
|
// Now the cast-to-type is struct pointer, the original type is not void*.
|
|
if (!OrigPointeeTy->isRecordType()) {
|
|
if (ExplodedNode *N = C.GenerateNode()) {
|
|
if (!BT)
|
|
BT = new BuiltinBug("Cast from non-struct type to struct type",
|
|
"Casting a non-structure type to a structure type "
|
|
"and accessing a field can lead to memory access "
|
|
"errors or data corruption.");
|
|
RangedBugReport *R = new RangedBugReport(*BT,BT->getDescription(), N);
|
|
R->addRange(CE->getSourceRange());
|
|
C.EmitReport(R);
|
|
}
|
|
}
|
|
}
|
|
|
|
void clang::RegisterCastToStructChecker(GRExprEngine &Eng) {
|
|
Eng.registerCheck(new CastToStructChecker());
|
|
}
|