mirror of
https://github.com/llvm/llvm-project.git
synced 2025-04-29 11:46:06 +00:00
ffe7950ebc
I'm trying to remove unused options from the `Analyses.def` file, then merge the rest of the useful options into the `AnalyzerOptions.def`. Then make sure one can set these by an `-analyzer-config XXX=YYY` style flag. Then surface the `-analyzer-config` to the `clang` frontend; After all of this, we can pursue the tablegen approach described https://discourse.llvm.org/t/rfc-tablegen-clang-static-analyzer-engine-options-for-better-documentation/61488 In this patch, I'm proposing flag deprecations. We should support deprecated analyzer flags for exactly one release. In this case I'm planning to drop this flag in `clang-16`. In the clang frontend, now we won't pass this option to the cc1 frontend, rather emit a warning diagnostic reminding the users about this deprecated flag, which will be turned into error in clang-16. Unfortunately, I had to remove all the tests referring to this flag, causing a mass change. I've also added a test for checking this warning. I've seen that `scan-build` also uses this flag, but I think we should remove that part only after we turn this into a hard error. Reviewed By: martong Differential Revision: https://reviews.llvm.org/D126215
126 lines
2.6 KiB
C
126 lines
2.6 KiB
C
// RUN: %clang_analyze_cc1 -analyzer-checker=core,alpha.core,debug.ExprInspection %s -verify
|
|
|
|
void clang_analyzer_eval(int);
|
|
|
|
unsigned foo(void);
|
|
typedef struct bf { unsigned x:2; } bf;
|
|
void bar(void) {
|
|
bf y;
|
|
*(unsigned*)&y = foo();
|
|
y.x = 1;
|
|
}
|
|
|
|
struct s {
|
|
int n;
|
|
};
|
|
|
|
void f(void) {
|
|
struct s a;
|
|
int *p = &(a.n) + 1; // expected-warning{{Pointer arithmetic on}}
|
|
}
|
|
|
|
typedef struct {
|
|
int x,y;
|
|
} Point;
|
|
|
|
Point getit(void);
|
|
void test(void) {
|
|
Point p;
|
|
(void)(p = getit()).x;
|
|
}
|
|
|
|
#define true ((bool)1)
|
|
#define false ((bool)0)
|
|
typedef _Bool bool;
|
|
|
|
|
|
void testLazyCompoundVal(void) {
|
|
Point p = {42, 0};
|
|
Point q;
|
|
clang_analyzer_eval((q = p).x == 42); // expected-warning{{TRUE}}
|
|
clang_analyzer_eval(q.x == 42); // expected-warning{{TRUE}}
|
|
}
|
|
|
|
|
|
struct Bits {
|
|
unsigned a : 1;
|
|
unsigned b : 2;
|
|
unsigned c : 1;
|
|
|
|
bool x;
|
|
|
|
struct InnerBits {
|
|
bool y;
|
|
|
|
unsigned d : 16;
|
|
unsigned e : 6;
|
|
unsigned f : 2;
|
|
} inner;
|
|
};
|
|
|
|
void testBitfields(void) {
|
|
struct Bits bits;
|
|
|
|
if (foo() && bits.b) // expected-warning {{garbage}}
|
|
return;
|
|
if (foo() && bits.inner.e) // expected-warning {{garbage}}
|
|
return;
|
|
|
|
bits.c = 1;
|
|
clang_analyzer_eval(bits.c == 1); // expected-warning {{TRUE}}
|
|
|
|
if (foo() && bits.b) // expected-warning {{garbage}}
|
|
return;
|
|
if (foo() && bits.x) // expected-warning {{garbage}}
|
|
return;
|
|
|
|
bits.x = true;
|
|
clang_analyzer_eval(bits.x == true); // expected-warning{{TRUE}}
|
|
bits.b = 2;
|
|
clang_analyzer_eval(bits.x == true); // expected-warning{{TRUE}}
|
|
if (foo() && bits.c) // no-warning
|
|
return;
|
|
|
|
bits.inner.e = 50;
|
|
if (foo() && bits.inner.e) // no-warning
|
|
return;
|
|
if (foo() && bits.inner.y) // expected-warning {{garbage}}
|
|
return;
|
|
if (foo() && bits.inner.f) // expected-warning {{garbage}}
|
|
return;
|
|
|
|
extern struct InnerBits getInner(void);
|
|
bits.inner = getInner();
|
|
|
|
if (foo() && bits.inner.e) // no-warning
|
|
return;
|
|
if (foo() && bits.inner.y) // no-warning
|
|
return;
|
|
if (foo() && bits.inner.f) // no-warning
|
|
return;
|
|
|
|
bits.inner.f = 1;
|
|
|
|
if (foo() && bits.inner.e) // no-warning
|
|
return;
|
|
if (foo() && bits.inner.y) // no-warning
|
|
return;
|
|
if (foo() && bits.inner.f) // no-warning
|
|
return;
|
|
|
|
if (foo() && bits.a) // expected-warning {{garbage}}
|
|
return;
|
|
}
|
|
|
|
|
|
//-----------------------------------------------------------------------------
|
|
// Incorrect behavior
|
|
//-----------------------------------------------------------------------------
|
|
|
|
void testTruncation(void) {
|
|
struct Bits bits;
|
|
bits.c = 0x11; // expected-warning{{implicit truncation}}
|
|
// FIXME: We don't model truncation of bitfields.
|
|
clang_analyzer_eval(bits.c == 1); // expected-warning {{FALSE}}
|
|
}
|