mirror of
https://github.com/llvm/llvm-project.git
synced 2025-04-30 02:56:05 +00:00
f119bf99e5
When a class forgets to initialize a field in the constructor, and then gets copied around, a warning is emitted that the value assigned to a specific field is undefined. When the copy/move constructor is implicit (not written out in the code) but not trivial (is not a trivial memory copy, eg. because members have an explicit copy constructor), the body of such constructor is auto-generated in the AST. In this case the checker's warning message is squeezed at the top of the class declaration, and it gets hard to guess which field is at fault. Fix the warning message to include the name of the field. Differential Revision: https://reviews.llvm.org/D43798 llvm-svn: 326258
76 lines
1.7 KiB
C++
76 lines
1.7 KiB
C++
// RUN: %clang_analyze_cc1 -analyzer-checker=core -analyzer-output=text -verify %s
|
|
|
|
namespace implicit_constructor {
|
|
struct S {
|
|
public:
|
|
S() {}
|
|
S(const S &) {}
|
|
};
|
|
|
|
// Warning is in a weird position because the body of the constructor is
|
|
// missing. Specify which field is being assigned.
|
|
class C { // expected-warning{{Value assigned to field 'y' in implicit constructor is garbage or undefined}}
|
|
// expected-note@-1{{Value assigned to field 'y' in implicit constructor is garbage or undefined}}
|
|
int x, y;
|
|
S s;
|
|
|
|
public:
|
|
C(): x(0) {}
|
|
};
|
|
|
|
void test() {
|
|
C c1;
|
|
C c2(c1); // expected-note{{Calling implicit copy constructor for 'C'}}
|
|
}
|
|
} // end namespace implicit_constructor
|
|
|
|
|
|
namespace explicit_constructor {
|
|
class C {
|
|
int x, y;
|
|
|
|
public:
|
|
C(): x(0) {}
|
|
// It is not necessary to specify which field is being assigned to.
|
|
C(const C &c):
|
|
x(c.x),
|
|
y(c.y) // expected-warning{{Assigned value is garbage or undefined}}
|
|
// expected-note@-1{{Assigned value is garbage or undefined}}
|
|
{}
|
|
};
|
|
|
|
void test() {
|
|
C c1;
|
|
C c2(c1); // expected-note{{Calling copy constructor for 'C'}}
|
|
}
|
|
} // end namespace explicit_constructor
|
|
|
|
|
|
namespace base_class_constructor {
|
|
struct S {
|
|
public:
|
|
S() {}
|
|
S(const S &) {}
|
|
};
|
|
|
|
class C { // expected-warning{{Value assigned to field 'y' in implicit constructor is garbage or undefined}}
|
|
// expected-note@-1{{Value assigned to field 'y' in implicit constructor is garbage or undefined}}
|
|
int x, y;
|
|
S s;
|
|
|
|
public:
|
|
C(): x(0) {}
|
|
};
|
|
|
|
class D: public C {
|
|
public:
|
|
D(): C() {}
|
|
};
|
|
|
|
void test() {
|
|
D d1;
|
|
D d2(d1); // expected-note {{Calling implicit copy constructor for 'D'}}
|
|
// expected-note@-1{{Calling implicit copy constructor for 'C'}}
|
|
}
|
|
} // end namespace base_class_constructor
|