mirror of
https://github.com/llvm/llvm-project.git
synced 2025-05-01 10:46:07 +00:00
0f1c1be196
We have a new policy in place making links to private resources something we try to avoid in source and test files. Normally, we'd organically switch to the new policy rather than make a sweeping change across a project. However, Clang is in a somewhat special circumstance currently: recently, I've had several new contributors run into rdar links around test code which their patch was changing the behavior of. This turns out to be a surprisingly bad experience, especially for newer folks, for a handful of reasons: not understanding what the link is and feeling intimidated by it, wondering whether their changes are actually breaking something important to a downstream in some way, having to hunt down strangers not involved with the patch to impose on them for help, accidental pressure from asking for potentially private IP to be made public, etc. Because folks run into these links entirely by chance (through fixing bugs or working on new features), there's not really a set of problematic links to focus on -- all of the links have basically the same potential for causing these problems. As a result, this is an omnibus patch to remove all such links. This was not a mechanical change; it was done by manually searching for rdar, radar, radr, and other variants to find all the various problematic links. From there, I tried to retain or reword the surrounding comments so that we would lose as little context as possible. However, because most links were just a plain link with no supporting context, the majority of the changes are simple removals. Differential Review: https://reviews.llvm.org/D158071
136 lines
3.0 KiB
C
136 lines
3.0 KiB
C
// RUN: %clang_analyze_cc1 -analyzer-checker=unix.Malloc -analyzer-inline-max-stack-depth=5 -verify %s
|
|
|
|
#include "Inputs/system-header-simulator.h"
|
|
|
|
void *malloc(size_t);
|
|
void *valloc(size_t);
|
|
void free(void *);
|
|
void *realloc(void *ptr, size_t size);
|
|
void *reallocf(void *ptr, size_t size);
|
|
void *calloc(size_t nmemb, size_t size);
|
|
|
|
void exit(int) __attribute__ ((__noreturn__));
|
|
void *memcpy(void * restrict s1, const void * restrict s2, size_t n);
|
|
size_t strlen(const char *);
|
|
|
|
static void my_malloc1(void **d, size_t size) {
|
|
*d = malloc(size);
|
|
}
|
|
|
|
static void *my_malloc2(int elevel, size_t size) {
|
|
void *data;
|
|
data = malloc(size);
|
|
if (data == 0)
|
|
exit(0);
|
|
return data;
|
|
}
|
|
|
|
static void my_free1(void *p) {
|
|
free(p);
|
|
}
|
|
|
|
static void test1(void) {
|
|
void *data = 0;
|
|
my_malloc1(&data, 4);
|
|
} // expected-warning {{Potential leak of memory pointed to by 'data'}}
|
|
|
|
static void test11(void) {
|
|
void *data = 0;
|
|
my_malloc1(&data, 4);
|
|
my_free1(data);
|
|
}
|
|
|
|
static void testUniqueingByallocationSiteInTopLevelFunction(void) {
|
|
void *data = my_malloc2(1, 4);
|
|
data = 0;
|
|
int x = 5;// expected-warning {{Potential leak of memory pointed to by 'data'}}
|
|
data = my_malloc2(1, 4);
|
|
} // expected-warning {{Potential leak of memory pointed to by 'data'}}
|
|
|
|
static void test3(void) {
|
|
void *data = my_malloc2(1, 4);
|
|
free(data);
|
|
data = my_malloc2(1, 4);
|
|
free(data);
|
|
}
|
|
|
|
int test4(void) {
|
|
int *data = (int*)my_malloc2(1, 4);
|
|
my_free1(data);
|
|
data = (int *)my_malloc2(1, 4);
|
|
my_free1(data);
|
|
return *data; // expected-warning {{Use of memory after it is freed}}
|
|
}
|
|
|
|
void test6(void) {
|
|
int *data = (int *)my_malloc2(1, 4);
|
|
my_free1((int*)data);
|
|
my_free1((int*)data); // expected-warning{{Use of memory after it is freed}}
|
|
}
|
|
|
|
// TODO: We should warn here.
|
|
void test5(void) {
|
|
int *data;
|
|
my_free1((int*)data);
|
|
}
|
|
|
|
static char *reshape(char *in) {
|
|
return 0;
|
|
}
|
|
|
|
void testThatRemoveDeadBindingsRunBeforeEachCall(void) {
|
|
char *v = malloc(12);
|
|
v = reshape(v);
|
|
v = reshape(v);// expected-warning {{Potential leak of memory pointed to by 'v'}}
|
|
}
|
|
|
|
// Test that we keep processing after 'return;'
|
|
void fooWithEmptyReturn(int x) {
|
|
if (x)
|
|
return;
|
|
x++;
|
|
return;
|
|
}
|
|
|
|
int uafAndCallsFooWithEmptyReturn(void) {
|
|
int *x = (int*)malloc(12);
|
|
free(x);
|
|
fooWithEmptyReturn(12);
|
|
return *x; // expected-warning {{Use of memory after it is freed}}
|
|
}
|
|
|
|
|
|
// If we inline any of the malloc-family functions, the checker shouldn't also
|
|
// try to do additional modeling.
|
|
char *strndup(const char *str, size_t n) {
|
|
if (!str)
|
|
return 0;
|
|
|
|
// DO NOT FIX. This is to test that we are actually using the inlined
|
|
// behavior!
|
|
if (n < 5)
|
|
return 0;
|
|
|
|
size_t length = strlen(str);
|
|
if (length < n)
|
|
n = length;
|
|
|
|
char *result = malloc(n + 1);
|
|
memcpy(result, str, n);
|
|
result[n] = '\0';
|
|
return result;
|
|
}
|
|
|
|
void useStrndup(size_t n) {
|
|
if (n == 0) {
|
|
(void)strndup(0, 20); // no-warning
|
|
return;
|
|
} else if (n < 5) {
|
|
(void)strndup("hi there", n); // no-warning
|
|
return;
|
|
} else {
|
|
(void)strndup("hi there", n);
|
|
return; // expected-warning{{leak}}
|
|
}
|
|
}
|