mirror of
https://github.com/llvm/llvm-project.git
synced 2025-05-09 08:26:07 +00:00
d68ebea767
This originally broke the TestQuoting which explicitly called buildDefault instead of calling build() and marking the test as no_debug_info_test. TestQuoting has been rewritten by now and is using `build`, so this should now pass on all platforms. Original summary: The Darwin builder currently assumes in `getArchCFlags` that the passed `arch` value is an actual string it can string.join with vendor/os/version/env strings: ``` triple = '-'.join([arch, vendor, os, version, env]) ``` However this is not true for most tests as we just pass down the `arch=None` default value from `TestBase.build`. This causes that if we actually end up in this function we just error out when concatenating `None` with the other actual strings of vendor/os/version/env. What we should do instead is check that if there is no test-specific architecture that we fall back to the configuration's architecture value. It seems we already worked around this in `builder.getArchSpec` by explicitly falling back to the architecture specified in the configuration. This patch just moves this fallback logic to the top `build` function so that it affects all functions called from `TestBase.build`. Reviewed By: JDevlieghere Differential Revision: https://reviews.llvm.org/D89056