mirror of
https://github.com/llvm/llvm-project.git
synced 2025-05-16 14:26:06 +00:00

This fixes a verifier error I ran into at -O0. A subregister copy had an implicit kill of an overlapping superregister, which was partially redefined by the copy. The preserved implicit operand killed subregisters made live earlier in the sequence. AMDGPU already uses similar logic for whether to preserve the kill of the superregister on the final instruction if there's overlap.
229 lines
7.5 KiB
C++
229 lines
7.5 KiB
C++
//===-- ExpandPostRAPseudos.cpp - Pseudo instruction expansion pass -------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
//
|
|
// This file defines a pass that expands COPY and SUBREG_TO_REG pseudo
|
|
// instructions after register allocation.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "llvm/CodeGen/MachineFunctionPass.h"
|
|
#include "llvm/CodeGen/MachineInstr.h"
|
|
#include "llvm/CodeGen/MachineInstrBuilder.h"
|
|
#include "llvm/CodeGen/MachineRegisterInfo.h"
|
|
#include "llvm/CodeGen/Passes.h"
|
|
#include "llvm/CodeGen/TargetInstrInfo.h"
|
|
#include "llvm/CodeGen/TargetRegisterInfo.h"
|
|
#include "llvm/CodeGen/TargetSubtargetInfo.h"
|
|
#include "llvm/InitializePasses.h"
|
|
#include "llvm/Support/Debug.h"
|
|
#include "llvm/Support/raw_ostream.h"
|
|
|
|
using namespace llvm;
|
|
|
|
#define DEBUG_TYPE "postrapseudos"
|
|
|
|
namespace {
|
|
struct ExpandPostRA : public MachineFunctionPass {
|
|
private:
|
|
const TargetRegisterInfo *TRI;
|
|
const TargetInstrInfo *TII;
|
|
|
|
public:
|
|
static char ID; // Pass identification, replacement for typeid
|
|
ExpandPostRA() : MachineFunctionPass(ID) {}
|
|
|
|
void getAnalysisUsage(AnalysisUsage &AU) const override {
|
|
AU.setPreservesCFG();
|
|
AU.addPreservedID(MachineLoopInfoID);
|
|
AU.addPreservedID(MachineDominatorsID);
|
|
MachineFunctionPass::getAnalysisUsage(AU);
|
|
}
|
|
|
|
/// runOnMachineFunction - pass entry point
|
|
bool runOnMachineFunction(MachineFunction&) override;
|
|
|
|
private:
|
|
bool LowerSubregToReg(MachineInstr *MI);
|
|
bool LowerCopy(MachineInstr *MI);
|
|
|
|
void TransferImplicitOperands(MachineInstr *MI);
|
|
};
|
|
} // end anonymous namespace
|
|
|
|
char ExpandPostRA::ID = 0;
|
|
char &llvm::ExpandPostRAPseudosID = ExpandPostRA::ID;
|
|
|
|
INITIALIZE_PASS(ExpandPostRA, DEBUG_TYPE,
|
|
"Post-RA pseudo instruction expansion pass", false, false)
|
|
|
|
/// TransferImplicitOperands - MI is a pseudo-instruction, and the lowered
|
|
/// replacement instructions immediately precede it. Copy any implicit
|
|
/// operands from MI to the replacement instruction.
|
|
void ExpandPostRA::TransferImplicitOperands(MachineInstr *MI) {
|
|
MachineBasicBlock::iterator CopyMI = MI;
|
|
--CopyMI;
|
|
|
|
Register DstReg = MI->getOperand(0).getReg();
|
|
for (const MachineOperand &MO : MI->implicit_operands()) {
|
|
CopyMI->addOperand(MO);
|
|
|
|
// Be conservative about preserving kills when subregister defs are
|
|
// involved. If there was implicit kill of a super-register overlapping the
|
|
// copy result, we would kill the subregisters previous copies defined.
|
|
if (MO.isKill() && TRI->regsOverlap(DstReg, MO.getReg()))
|
|
CopyMI->getOperand(CopyMI->getNumOperands() - 1).setIsKill(false);
|
|
}
|
|
}
|
|
|
|
bool ExpandPostRA::LowerSubregToReg(MachineInstr *MI) {
|
|
MachineBasicBlock *MBB = MI->getParent();
|
|
assert((MI->getOperand(0).isReg() && MI->getOperand(0).isDef()) &&
|
|
MI->getOperand(1).isImm() &&
|
|
(MI->getOperand(2).isReg() && MI->getOperand(2).isUse()) &&
|
|
MI->getOperand(3).isImm() && "Invalid subreg_to_reg");
|
|
|
|
Register DstReg = MI->getOperand(0).getReg();
|
|
Register InsReg = MI->getOperand(2).getReg();
|
|
assert(!MI->getOperand(2).getSubReg() && "SubIdx on physreg?");
|
|
unsigned SubIdx = MI->getOperand(3).getImm();
|
|
|
|
assert(SubIdx != 0 && "Invalid index for insert_subreg");
|
|
Register DstSubReg = TRI->getSubReg(DstReg, SubIdx);
|
|
|
|
assert(Register::isPhysicalRegister(DstReg) &&
|
|
"Insert destination must be in a physical register");
|
|
assert(Register::isPhysicalRegister(InsReg) &&
|
|
"Inserted value must be in a physical register");
|
|
|
|
LLVM_DEBUG(dbgs() << "subreg: CONVERTING: " << *MI);
|
|
|
|
if (MI->allDefsAreDead()) {
|
|
MI->setDesc(TII->get(TargetOpcode::KILL));
|
|
MI->RemoveOperand(3); // SubIdx
|
|
MI->RemoveOperand(1); // Imm
|
|
LLVM_DEBUG(dbgs() << "subreg: replaced by: " << *MI);
|
|
return true;
|
|
}
|
|
|
|
if (DstSubReg == InsReg) {
|
|
// No need to insert an identity copy instruction.
|
|
// Watch out for case like this:
|
|
// %rax = SUBREG_TO_REG 0, killed %eax, 3
|
|
// We must leave %rax live.
|
|
if (DstReg != InsReg) {
|
|
MI->setDesc(TII->get(TargetOpcode::KILL));
|
|
MI->RemoveOperand(3); // SubIdx
|
|
MI->RemoveOperand(1); // Imm
|
|
LLVM_DEBUG(dbgs() << "subreg: replace by: " << *MI);
|
|
return true;
|
|
}
|
|
LLVM_DEBUG(dbgs() << "subreg: eliminated!");
|
|
} else {
|
|
TII->copyPhysReg(*MBB, MI, MI->getDebugLoc(), DstSubReg, InsReg,
|
|
MI->getOperand(2).isKill());
|
|
|
|
// Implicitly define DstReg for subsequent uses.
|
|
MachineBasicBlock::iterator CopyMI = MI;
|
|
--CopyMI;
|
|
CopyMI->addRegisterDefined(DstReg);
|
|
LLVM_DEBUG(dbgs() << "subreg: " << *CopyMI);
|
|
}
|
|
|
|
LLVM_DEBUG(dbgs() << '\n');
|
|
MBB->erase(MI);
|
|
return true;
|
|
}
|
|
|
|
bool ExpandPostRA::LowerCopy(MachineInstr *MI) {
|
|
|
|
if (MI->allDefsAreDead()) {
|
|
LLVM_DEBUG(dbgs() << "dead copy: " << *MI);
|
|
MI->setDesc(TII->get(TargetOpcode::KILL));
|
|
LLVM_DEBUG(dbgs() << "replaced by: " << *MI);
|
|
return true;
|
|
}
|
|
|
|
MachineOperand &DstMO = MI->getOperand(0);
|
|
MachineOperand &SrcMO = MI->getOperand(1);
|
|
|
|
bool IdentityCopy = (SrcMO.getReg() == DstMO.getReg());
|
|
if (IdentityCopy || SrcMO.isUndef()) {
|
|
LLVM_DEBUG(dbgs() << (IdentityCopy ? "identity copy: " : "undef copy: ")
|
|
<< *MI);
|
|
// No need to insert an identity copy instruction, but replace with a KILL
|
|
// if liveness is changed.
|
|
if (SrcMO.isUndef() || MI->getNumOperands() > 2) {
|
|
// We must make sure the super-register gets killed. Replace the
|
|
// instruction with KILL.
|
|
MI->setDesc(TII->get(TargetOpcode::KILL));
|
|
LLVM_DEBUG(dbgs() << "replaced by: " << *MI);
|
|
return true;
|
|
}
|
|
// Vanilla identity copy.
|
|
MI->eraseFromParent();
|
|
return true;
|
|
}
|
|
|
|
LLVM_DEBUG(dbgs() << "real copy: " << *MI);
|
|
TII->copyPhysReg(*MI->getParent(), MI, MI->getDebugLoc(),
|
|
DstMO.getReg(), SrcMO.getReg(), SrcMO.isKill());
|
|
|
|
if (MI->getNumOperands() > 2)
|
|
TransferImplicitOperands(MI);
|
|
LLVM_DEBUG({
|
|
MachineBasicBlock::iterator dMI = MI;
|
|
dbgs() << "replaced by: " << *(--dMI);
|
|
});
|
|
MI->eraseFromParent();
|
|
return true;
|
|
}
|
|
|
|
/// runOnMachineFunction - Reduce subregister inserts and extracts to register
|
|
/// copies.
|
|
///
|
|
bool ExpandPostRA::runOnMachineFunction(MachineFunction &MF) {
|
|
LLVM_DEBUG(dbgs() << "Machine Function\n"
|
|
<< "********** EXPANDING POST-RA PSEUDO INSTRS **********\n"
|
|
<< "********** Function: " << MF.getName() << '\n');
|
|
TRI = MF.getSubtarget().getRegisterInfo();
|
|
TII = MF.getSubtarget().getInstrInfo();
|
|
|
|
bool MadeChange = false;
|
|
|
|
for (MachineBasicBlock &MBB : MF) {
|
|
for (MachineInstr &MI : llvm::make_early_inc_range(MBB)) {
|
|
// Only expand pseudos.
|
|
if (!MI.isPseudo())
|
|
continue;
|
|
|
|
// Give targets a chance to expand even standard pseudos.
|
|
if (TII->expandPostRAPseudo(MI)) {
|
|
MadeChange = true;
|
|
continue;
|
|
}
|
|
|
|
// Expand standard pseudos.
|
|
switch (MI.getOpcode()) {
|
|
case TargetOpcode::SUBREG_TO_REG:
|
|
MadeChange |= LowerSubregToReg(&MI);
|
|
break;
|
|
case TargetOpcode::COPY:
|
|
MadeChange |= LowerCopy(&MI);
|
|
break;
|
|
case TargetOpcode::DBG_VALUE:
|
|
continue;
|
|
case TargetOpcode::INSERT_SUBREG:
|
|
case TargetOpcode::EXTRACT_SUBREG:
|
|
llvm_unreachable("Sub-register pseudos should have been eliminated.");
|
|
}
|
|
}
|
|
}
|
|
|
|
return MadeChange;
|
|
}
|