llvm-project

mirror of https://github.com/llvm/llvm-project.git synced 2025-04-27 20:26:06 +00:00

History

Stephan T. Lavavej bfdc562d0c

[libc++] Fix copy-paste damage in ranges::rotate_copy and its test (#74544 )

Found while running libc++'s tests with MSVC's STL.

`ranges::rotate_copy` takes `forward_iterator`s as this test's comment
banner correctly depicts. However, this test had bogus assertions
expecting that `ranges::rotate_copy` would be constrained away for
not-quite-**bidi** iterators. @philnik777 confirmed that these were
copy-paste relics from the `ranges::reverse_copy` test.

I fixed this by replacing the assertions with the test types that aren't
quite **forward** iterators/ranges. Additionally, I noticed that the
top-level `test()` function was missing coverage with the weakest
possible `forward_iterator<int*>`.

This revealed that the product code in `ranges_rotate_copy.h` was
similarly damaged. In addition to fixing it by taking `forward_iterator`
and `forward_range` as depicted in the Standard, this drops the
inclusion of `<__iterator/reverse_iterator.h>` as this algorithm doesn't
need `std::__reverse_range`.

2023-12-06 02:29:09 -08:00

alg.c.library

…

alg.modifying.operations

[libc++] Fix copy-paste damage in ranges::rotate_copy and its test (#74544 )

2023-12-06 02:29:09 -08:00

alg.nonmodifying

[libc++][test] Fix simple warnings (#74186 )

2023-12-05 09:46:41 -05:00

alg.sorting

[libc++][test] Fix assumptions that std::array iterators are pointers (#74430 )

2023-12-05 11:25:42 -05:00