mirror of
https://github.com/llvm/llvm-project.git
synced 2025-04-27 13:26:08 +00:00
7068aa9841
Clang has traditionally allowed C programs to implicitly convert integers to pointers and pointers to integers, despite it not being valid to do so except under special circumstances (like converting the integer 0, which is the null pointer constant, to a pointer). In C89, this would result in undefined behavior per 3.3.4, and in C99 this rule was strengthened to be a constraint violation instead. Constraint violations are most often handled as an error. This patch changes the warning to default to an error in all C modes (it is already an error in C++). This gives us better security posture by calling out potential programmer mistakes in code but still allows users who need this behavior to use -Wno-error=int-conversion to retain the warning behavior, or -Wno-int-conversion to silence the diagnostic entirely. Differential Revision: https://reviews.llvm.org/D129881
105 lines
2.8 KiB
C
105 lines
2.8 KiB
C
// RUN: %clang_cc1 -x c -triple bpf-pc-linux-gnu -dwarf-version=4 -fsyntax-only -verify %s
|
|
|
|
struct s {
|
|
int a;
|
|
int b[4];
|
|
int c:1;
|
|
};
|
|
union u {
|
|
int a;
|
|
int b[4];
|
|
int c:1;
|
|
};
|
|
typedef struct {
|
|
int a;
|
|
int b;
|
|
} __t;
|
|
typedef int (*__f)(void);
|
|
enum AA {
|
|
VAL1 = 10,
|
|
VAL2 = 0xffffffff80000000UL,
|
|
};
|
|
typedef enum {
|
|
VAL10 = 10,
|
|
VAL11 = 11,
|
|
} __BB;
|
|
|
|
unsigned invalid1(const int *arg) {
|
|
return __builtin_preserve_field_info(arg, 1); // expected-error {{__builtin_preserve_field_info argument 1 not a field access}}
|
|
}
|
|
|
|
unsigned invalid2(const int *arg) {
|
|
return __builtin_preserve_field_info(*arg, 1); // expected-error {{__builtin_preserve_field_info argument 1 not a field access}}
|
|
}
|
|
|
|
void *invalid3(struct s *arg) {
|
|
return __builtin_preserve_field_info(arg->a, 1); // expected-error {{incompatible integer to pointer conversion returning 'unsigned int' from a function with result type 'void *'}}
|
|
}
|
|
|
|
unsigned valid4(struct s *arg) {
|
|
return __builtin_preserve_field_info(arg->b[1], 1);
|
|
}
|
|
|
|
unsigned valid5(union u *arg) {
|
|
return __builtin_preserve_field_info(arg->b[2], 1);
|
|
}
|
|
|
|
unsigned valid6(struct s *arg) {
|
|
return __builtin_preserve_field_info(arg->a, 1);
|
|
}
|
|
|
|
unsigned valid7(struct s *arg) {
|
|
return __builtin_preserve_field_info(arg->c, 1ULL);
|
|
}
|
|
|
|
unsigned valid8(union u *arg) {
|
|
return __builtin_preserve_field_info(arg->a, 1);
|
|
}
|
|
|
|
unsigned valid9(union u *arg) {
|
|
return __builtin_preserve_field_info(arg->c, 'a');
|
|
}
|
|
|
|
unsigned invalid10(struct s *arg) {
|
|
return __builtin_preserve_field_info(arg->a, arg); // expected-error {{__builtin_preserve_field_info argument 2 not a constant}}
|
|
}
|
|
|
|
unsigned invalid11(struct s *arg, int info_kind) {
|
|
return __builtin_preserve_field_info(arg->a, info_kind); // expected-error {{__builtin_preserve_field_info argument 2 not a constant}}
|
|
}
|
|
|
|
unsigned valid12(void) {
|
|
const struct s t;
|
|
return __builtin_preserve_type_info(t, 0) +
|
|
__builtin_preserve_type_info(*(struct s *)0, 1);
|
|
}
|
|
|
|
unsigned valid13(void) {
|
|
__t t;
|
|
return __builtin_preserve_type_info(t, 1) +
|
|
__builtin_preserve_type_info(*(__t *)0, 0);
|
|
}
|
|
|
|
unsigned valid14(void) {
|
|
enum AA t;
|
|
return __builtin_preserve_type_info(t, 0) +
|
|
__builtin_preserve_type_info(*(enum AA *)0, 1);
|
|
}
|
|
|
|
unsigned valid15(void) {
|
|
return __builtin_preserve_enum_value(*(enum AA *)VAL1, 1) +
|
|
__builtin_preserve_enum_value(*(enum AA *)VAL2, 1);
|
|
}
|
|
|
|
unsigned invalid16(void) {
|
|
return __builtin_preserve_enum_value(*(enum AA *)0, 1); // expected-error {{__builtin_preserve_enum_value argument 1 invalid}}
|
|
}
|
|
|
|
unsigned invalid17(void) {
|
|
return __builtin_preserve_enum_value(*(enum AA *)VAL10, 1); // expected-error {{__builtin_preserve_enum_value argument 1 invalid}}
|
|
}
|
|
|
|
unsigned invalid18(struct s *arg) {
|
|
return __builtin_preserve_type_info(arg->a + 2, 0); // expected-error {{__builtin_preserve_type_info argument 1 invalid}}
|
|
}
|