mirror of
https://github.com/llvm/llvm-project.git
synced 2025-04-26 19:56:06 +00:00
c6ffe4d76f
The `-Wpointer-sign` warning text is inappropriate for describing the incompatible pointer conversion between plain `char` and explicitly `signed`/`unsigned` `char` (whichever plain `char` has the same range as) and vice versa. Specifically, in part, it reads "converts between pointers to integer types with different sign". This patch changes that portion to read instead as "converts between pointers to integer types where one is of the unique plain 'char' type and the other is not" when one of the types is plain `char`. C17 subclause 6.5.16.1 indicates that the conversions resulting in `-Wpointer-sign` warnings in assignment-like contexts are constraint violations. This means that strict conformance requires a diagnostic for the case where the message text is wrong before this patch. The lack of an even more specialized warning group is consistent with GCC. Reviewed By: aaron.ballman Differential Revision: https://reviews.llvm.org/D93999
15 lines
515 B
C++
15 lines
515 B
C++
// RUN: %clang_cc1 %s -verify -fsyntax-only
|
|
// RUN: %clang_cc1 %s -verify -fsyntax-only -fno-signed-char
|
|
|
|
void plainToSigned() {
|
|
extern char c;
|
|
signed char *p;
|
|
p = &c; // expected-error {{converts between pointers to integer types where one is of the unique plain 'char' type and the other is not}}
|
|
}
|
|
|
|
void unsignedToPlain() {
|
|
extern unsigned char uc;
|
|
char *p;
|
|
p = &uc; // expected-error {{converts between pointers to integer types where one is of the unique plain 'char' type and the other is not}}
|
|
}
|