mirror of
https://github.com/llvm/llvm-project.git
synced 2025-05-16 06:16:07 +00:00
d963a7c398
The code in LLDB assumes that CompilerType and friends use the size 0 as a sentinel value to signal an error. This works for C++, where no zero-sized type exists, but in many other programming languages (including I believe C) types of size zero are possible and even common. This is a particular pain point in swift-lldb, where extra code exists to double-check that a type is *really* of size zero and not an error at various locations. To remedy this situation, this patch starts by converting CompilerType::getBitSize() and getByteSize() to return an optional result. To avoid wasting space, I hand-rolled my own optional data type assuming that no type is larger than what fits into 63 bits. Follow-up patches would make similar changes to the ValueObject hierarchy. rdar://problem/47178964 Differential Revision: https://reviews.llvm.org/D56688 llvm-svn: 351214
124 lines
3.8 KiB
C++
124 lines
3.8 KiB
C++
//===-- LibCxxInitializerList.cpp -------------------------------*- C++ -*-===//
|
|
//
|
|
// The LLVM Compiler Infrastructure
|
|
//
|
|
// This file is distributed under the University of Illinois Open Source
|
|
// License. See LICENSE.TXT for details.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "LibCxx.h"
|
|
|
|
#include "lldb/Core/ValueObject.h"
|
|
#include "lldb/DataFormatters/FormattersHelpers.h"
|
|
#include "lldb/Utility/ConstString.h"
|
|
|
|
using namespace lldb;
|
|
using namespace lldb_private;
|
|
using namespace lldb_private::formatters;
|
|
|
|
namespace lldb_private {
|
|
namespace formatters {
|
|
class LibcxxInitializerListSyntheticFrontEnd
|
|
: public SyntheticChildrenFrontEnd {
|
|
public:
|
|
LibcxxInitializerListSyntheticFrontEnd(lldb::ValueObjectSP valobj_sp);
|
|
|
|
~LibcxxInitializerListSyntheticFrontEnd() override;
|
|
|
|
size_t CalculateNumChildren() override;
|
|
|
|
lldb::ValueObjectSP GetChildAtIndex(size_t idx) override;
|
|
|
|
bool Update() override;
|
|
|
|
bool MightHaveChildren() override;
|
|
|
|
size_t GetIndexOfChildWithName(const ConstString &name) override;
|
|
|
|
private:
|
|
ValueObject *m_start;
|
|
CompilerType m_element_type;
|
|
uint32_t m_element_size;
|
|
size_t m_num_elements;
|
|
};
|
|
} // namespace formatters
|
|
} // namespace lldb_private
|
|
|
|
lldb_private::formatters::LibcxxInitializerListSyntheticFrontEnd::
|
|
LibcxxInitializerListSyntheticFrontEnd(lldb::ValueObjectSP valobj_sp)
|
|
: SyntheticChildrenFrontEnd(*valobj_sp), m_start(nullptr), m_element_type(),
|
|
m_element_size(0), m_num_elements(0) {
|
|
if (valobj_sp)
|
|
Update();
|
|
}
|
|
|
|
lldb_private::formatters::LibcxxInitializerListSyntheticFrontEnd::
|
|
~LibcxxInitializerListSyntheticFrontEnd() {
|
|
// this needs to stay around because it's a child object who will follow its
|
|
// parent's life cycle
|
|
// delete m_start;
|
|
}
|
|
|
|
size_t lldb_private::formatters::LibcxxInitializerListSyntheticFrontEnd::
|
|
CalculateNumChildren() {
|
|
static ConstString g___size_("__size_");
|
|
m_num_elements = 0;
|
|
ValueObjectSP size_sp(m_backend.GetChildMemberWithName(g___size_, true));
|
|
if (size_sp)
|
|
m_num_elements = size_sp->GetValueAsUnsigned(0);
|
|
return m_num_elements;
|
|
}
|
|
|
|
lldb::ValueObjectSP lldb_private::formatters::
|
|
LibcxxInitializerListSyntheticFrontEnd::GetChildAtIndex(size_t idx) {
|
|
if (!m_start)
|
|
return lldb::ValueObjectSP();
|
|
|
|
uint64_t offset = idx * m_element_size;
|
|
offset = offset + m_start->GetValueAsUnsigned(0);
|
|
StreamString name;
|
|
name.Printf("[%" PRIu64 "]", (uint64_t)idx);
|
|
return CreateValueObjectFromAddress(name.GetString(), offset,
|
|
m_backend.GetExecutionContextRef(),
|
|
m_element_type);
|
|
}
|
|
|
|
bool lldb_private::formatters::LibcxxInitializerListSyntheticFrontEnd::
|
|
Update() {
|
|
static ConstString g___begin_("__begin_");
|
|
|
|
m_start = nullptr;
|
|
m_num_elements = 0;
|
|
m_element_type = m_backend.GetCompilerType().GetTypeTemplateArgument(0);
|
|
if (!m_element_type.IsValid())
|
|
return false;
|
|
|
|
if (auto size = m_element_type.GetByteSize(nullptr)) {
|
|
m_element_size = *size;
|
|
// Store raw pointers or end up with a circular dependency.
|
|
m_start = m_backend.GetChildMemberWithName(g___begin_, true).get();
|
|
}
|
|
|
|
return false;
|
|
}
|
|
|
|
bool lldb_private::formatters::LibcxxInitializerListSyntheticFrontEnd::
|
|
MightHaveChildren() {
|
|
return true;
|
|
}
|
|
|
|
size_t lldb_private::formatters::LibcxxInitializerListSyntheticFrontEnd::
|
|
GetIndexOfChildWithName(const ConstString &name) {
|
|
if (!m_start)
|
|
return UINT32_MAX;
|
|
return ExtractIndexFromString(name.GetCString());
|
|
}
|
|
|
|
lldb_private::SyntheticChildrenFrontEnd *
|
|
lldb_private::formatters::LibcxxInitializerListSyntheticFrontEndCreator(
|
|
CXXSyntheticChildren *, lldb::ValueObjectSP valobj_sp) {
|
|
return (valobj_sp ? new LibcxxInitializerListSyntheticFrontEnd(valobj_sp)
|
|
: nullptr);
|
|
}
|