mirror of
https://github.com/llvm/llvm-project.git
synced 2025-04-25 09:16:05 +00:00
38d25aecdf
Since Windows 10 version 1803 (10.0.17134.0) (or Windows Server 2019), the Windows Universal C Runtime (UCRT) actually does support UTF-8 locales - they're available e.g. via the same names as commonly on Unices, e.g. "en_US.UTF-8". The UTF-8 locale support unfortunately has a bug which breaks a couple tests that were passing previously. That bug is fixed in the very latest version of the UCRT (in UCRT 10.0.20348.0, available in Windows 11 or Windows Server 2022), so it will get resolved at some point eventually, provided that the CI environment does get upgraded to a newer version of Windows Server. While the net number of xfailed/passing tests in this patch is a loss, this does allow fixing a lot more locale tests properly for Windows in later patches. Intentionally not touching the ISO-8859-1/2 locales used for testing; they're not detected and tested/used right now, and fixing that up is another project. Differential Revision: https://reviews.llvm.org/D119930