mirror of
https://github.com/llvm/llvm-project.git
synced 2025-04-15 22:46:32 +00:00
da95d926f6
This patch provides more information to the `PPCallbacks::InclusionDirective()` hook. We now always pass the suggested module, regardless of whether it was actually imported or not. The extra `bool ModuleImported` parameter then denotes whether the header `#include` will be automatically translated into import the the module. The main change is in `clang/lib/Lex/PPDirectives.cpp`, where we take care to not modify `SuggestedModule` after it's been populated by `LookupHeaderIncludeOrImport()`. We now exclusively use the `SM` (`ModuleToImport`) variable instead, which has been equivalent to `SuggestedModule` until now. This allows us to use the original non-modified `SuggestedModule` for the callback itself. (This patch turns out to be necessary for https://github.com/apple/llvm-project/pull/8011).
69 lines
2.8 KiB
C++
69 lines
2.8 KiB
C++
//===--- RestrictSystemLibcHeadersCheck.cpp - clang-tidy ------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "RestrictSystemLibcHeadersCheck.h"
|
|
#include "clang/AST/ASTContext.h"
|
|
#include "clang/ASTMatchers/ASTMatchFinder.h"
|
|
#include "clang/Lex/HeaderSearch.h"
|
|
#include "clang/Lex/HeaderSearchOptions.h"
|
|
#include "clang/Lex/Preprocessor.h"
|
|
|
|
// FixItHint - Hint to check documentation script to mark this check as
|
|
// providing a FixIt.
|
|
|
|
namespace clang::tidy::llvm_libc {
|
|
|
|
namespace {
|
|
|
|
class RestrictedIncludesPPCallbacks
|
|
: public portability::RestrictedIncludesPPCallbacks {
|
|
public:
|
|
explicit RestrictedIncludesPPCallbacks(
|
|
RestrictSystemLibcHeadersCheck &Check, const SourceManager &SM,
|
|
const SmallString<128> CompilerIncudeDir)
|
|
: portability::RestrictedIncludesPPCallbacks(Check, SM),
|
|
CompilerIncudeDir(CompilerIncudeDir) {}
|
|
|
|
void InclusionDirective(SourceLocation HashLoc, const Token &IncludeTok,
|
|
StringRef FileName, bool IsAngled,
|
|
CharSourceRange FilenameRange,
|
|
OptionalFileEntryRef File, StringRef SearchPath,
|
|
StringRef RelativePath, const Module *SuggestedModule,
|
|
bool ModuleImported,
|
|
SrcMgr::CharacteristicKind FileType) override;
|
|
|
|
private:
|
|
const SmallString<128> CompilerIncudeDir;
|
|
};
|
|
|
|
} // namespace
|
|
|
|
void RestrictedIncludesPPCallbacks::InclusionDirective(
|
|
SourceLocation HashLoc, const Token &IncludeTok, StringRef FileName,
|
|
bool IsAngled, CharSourceRange FilenameRange, OptionalFileEntryRef File,
|
|
StringRef SearchPath, StringRef RelativePath, const Module *SuggestedModule,
|
|
bool ModuleImported, SrcMgr::CharacteristicKind FileType) {
|
|
// Compiler provided headers are allowed (e.g stddef.h).
|
|
if (SrcMgr::isSystem(FileType) && SearchPath == CompilerIncudeDir)
|
|
return;
|
|
portability::RestrictedIncludesPPCallbacks::InclusionDirective(
|
|
HashLoc, IncludeTok, FileName, IsAngled, FilenameRange, File, SearchPath,
|
|
RelativePath, SuggestedModule, ModuleImported, FileType);
|
|
}
|
|
|
|
void RestrictSystemLibcHeadersCheck::registerPPCallbacks(
|
|
const SourceManager &SM, Preprocessor *PP, Preprocessor *ModuleExpanderPP) {
|
|
SmallString<128> CompilerIncudeDir =
|
|
StringRef(PP->getHeaderSearchInfo().getHeaderSearchOpts().ResourceDir);
|
|
llvm::sys::path::append(CompilerIncudeDir, "include");
|
|
PP->addPPCallbacks(std::make_unique<RestrictedIncludesPPCallbacks>(
|
|
*this, SM, CompilerIncudeDir));
|
|
}
|
|
|
|
} // namespace clang::tidy::llvm_libc
|