mirror of
https://github.com/llvm/llvm-project.git
synced 2025-04-26 13:56:09 +00:00
f347541fbc
If %t1.o has a weak reference on foo, and %t2.so has a non-weak reference on foo: `ld.lld %t1.o %t2.so -o %t` We incorrectly set the binding of the undefined foo to STB_GLOBAL. Fix this by ignoring undefined symbols in a SharedFile for Undefined and SharedSymbol. This fixes the binding of pthread_once when the program links against both librt.so and libpthread.so ``` a.o: STB_WEAK reference to pthread_once librt.so: STB_GLOBAL reference to pthread_once # should be ignored libstdc++.so: STB_WEAK reference to pthread_once # should be ignored libgcc_s.so.1: STB_WEAK reference to pthread_once # should be ignored ``` The STB_GLOBAL pthread_once issue (not fixed by D63974) can cause a link error when the result DSO is used to link another DSO with -z defs if -lpthread is not specified. (libstdc++.so.6 not having a dependency on libpthread.so is a really nasty hack...) We happened to create a weak undef before D63974 because libgcc_s.so.1 was linked the last and it changed the binding again to weak. Reviewed By: ruiu Differential Revision: https://reviews.llvm.org/D64136 llvm-svn: 365129
23 lines
705 B
ArmAsm
23 lines
705 B
ArmAsm
# REQUIRES: x86
|
|
|
|
# We have a code in LLD that prevents fetching the same object from archive file twice.
|
|
# This test triggers that code, without it we would fail to link output.
|
|
|
|
# RUN: echo '.globl foo, bar; foo:' | llvm-mc -filetype=obj -triple=x86_64-unknown-linux - -o %tfoo.o
|
|
# RUN: echo '.globl foo, bar; bar:' | llvm-mc -filetype=obj -triple=x86_64-unknown-linux - -o %tbar.o
|
|
# RUN: rm -f %t.a
|
|
# RUN: llvm-ar rcs %t.a %tfoo.o %tbar.o
|
|
|
|
# RUN: llvm-mc -filetype=obj -triple=x86_64-pc-linux %s -o %t.o
|
|
# RUN: ld.lld %t.a %t.o -o %t
|
|
# RUN: llvm-nm %t | FileCheck %s
|
|
|
|
# RUN: ld.lld -shared %t.o -o %t.so
|
|
# RUN: ld.lld %t.a %t.so -o %t
|
|
# RUN: llvm-nm %t | FileCheck %s
|
|
|
|
# CHECK: T foo
|
|
|
|
_start:
|
|
callq foo
|