mirror of
https://github.com/llvm/llvm-project.git
synced 2025-04-25 22:06:06 +00:00
12ab3e6c84
* The format_arg attribute tells the compiler that the attributed function returns a format string that is compatible with a format string that is being passed as a specific argument. * Several NSString methods return copies of their input, so they would ideally have the format_arg attribute. A previous differential (D112670) added support for instancetype methods having the format_arg attribute when used in the context of NSString method declarations. * D112670 failed to account that instancetype can be sugared in certain narrow (but critical) scenarios, like by using nullability specifiers. This patch resolves this problem. Differential Revision: https://reviews.llvm.org/D113636 Reviewed By: ahatanak Radar-Id: rdar://85278860
42 lines
2.3 KiB
Objective-C
42 lines
2.3 KiB
Objective-C
// RUN: %clang_cc1 -verify -fsyntax-only %s
|
|
|
|
@interface NSString
|
|
+(instancetype)stringWithCString:(const char *)cstr __attribute__((format_arg(1)));
|
|
-(instancetype)initWithString:(NSString *)str __attribute__((format_arg(1)));
|
|
|
|
+(instancetype _Nonnull)nonNullableString:(NSString *)str __attribute__((format_arg(1)));
|
|
+(instancetype _Nullable)nullableString:(NSString *)str __attribute__((format_arg(1)));
|
|
@end
|
|
|
|
@protocol MaybeString
|
|
-(instancetype)maybeString:(const char *)cstr __attribute__((format_arg(1))); // expected-error {{function does not return string type}}
|
|
@end
|
|
|
|
@class NSAttributedString;
|
|
|
|
extern NSString *fa2 (const NSString *) __attribute__((format_arg(1)));
|
|
extern NSString *fa3 (NSString *) __attribute__((format_arg(1)));
|
|
|
|
extern void fc1 (const NSString *) __attribute__((format_arg)); // expected-error {{'format_arg' attribute takes one argument}}
|
|
extern void fc2 (const NSString *) __attribute__((format_arg())); // expected-error {{'format_arg' attribute takes one argument}}
|
|
extern void fc3 (const NSString *) __attribute__((format_arg(1, 2))); // expected-error {{'format_arg' attribute takes one argument}}
|
|
|
|
struct s1 { int i; } __attribute__((format_arg(1))); // expected-warning {{'format_arg' attribute only applies to Objective-C methods and non-K&R-style functions}}
|
|
union u1 { int i; } __attribute__((format_arg(1))); // expected-warning {{'format_arg' attribute only applies to}}
|
|
enum e1 { E1V0 } __attribute__((format_arg(1))); // expected-warning {{'format_arg' attribute only applies to}}
|
|
|
|
extern NSString *ff3 (const NSString *) __attribute__((format_arg(3-2)));
|
|
extern NSString *ff4 (const NSString *) __attribute__((format_arg(foo))); // expected-error {{use of undeclared identifier 'foo'}}
|
|
|
|
/* format_arg formats must take and return a string. */
|
|
extern NSString *fi0 (int) __attribute__((format_arg(1))); // expected-error {{format argument not a string type}}
|
|
extern NSString *fi1 (NSString *) __attribute__((format_arg(1)));
|
|
|
|
extern NSString *fi2 (NSString *) __attribute__((format_arg(1)));
|
|
|
|
extern int fi3 (const NSString *) __attribute__((format_arg(1))); // expected-error {{function does not return NSString}}
|
|
extern NSString *fi4 (const NSString *) __attribute__((format_arg(1)));
|
|
extern NSString *fi5 (const NSString *) __attribute__((format_arg(1)));
|
|
|
|
extern NSAttributedString *fattrs (const NSString *) __attribute__((format_arg(1)));
|