Raphael Isemann e97b991eef [lldb] Remove LLDB session dir and just store test traces in the respective test build directory
Test runs log some of their output to files inside the LLDB session dir. This
session dir is shared between all tests, so all the tests have to make sure they
choose a unique file name inside that directory. We currently choose by default
`<test-class-name>-<test-method-name>` as the log file name. However, that means
that if not every test class in the test suite has a unique class name, then we
end up with a race condition as two tests will try to write to the same log
file.

I already tried in D83767 changing the format to use the test file basename
instead (which we already require to be unique for some other functionality),
but it seems the code for getting the basename didn't work on Windows.

This patch instead just changes that dotest stores the log files in the build
directory for the current test. We know that directory is unique for this test,
so no need to generate some unique file name now. Also removes all the
environment vars and parameters related to the now unused session dir.

The new log paths now look like this for a failure in 'TestCppOperators`:
```
./lldb-test-build.noindex/lang/cpp/operators/TestCppOperators.test_dwarf/Failure.log
./lldb-test-build.noindex/lang/cpp/operators/TestCppOperators.test_dsym/Failure.log
./lldb-test-build.noindex/lang/cpp/operators/TestCppOperators.test_gmodules/Failure.log
```

Reviewed By: labath

Differential Revision: https://reviews.llvm.org/D92498
2020-12-04 11:43:10 +01:00

176 lines
4.3 KiB
Python

"""
Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
See https://llvm.org/LICENSE.txt for license information.
SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
Provides the configuration class, which holds all information related to
how this invocation of the test suite should be run.
"""
from __future__ import absolute_import
from __future__ import print_function
# System modules
import os
# Third-party modules
import unittest2
# LLDB Modules
import lldbsuite
# The test suite.
suite = unittest2.TestSuite()
# The list of categories we said we care about
categories_list = None
# set to true if we are going to use categories for cherry-picking test cases
use_categories = False
# Categories we want to skip
skip_categories = ["darwin-log"]
# Categories we expect to fail
xfail_categories = []
# use this to track per-category failures
failures_per_category = {}
# The path to LLDB.framework is optional.
lldb_framework_path = None
# Test suite repeat count. Can be overwritten with '-# count'.
count = 1
# The 'arch' and 'compiler' can be specified via command line.
arch = None
compiler = None
dsymutil = None
sdkroot = None
# The overriden dwarf verison.
dwarf_version = 0
# Any overridden settings.
# Always disable default dynamic types for testing purposes.
settings = [('target.prefer-dynamic-value', 'no-dynamic-values')]
# Path to the FileCheck testing tool. Not optional.
filecheck = None
# Path to the yaml2obj tool. Not optional.
yaml2obj = None
# The arch might dictate some specific CFLAGS to be passed to the toolchain to build
# the inferior programs. The global variable cflags_extras provides a hook to do
# just that.
cflags_extras = ''
# The filters (testclass.testmethod) used to admit tests into our test suite.
filters = []
# The regular expression pattern to match against eligible filenames as
# our test cases.
regexp = None
# Sets of tests which are excluded at runtime
skip_tests = None
xfail_tests = None
# Set this flag if there is any session info dumped during the test run.
sdir_has_content = False
# svn_info stores the output from 'svn info lldb.base.dir'.
svn_info = ''
# Default verbosity is 0.
verbose = 0
# By default, search from the script directory.
# We can't use sys.path[0] to determine the script directory
# because it doesn't work under a debugger
testdirs = [lldbsuite.lldb_test_root]
# The root of the test case tree (where the actual tests reside, not the test
# infrastructure).
test_src_root = lldbsuite.lldb_test_root
# Separator string.
separator = '-' * 70
failed = False
# LLDB Remote platform setting
lldb_platform_name = None
lldb_platform_url = None
lldb_platform_working_dir = None
# Apple SDK
apple_sdk = None
# The base directory in which the tests are being built.
test_build_dir = None
# The clang module cache directory used by lldb.
lldb_module_cache_dir = None
# The clang module cache directory used by clang.
clang_module_cache_dir = None
# Test results handling globals
test_result = None
# Reproducers
capture_path = None
replay_path = None
# The names of all tests. Used to assert we don't have two tests with the
# same base name.
all_tests = set()
# LLDB library directory.
lldb_libs_dir = None
# A plugin whose tests will be enabled, like intel-pt.
enabled_plugins = []
def shouldSkipBecauseOfCategories(test_categories):
if use_categories:
if len(test_categories) == 0 or len(
categories_list & set(test_categories)) == 0:
return True
for category in skip_categories:
if category in test_categories:
return True
return False
def get_filecheck_path():
"""
Get the path to the FileCheck testing tool.
"""
if filecheck and os.path.lexists(filecheck):
return filecheck
def get_yaml2obj_path():
"""
Get the path to the yaml2obj tool.
"""
if yaml2obj and os.path.lexists(yaml2obj):
return yaml2obj
def is_reproducer_replay():
"""
Returns true when dotest is being replayed from a reproducer. Never use
this method to guard SB API calls as it will cause a divergence between
capture and replay.
"""
return replay_path is not None
def is_reproducer():
"""
Returns true when dotest is capturing a reproducer or is being replayed
from a reproducer. Use this method to guard SB API calls.
"""
return capture_path or replay_path