mirror of
https://github.com/llvm/llvm-project.git
synced 2025-04-27 00:56:06 +00:00
0f1c1be196
We have a new policy in place making links to private resources something we try to avoid in source and test files. Normally, we'd organically switch to the new policy rather than make a sweeping change across a project. However, Clang is in a somewhat special circumstance currently: recently, I've had several new contributors run into rdar links around test code which their patch was changing the behavior of. This turns out to be a surprisingly bad experience, especially for newer folks, for a handful of reasons: not understanding what the link is and feeling intimidated by it, wondering whether their changes are actually breaking something important to a downstream in some way, having to hunt down strangers not involved with the patch to impose on them for help, accidental pressure from asking for potentially private IP to be made public, etc. Because folks run into these links entirely by chance (through fixing bugs or working on new features), there's not really a set of problematic links to focus on -- all of the links have basically the same potential for causing these problems. As a result, this is an omnibus patch to remove all such links. This was not a mechanical change; it was done by manually searching for rdar, radar, radr, and other variants to find all the various problematic links. From there, I tried to retain or reword the surrounding comments so that we would lose as little context as possible. However, because most links were just a plain link with no supporting context, the majority of the changes are simple removals. Differential Review: https://reviews.llvm.org/D158071
66 lines
2.0 KiB
C
66 lines
2.0 KiB
C
// RUN: %clang_cc1 %s -fsyntax-only -Wprivate-extern -verify
|
|
|
|
// PR3310
|
|
struct a x1; // expected-note 2{{forward declaration of 'struct a'}}
|
|
static struct a x2; // expected-warning{{tentative definition of variable with internal linkage has incomplete non-array type 'struct a'}}
|
|
struct a x3[10]; // expected-error{{array has incomplete element type 'struct a'}}
|
|
struct a {int x;};
|
|
static struct a x2_okay;
|
|
struct a x3_okay[10];
|
|
struct b x4; // expected-error{{tentative definition has type 'struct b' that is never completed}} \
|
|
// expected-note{{forward declaration of 'struct b'}}
|
|
|
|
const int a [1] = {1};
|
|
extern const int a[];
|
|
|
|
extern const int b[];
|
|
const int b [1] = {1};
|
|
|
|
extern const int c[] = {1}; // expected-warning{{'extern' variable has an initializer}}
|
|
const int c[];
|
|
|
|
int i1 = 1; // expected-note {{previous definition is here}}
|
|
int i1 = 2; // expected-error {{redefinition of 'i1'}}
|
|
int i1;
|
|
int i1;
|
|
extern int i5; // expected-note {{previous declaration is here}}
|
|
static int i5; // expected-error{{static declaration of 'i5' follows non-static declaration}}
|
|
|
|
static int i2 = 5; // expected-note 1 {{previous definition is here}}
|
|
int i2 = 3; // expected-error{{non-static declaration of 'i2' follows static declaration}}
|
|
|
|
static int i3 = 5;
|
|
extern int i3;
|
|
|
|
__private_extern__ int pExtern; // expected-warning {{use of __private_extern__ on a declaration may not produce external symbol private to the linkage unit and is deprecated}} \
|
|
// expected-note {{use __attribute__((visibility("hidden"))) attribute instead}}
|
|
int pExtern = 0;
|
|
|
|
int i4;
|
|
int i4;
|
|
extern int i4;
|
|
|
|
int (*pToArray)[];
|
|
int (*pToArray)[8];
|
|
|
|
int redef[10];
|
|
int redef[]; // expected-note {{previous definition is here}}
|
|
int redef[11]; // expected-error{{redefinition of 'redef'}}
|
|
|
|
void func(void) {
|
|
extern int i6; // expected-note {{previous declaration is here}}
|
|
static int i6; // expected-error{{static declaration of 'i6' follows non-static declaration}}
|
|
}
|
|
|
|
void func2(void)
|
|
{
|
|
extern double *p;
|
|
extern double *p;
|
|
}
|
|
|
|
static int a0[];
|
|
static int b0;
|
|
|
|
static int a0[] = { 4 };
|
|
static int b0 = 5;
|